Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 24, 2015, 5:08 p.m.) Review request for Aurora, Benjamin

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 24, 2015, 5:10 p.m.) Review request for Aurora, Benjamin

Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1414

Review Request 37727: Deb: Remove defunct default argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37727/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging

Re: Review Request 37731: Parameterize artifact version in builders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/#review96221 --- Ship it! build-artifact.sh (line 30)

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? There was a `production = True` kvarg added that required to reformat here. This is to enforce production

Re: Review Request 37727: Deb: Remove defunct default argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37727/#review96188 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 24, 2015, 8:02

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Absolutely. Otherwise, how will users specify

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 1 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 1 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96199 --- Ship it! api/src/main/thrift/org/apache/aurora/gen/api.thrift

Review Request 37731: Parameterize artifact version in builders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37731/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1410

Re: Review Request 37727: Deb: Remove defunct default argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37727/#review96197 --- Ship it! Ship It! - Kevin Sweeney On Aug. 24, 2015, 1:10 p.m.,

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8 p.m., Bill Farner wrote: examples/jobs/hello_world.aurora, line 29 https://reviews.apache.org/r/37719/diff/1/?file=1048456#file1048456line29 Revert? Maxim Khutornenko wrote: There was a `production = True` kvarg added that required to reformat here.

Re: Review Request 37731: Parameterize artifact version in builders.

On Aug. 24, 2015, 10:07 p.m., Kevin Sweeney wrote: build-artifact.sh, line 30 https://reviews.apache.org/r/37731/diff/1/?file=1048757#file1048757line30 For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Maxim Khutornenko wrote: Absolutely.

Re: Review Request 37740: Use zookeeperd package in vagrant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37740/#review96257 --- Ship it! That's pretty neat! - Maxim Khutornenko On Aug. 25,

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96258 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 12:03

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 4:54 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37731: Parameterize artifact version in builders.

On Aug. 24, 2015, 10:07 p.m., Kevin Sweeney wrote: build-artifact.sh, line 30 https://reviews.apache.org/r/37731/diff/1/?file=1048757#file1048757line30 For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96241 --- Ship it! build.gradle (line 128)

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96229 --- src/main/java/org/apache/aurora/scheduler/TierManager.java (line

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 24, 2015, 5:03 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37719: Revocable: schema changes.

On Aug. 25, 2015, 12:12 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/TierManager.java, line 39 https://reviews.apache.org/r/37719/diff/2/?file=1048730#file1048730line39 I suggest the 'prod' constant go in api.thrift. This will require deprecation cycle and

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 12:54 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37740: Use zookeeperd package in vagrant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37740/ --- (Updated Aug. 25, 2015, 12:56 a.m.) Review request for Aurora and Maxim

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96267 --- Ship it! +1 with the known requirement that there will be a follow

Re: Review Request 37742: Remove use of host attributes from e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37742/#review96275 --- Ship it! Master (f202f2d) is green with this patch.

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96250 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 12:03 a.m.,

Review Request 37742: Remove use of host attributes from e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37742/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 37719: Revocable: schema changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96278 --- Ship it! Master (f202f2d) is green with this patch.

Re: Review Request 37731: Parameterize artifact version in builders.

On Aug. 24, 2015, 3:07 p.m., Kevin Sweeney wrote: build-artifact.sh, line 30 https://reviews.apache.org/r/37731/diff/1/?file=1048757#file1048757line30 For the RPM spec consider making this argument an explicit command-line flag (with `--define`) rather than an environment

Re: Review Request 37666: Import of Twitter Commons.

On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote: It would be great to preserve all commit history with this import. Any chance you could follow the sapling split procedure? It's a bit involved but pretty well documented here: https://github.com/jsirois/sapling Zameer Manji

Re: Review Request 37719: Revocable: schema changes.

On Aug. 24, 2015, 8:57 p.m., Zameer Manji wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 255 https://reviews.apache.org/r/37719/diff/1/?file=1048455#file1048455line255 Will this attribute be required in the future? Maxim Khutornenko wrote: Absolutely.

Review Request 37743: Replace realpath to get build working on jenkins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37743/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora-packaging

Re: Review Request 37742: Remove use of host attributes from e2e tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37742/#review96286 --- src/test/sh/org/apache/aurora/e2e/http/http_example.aurora

Re: Review Request 37666: Import of Twitter Commons.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96293 --- Ship it! Master (cb84ed2) is green with this patch.

Re: Review Request 37743: Replace realpath to get build working on jenkins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37743/#review96283 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 2:27

Re: Review Request 37743: Replace realpath to get build working on jenkins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37743/#review96289 --- Ship it! on Linux you can use `readlink -f` for this as well -

Re: Review Request 37744: Upgrade to gradle 2.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37744/#review96288 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 3:45

Review Request 37744: Upgrade to gradle 2.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37744/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora