Review Request 42077: Introduces -default_docker_parameters scheduler flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1575

Re: Review Request 42073: Fix exception thrown in SchedulingBenchmarks set up.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42073/#review113498 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 8, 2016, 6:14

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review113507 --- I've only shortly skimmed the documentation. Minor nitpick there:

Re: Review Request 42078: Bump JMH to 1.11.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42078/#review113511 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 8, 2016, 6:41

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review113514 --- Ship it! Master (217640f) is green with this patch.

Review Request 42078: Bump JMH to 1.11.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42078/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

> On Jan. 8, 2016, 6:50 p.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 187 > > > > > > Make it more explicit that those will only be used if a job has no > > custom paramters. Yep, can do,

Review Request 42080: Upgrade to pants 0.0.67.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42080/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 42080: Upgrade to pants 0.0.67.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42080/#review113523 --- Ship it! Master (c595228) is green with this patch.

Re: Review Request 42080: Upgrade to pants 0.0.67.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42080/#review113520 --- Ship it! Ship It! - Zameer Manji On Jan. 8, 2016, 11:39 a.m.,

Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review113591 --- Master (b25ab87) is green with this patch.

Re: Review Request 42078: Bump JMH to 1.11.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42078/#review113516 --- Ship it! Master (217640f) is green with this patch.

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/ --- (Updated Jan. 8, 2016, 10:54 a.m.) Review request for Aurora and John Sirois.

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/#review113451 --- Ship it! Master (206a48b) is green with this patch.

Re: Review Request 42041: Enable H2 query statistics collection.

> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/ --- (Updated Jan. 8, 2016, 1:52 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42041: Enable H2 query statistics collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113552 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 8, 2016, 9:52

Re: Review Request 42102: Fix flaky `ServerSetImplTest` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42102/#review113606 --- Ship it! Nice sleuthing! - Bill Farner On Jan. 8, 2016, 7:27

Review Request 42102: Fix flaky `ServerSetImplTest` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42102/ --- Review request for Aurora, George Sirois and Bill Farner. Bugs: AURORA-1574

Re: Review Request 42102: Fix flaky `ServerSetImplTest` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42102/#review113602 --- Ship it! Master (b25ab87) is green with this patch.

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

> On Jan. 7, 2016, 7:27 p.m., John Sirois wrote: > > Sorry for all the comments late in the feedback loop, I just started > > looking at this RB. Everything LGTM and this is all mainly nitpicks. I > > found 1 bug - marked as an issue - that's not actually exposed but would be > > good to

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/ --- (Updated Jan. 8, 2016, 10:43 a.m.) Review request for Aurora and John Sirois.

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

> On Jan. 8, 2016, 9:22 a.m., John Sirois wrote: > > Thanks Martin! Please mark this review as closed. > > > > Now on master: > > > > git log -1 origin/master > > commit 024bac9dcb8f37e4b31210e3a0a7aea2345a16ab > > Author: Martin Hrabovcin > > Date: Fri Jan 8 09:18:11

Re: Review Request 42042: Proof of concept - param interface implementations defined based on command line args

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42042/#review113489 --- Just notes, waiting on the discussion thread to settle as you are.

Re: Review Request 41785: Replace scheduler log scaffolding with logback

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review113492 --- build.gradle (line 345)

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/#review113485 --- Thanks Martin! Please mark this review as closed. Now on master: