Re: Review Request 42666: Deprecating TaskQuery in killTasks.

> On Jan. 22, 2016, 7:42 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java, > > line 132 > > > > > > s/consider removing/Remove/, +

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:13 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

> On Jan. 22, 2016, 7:44 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 444 > > > > > > Nearly forgot - in this branch, you should log and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115930 --- Fix it, then Ship it!

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 10:28 a.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 6:28 p.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 6:28 p.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/ --- (Updated Jan. 22, 2016, 1:21 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115943 --- Ship it! Master (2da1700) is green with this patch.

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115936 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 22, 2016,

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

> On Jan. 22, 2016, 9:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 441 > > > > > > Following up from earlier comment - `active()` scoping

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

> On Jan. 22, 2016, 1:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 441 > > > > > > Following up from earlier comment - `active()` scoping

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:36 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115939 --- This patch does not apply cleanly against master (2da1700), do

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- (Updated Jan. 22, 2016, 9:43 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115940 --- Ship it!

Re: Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42668/#review115942 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 22, 2016,

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 10:28 a.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115932 --- Ship it! Ship It! - John Sirois On Jan. 22, 2016, 2:21

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 6:28 p.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 7:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 10:28 a.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115892 --- Ship it! Ship It! - John Sirois On Jan. 22, 2016, 1:11 a.m.,

Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1583

Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42668/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

> On Jan. 22, 2016, 10:28 a.m., John Sirois wrote: > > The mechanics of the change lgtm, but is there some other way to add schema > > / data updates to a new aurora release such that they get applied after > > recovering the log but before doing anything else? I guess its valid to > > say

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115910 ---

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/#review115888 --- The mechanics of the change lgtm, but is there some other way to

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115903 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2016, 10:47 a.m.,

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115905 --- Master (66a4d5f) is red with this patch.

Re: Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42668/#review115909 --- Ship it! Master (66a4d5f) is green with this patch.

Re: Review Request 42639: Simplify TaskHistoryPruner tie-in to Lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115911 --- Ship it! Ship It! - Bill Farner On Jan. 21, 2016, 6:47 p.m.,

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

> On Jan. 22, 2016, 9:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 439 > > > > > > DRY? I actually meant to only do the

Re: Review Request 42666: Deprecating TaskQuery in killTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42666/#review115946 --- Ship it! Master (4b3d7bc) is green with this patch.

Re: Review Request 42646: Remove storage backfill and TaskStore mutateTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42646/ --- (Updated Jan. 22, 2016, 12:11 a.m.) Review request for Aurora, John Sirois and

Re: Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42668/#review115954 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2016, 11:23

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42656/#review115870 --- Ship it! Master (66a4d5f) is green with this patch.

Review Request 42656: Don't destroy session between requests with TRequestsTransport

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42656/ --- Review request for Aurora. Repository: aurora Description --- As an API

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 22, 2016, 2:44 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will