Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 6:30 p.m., Zameer Manji wrote: > > docs/features/containers.md, line 111 > > > > > > Why did you add support for creds? Is it not possible to have a > > registry with unauthenticated reads? The

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151292 --- Master (ed72b1b) is red with this patch.

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151175 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 10:53

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/#review151172 --- Packages created for Xenial will still embed the executor eggs

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151173 --- Ship it! Ship It! - Stephan Erb On Oct. 1, 2016, 12:53

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151205 --- I don't think that the registry to resolve against should be an

Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- Review request for Aurora, George Sirois and Joshua Cohen. Bugs: AURORA-1014

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151206 --- Ship it! Master (ed72b1b) is green with this patch.

Review Request 52494: Added the 'reason' to the /pendingTasks endpoint

2016-10-03 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52494/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Zameer Manji
> On Oct. 3, 2016, 8:46 a.m., Stephan Erb wrote: > > Packages created for Xenial will still embed the executor eggs for Trusty. > > This is the same problem described here > > https://issues.apache.org/jira/browse/AURORA-1712 > > > > We have to find a way how we can inject the appropriate

Re: Review Request 52494: Added the 'reason' to the /pendingTasks endpoint

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52494/#review151259 --- Master (ed72b1b) is red with this patch.

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-03 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 4, 2016, 12:42 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Zameer Manji
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151276 --- docs/features/containers.md (line 111)

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151294 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Oct. 3, 2016,

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151282 --- Master (ed72b1b) is green with this patch.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- (Updated Oct. 3, 2016, 7:05 p.m.) Review request for Aurora, George Sirois,

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Santhosh Kumar Shanmugham
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review151299 --- Master (ed72b1b) is red with this patch.

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-03 Thread Pradyumna Kaushik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/ --- (Updated Oct. 4, 2016, 3:20 a.m.) Review request for Aurora and Maxim

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51993/#review151293 --- Master (ed72b1b) is green with this patch.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-03 Thread Zameer Manji
> On Oct. 3, 2016, 11:22 a.m., Joshua Cohen wrote: > > I don't think that the registry to resolve against should be an argument to > > the docker helper, as this should likely be controlled by Aurora operators, > > not by Aurora users. When we originally discussed this, we talked about > >