Review Request 62590: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186324 --- Master (0606369) is red with this patch.

Re: Review Request 62601: Remove the rewriteConfigs thrift method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/ --- (Updated Sept. 26, 2017, 5:20 p.m.) Review request for Aurora, David

Re: Review Request 62601: Remove the rewriteConfigs thrift method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/#review186344 --- Master (79ff364) is red with this patch.

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186349 --- Fix it, then Ship it! Small naming nit but otherwise LGTM

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186355 --- @ReviewBot retry Not sure if the above failure is transient, and

Review Request 62601: Remove the rewriteConfigs thrift method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/ --- Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.

Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/ --- (Updated Sept. 26, 2017, 5:25 p.m.) Review request for Aurora and Jordan Ly.

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

> On Sept. 26, 2017, 5:22 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Line 122 (original), 122 (patched) > > > > > > I would probably rename `existingTasks`

Re: Review Request 62601: Remove the rewriteConfigs thrift method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/#review186357 --- Ship it! Master (79ff364) is green with this patch.

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186360 --- Master (79ff364) is green with this patch.

Review Request 62608: Workaround to get pants working in macOS high sierra

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62608/ --- Review request for Aurora and John Sirois. Repository: aurora Description

Re: Review Request 62608: Workaround to get pants working in macOS high sierra

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62608/#review186366 --- @ReviewBot retry The above failure looks unrelated, seems like

Re: Review Request 62451: Implement Role and Environment pages in Preact.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62451/#review186347 --- ui/src/main/js/index.js Line 17 (original), 18 (patched)

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186361 --- Ship it! Ship It! - Reza Motamedi On Sept. 27, 2017, 12:25

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. (this = the switch to cmake) - Bill --- This is an

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review186342 --- ``` /bin/sh: cmake: command not found ``` But now i need to

Re: Review Request 62604: Use a more efficient query for instance ID collision detection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/#review186354 --- Master (79ff364) is red with this patch.

Re: Review Request 62608: Workaround to get pants working in macOS high sierra

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62608/#review186364 --- Master (79ff364) is red with this patch.

Re: Review Request 62558: Restore scheduler benchmarks to working order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62558/#review186268 --- Ship it! Ship It! - Stephan Erb On Sept. 26, 2017, 8:04

Re: Review Request 62558: Restore scheduler benchmarks to working order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62558/#review186267 --- Thanks! I am currently working on the update to Thrift 0.10 and

Re: Review Request 62558: Restore scheduler benchmarks to working order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62558/#review186276 --- Ship it! Ship It! - David McLaughlin On Sept. 26, 2017,

Review Request 62558: Restore scheduler benchmarks to working order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62558/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 62608: Workaround to get pants working in macOS high sierra

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62608/#review186371 --- Ship it! Ship It! - John Sirois On Sept. 26, 2017, 7:51

Re: Review Request 62601: Remove the rewriteConfigs thrift method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/#review186374 --- Ship it! Ship It! - David McLaughlin On Sept. 27, 2017,

Re: Review Request 62601: Remove the rewriteConfigs thrift method

> On Sept. 27, 2017, 5:21 a.m., David McLaughlin wrote: > > Ship It! +1 from Twitter for skipping the deprecation cycle - we do not use this. - David --- This is an automatically generated e-mail. To reply, visit: