Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22214/#review44651 --- Ship it! Ship It! - David McLaughlin On June 3, 2014, 5:40 p.m.,

Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22214/ --- (Updated June 3, 2014, 1:40 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22214/#review44649 --- Ship it! src/main/python/apache/aurora/client/cli/standalone_clien

Re: Review Request 22092: Fixed syntax gotcha in .gitignore.

2014-06-03 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22092/ --- (Updated June 3, 2014, 5:35 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Mark Chu-Carroll
> On June 3, 2014, 1:27 p.m., Maxim Khutornenko wrote: > > Could you give more details why this is needed? I was assuming we gradually > > deprecate v1 along with the bridge keeping the existing build targets. Open-source folks have repeatedly asked for a standalone v2 client. It seems like a

Re: Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22214/#review44647 --- Could you give more details why this is needed? I was assuming we gr

Review Request 22214: Add a target for a standalone v2 client.

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22214/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44644 --- Ship it! Ship It! - Maxim Khutornenko On June 3, 2014, 5:07 p.m.

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Mark Chu-Carroll
> On June 3, 2014, 1:11 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 401 > > > > > > What about SystemExit? Should not that be trapped here as well? No - in clientv2, y

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44640 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/ --- (Updated June 3, 2014, 1:07 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
> On June 3, 2014, 4:32 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/test_config.py, line 24 > > > > > > These import order fixing will need to be rebased if > > https://reviews.apache.org/r/

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Mark Chu-Carroll
> On June 3, 2014, 12:32 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/test_config.py, line 24 > > > > > > These import order fixing will need to be rebased if > > https://reviews.apache.org/r

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44632 --- src/test/python/apache/aurora/client/cli/test_create.py

Re: Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Antoine Tollenaere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44628 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22023/#review44286 --- src/main/python/apache/aurora/client/cli/context.py

Review Request 22207: Prevent keyboard interrupts from spewing stack dumps.

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora

Re: Review Request 22168: Make style consistent with build-support/python/checkstyle-check

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22168/#review44622 --- Ship it! Ship It! - Mark Chu-Carroll On June 2, 2014, 8:38 p.m.,

Re: Review Request 22165: Fix python import order

2014-06-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22165/#review44623 --- Ship it! Ship It! - Mark Chu-Carroll On June 2, 2014, 7:30 p.m.,