Re: Review Request 34015: Improve client update json output to consistently use last_modified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/#review83331 --- Ship it! Ship It! - Bill Farner On May 11, 2015, 10:19 p.m., Joe

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/#review83304 --- Ship it! Overall LGTM. I'd like to see the move away from the poll

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

> On May 11, 2015, 10:02 p.m., Maxim Khutornenko wrote: > > Thanks! Bill is taking a look as well, so I will wait for his feedback before updating. - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83306 --- Ship it! - Maxim Khutornenko On May 9, 2015, 5:53 p.m., Bill Farn

Re: Review Request 34020: Normalize SLA stat names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34020/#review83302 --- As Maxim pointed out on the ticket, there is a compatibility concern

Re: Review Request 34015: Improve client update json output to consistently use last_modified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/#review83301 --- Ship it! Master (aabb692) is green with this patch. ./build-suppo

Re: Review Request 34015: Improve client update json output to consistently use last_modified

> On May 11, 2015, 2:29 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 473 > > > > > > IMHO it's the other side that should conform to `last_modified` since > > snake case is use

Re: Review Request 34015: Improve client update json output to consistently use last_modified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/ --- (Updated May 11, 2015, 3:19 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 34015: Improve client update json output to consistently use last_modified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/ --- (Updated May 11, 2015, 3:19 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/#review83293 --- Ship it! src/main/java/org/apache/aurora/scheduler/UserTaskLaunche

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

> On May 10, 2015, 12:10 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 211 > > > > > > You mentioned that updates should be processed in FIFO order. As we > > have

Re: Review Request 34015: Improve client update json output to consistently use lastModified

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34015/#review83290 --- src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/#review83268 --- Ship it! Master (aabb692) is green with this patch. ./build-suppo

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

> On May 10, 2015, 12:10 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 211 > > > > > > You mentioned that updates should be processed in FIFO order. As we > > have

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33689/ --- (Updated May 11, 2015, 6:55 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 33689: Updated scheduler to process status updates asynchronously in batches.

> On May 7, 2015, 10:24 p.m., Maxim Khutornenko wrote: > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line > > 191 > > > > > > Delete TODO. > > Zameer Manji wrote: > +1 Done. > On May

Re: Review Request 34046: Upgade h2 to 1.4.187.

> On May 11, 2015, 5:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 84 > > > > > > Link to upstream ticket would be good here. AFAICT there is not an issue tr

Re: Review Request 33455: Use "a" mode instead of "w" when opening stdout and stderr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33455/ --- (Updated May 11, 2015, 11:37 a.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 34046: Upgade h2 to 1.4.187.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046/#review83253 --- Master (339840d) is green with this patch. ./build-support/jenkins

Re: Review Request 33455: Use "a" mode instead of "w" when opening stdout and stderr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33455/#review83244 --- ping, Brian - Kevin Sweeney On April 22, 2015, 3:47 p.m., Kevin S

Re: Review Request 34046: Upgade h2 to 1.4.187.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046/#review83243 --- Ship it! Ship It! - Maxim Khutornenko On May 11, 2015, 5:58 p.m.

Re: Review Request 34046: Upgade h2 to 1.4.187.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046/#review83242 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DbMo

Review Request 34046: Upgade h2 to 1.4.187.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34046/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-13

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review83229 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DbMo

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On May 7, 2015, 10:22 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java, > > lines 102-106 > > > > > > It'd be nice if this was extracted out to a higher level so it