Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111354 --- Ship it! Master (5183fe0) is green with this patch. ./build-supp

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/ --- (Updated Dec. 18, 2015, 7:03 p.m.) Review request for Aurora, Joshua Cohen, Joh

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 4:43 p.m., John Sirois wrote: > > docs/installing.md, line 126 > > > > > > Had to s/ mesos// and then: > > ``` > > wget -c > > http://downloads.mesosphere.io/master/ubuntu/14.04/mesos_0.2

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 3:45 p.m., John Sirois wrote: > > docs/installing.md, line 111 > > > > > > Invalid URL - I updated to > > http://people.apache.org/~wfarner/aurora/distributions/0.10.0-1/rpm/centos-7/ > > to get

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote: > > docs/installing.md, line 29 > > > > > > You are happily mixing the terms jobs and services here. Other sections > > of this document also use the word task. It is

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111322 --- Not as thorough a check of Ubuntu, but so far: docs/installing.md

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 12:12 p.m., John Sirois wrote: > > > > John Sirois wrote: > I won't be able to get to trials until later this evening. Ideally > though this doc could be tied to the test/ provision.sh's somehow for more > assured working-ness. I have no useful suggestion though atm o

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
> On Dec. 18, 2015, 3:16 p.m., Stephan Erb wrote: > > docs/installing.md, line 146 > > > > > > Isn't that outdated? I think so - I used `sudo yum install -y mesos-0.23` for this step. - John

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111296 --- The comments below are from a test of CentOS 7 instructions - using

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Stephan Erb
> On Dez. 18, 2015, 9:12 nachm., John Sirois wrote: > > > > John Sirois wrote: > I won't be able to get to trials until later this evening. Ideally > though this doc could be tied to the test/ provision.sh's somehow for more > assured working-ness. I have no useful suggestion though atm

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111273 --- Awesome document! Such a thing would have been quite helpful when w

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 1:25 p.m., John Sirois wrote: > > LGTM mod trailing ws if that's deemed undesirable in this repo. Context - that's meaningful syntax. It's the markdown equivalent of ``: http://daringfireball.net/projects/markdown/syntax#p - Bill

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111272 --- Ship it! LGTM mod trailing ws if that's deemed undesirable in this

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111270 --- Ship it! Master (5183fe0) is green with this patch. ./build-supp

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/ --- (Updated Dec. 18, 2015, 12:39 p.m.) Review request for Aurora, Joshua Cohen, Jo

Re: Review Request 41565: Improve review_feedback.py testability.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 12:13 p.m., Aurora ReviewBot wrote: > > Master (1c73438) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > John Sirois wrote: > Bill - I'm ignorant of the

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/ --- (Updated Dec. 18, 2015, 12:38 p.m.) Review request for Aurora, Joshua Cohen, Jo

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 12:11 p.m., Maxim Khutornenko wrote: > > docs/installing.md, line 58 > > > > > > This is very important part of our infrastructure. I'd add a bit more > > details here highlighting its importance

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 12:12 p.m., John Sirois wrote: > > docs/installing.md, line 155 > > > > > > believing Fixed. > On Dec. 18, 2015, 12:12 p.m., John Sirois wrote: > > docs/installing.md, line 157 > >

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
> On Dec. 18, 2015, 1:12 p.m., John Sirois wrote: > > I won't be able to get to trials until later this evening. Ideally though this doc could be tied to the test/ provision.sh's somehow for more assured working-ness. I have no useful suggestion though atm of how to do that reasonably. -

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Maxim Khutornenko
> On Dec. 18, 2015, 8:11 p.m., Maxim Khutornenko wrote: > > docs/installing.md, line 58 > > > > > > This is very important part of our infrastructure. I'd add a bit more > > details here highlighting its importance (

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 12:11 p.m., Maxim Khutornenko wrote: > > docs/installing.md, line 58 > > > > > > This is very important part of our infrastructure. I'd add a bit more > > details here highlighting its importance

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111261 --- Ship it! Master (1c73438) is green with this patch. ./build-supp

Re: Review Request 41565: Improve review_feedback.py testability.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41565/#review111259 --- Ship it! - Bill Farner On Dec. 18, 2015, noon, John Sirois wrote

Re: Review Request 41565: Improve review_feedback.py testability.

2015-12-18 Thread John Sirois
> On Dec. 18, 2015, 1:13 p.m., Aurora ReviewBot wrote: > > Master (1c73438) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Bill - I'm ignorant of the Jenkins setup - is this using

Re: Review Request 41565: Improve review_feedback.py testability.

2015-12-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41565/#review111257 --- Ship it! Master (1c73438) is green with this patch. ./build-supp

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111251 --- docs/installing.md (line 155)

Re: Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/#review111253 --- docs/installing.md (line 58)

Review Request 41565: Improve review_feedback.py testability.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41565/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Review Request 41564: Add a guide for installing Aurora.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41564/ --- Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji. Reposit

Re: Review Request 41559: Fix the ZK URI in the rpm.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41559/#review111227 --- Ship it! NMM - you did that! - John Sirois On Dec. 18, 2015, 11

Re: Review Request 41559: Fix the ZK URI in the rpm.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41559/#review111226 --- 1 more - README needs updating: ``` $ git grep "zk:" specs/debian/a

Review Request 41559: Fix the ZK URI in the rpm.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41559/ --- Review request for Aurora and John Sirois. Repository: aurora-packaging Descr

Re: Review Request 41558: Update the scheduler DB paths in the RPM spec to match debs.

2015-12-18 Thread Bill Farner
> On Dec. 18, 2015, 10:09 a.m., John Sirois wrote: > > Checking my understanding: Since there has been no official rpm release, > > moving the native log path is deemed safe since it affects no-one. Ack. - Bill --- This is an automatic

Re: Review Request 41558: Update the scheduler DB paths in the RPM spec to match debs.

2015-12-18 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41558/#review111215 --- Ship it! Checking my understanding: Since there has been no offici

Review Request 41558: Update the scheduler DB paths in the RPM spec to match debs.

2015-12-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41558/ --- Review request for Aurora and John Sirois. Repository: aurora-packaging Descr

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review111207 --- Ship it! Ship It! - Zameer Manji On Dec. 17, 2015, 1:27 p.m., J

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review57 --- Ship it! Thanks for looking into this! - Stephan Erb On Dec. 17