Re: Review Request 42727: Remove the --announcer-enable executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116334 --- Ship it! Ship It! - Stephan Erb On Jan. 25, 2016, 7:03

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

> On Jan. 25, 2016, 3:55 p.m., John Sirois wrote: > > NB: Please hold off on review pending an email to dev@ explaining this 3 RB > > proposal. Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz - John

Re: Review Request 42749: [2/3] Add an annotation processor to generate db views.

> On Jan. 25, 2016, 3:43 p.m., John Sirois wrote: > > NB: Please hold off on review pending an email to dev@ explaining this 3 RB > > proposal. Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz - John

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

> On Jan. 25, 2016, 3:28 p.m., John Sirois wrote: > > NB: Please hold off on review pending an email to dev@ explaining this 3 RB > > proposal. Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz - John

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116535 --- I'll submit this tomorrow ~noon PST and start cutting an 0.12.0

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 26, 2016, 9:01 p.m.) Review request for Aurora. Bugs:

Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1593

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116356 --- Can only test reviews with 1 parent, found 2:

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

> On Jan. 26, 2016, 7:57 a.m., Aurora ReviewBot wrote: > > Can only test reviews with 1 parent, found 2: > > https://reviews.apache.org/api/review-requests/42639/ > > https://reviews.apache.org/api/review-requests/42332/ > > > > I will refresh this build result if you post a review

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

- John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116356 --- On Jan. 26, 2016, 8 a.m., John Sirois wrote: > >

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116359 --- @ReviewBot retry - John Sirois On Jan. 26, 2016, 8 a.m., John

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/ --- (Updated Jan. 26, 2016, 8 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116376 --- Ship it! Master (39815a3) is green with this patch.

Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116386 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 26, 2016,

Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116391 --- Ship it! Ship It! - Joshua Cohen On Jan. 26, 2016, 4:49

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/#review116394 --- Ship it! Ship It! - Bill Farner On Jan. 25, 2016, 6:42

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116396 --- Ship it! Ship It! - Bill Farner On Jan. 26, 2016, 7 a.m.,

Re: Review Request 42801: `TaskHistoryPruner` controls Lifecycle directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42801/#review116397 --- Ship it! Ship It! - Zameer Manji On Jan. 26, 2016, 7 a.m.,

Re: Review Request 42727: Remove the --announcer-enable executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116398 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2016, 10:03

Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Repository:

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/ --- (Updated Jan. 26, 2016, 10:37 a.m.) Review request for Aurora, John Sirois and

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 26, 2016, 11:37 a.m.) Review request for Aurora. Bugs:

Re: Review Request 42727: Remove the --announcer-enable executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/ --- (Updated Jan. 26, 2016, 10:40 a.m.) Review request for Aurora, Maxim

Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko,

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116415 --- Ship it! Ship It! - John Sirois On Jan. 26, 2016, 12:04

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ --- (Updated Jan. 26, 2016, 12:11 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ --- (Updated Jan. 26, 2016, 12:13 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116418 --- Ship it! Ship It! - Bill Farner On Jan. 26, 2016, 11:13

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116419 --- src/test/python/apache/aurora/client/test_config.py

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ --- (Updated Jan. 26, 2016, 12:26 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote: > > src/test/python/apache/aurora/client/test_config.py, lines 213-223 > > > > > > this test is still relevant though, no? you still need to validate that >

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116426 --- Ship it! Fair enough. - Dmitriy Shirchenko On Jan. 26,

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116420 --- Ship it! Master (7ccd532) is green with this patch.

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote: > > src/test/python/apache/aurora/client/test_config.py, lines 213-223 > > > > > > this test is still relevant though, no? you still need to validate that >

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116429 --- Ship it! Master (7ccd532) is green with this patch.

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

> On Jan. 26, 2016, 7:24 p.m., Dmitriy Shirchenko wrote: > > src/test/python/apache/aurora/client/test_config.py, lines 213-223 > > > > > > this test is still relevant though, no? you still need to validate that >