Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:36 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > line 290 > > > > > > This test doesn't seem appropriately named? It's not

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:14 p.m., Aurora ReviewBot wrote: > > Master (72bf8db) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :processJmhResources UP-TO-DATE > > :jmhClasses > > :checkstyleJmh > > :jsHint > > :checkstyleMain > >

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 5:36 p.m., Joshua Cohen wrote: > > Given the proposal to move towards the Mesos unified containerizer, do you > > think it makes sense to hold off on this and instead implement it in > > conjunction with those upcoming changes? > > > > I haven't gotten any direct feedback

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123051 --- Master (72bf8db) is green with this patch.

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123052 --- nit: I feel like this diff may be better described as "Add

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

> On March 10, 2016, 4:40 p.m., Zameer Manji wrote: > > I think Josh should be added to this review since he is working on > > supporting the Mesos Universal Containerizer (see his recent design doc to > > dev@) Josh is welcome to chime in :-) Do you mean that i should remove you in favor of

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123045 --- I think Josh should be added to this review since he is working

Re: Review Request 44685: Add scheduler support for running tasks using the mesos Docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44685/#review123044 ---

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123039 --- Ship it! Ship It! - Zameer Manji On March 10, 2016, 2:36

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123036 --- @ReviewBot retry - Joshua Cohen On March 10, 2016, 10:36 p.m.,

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123034 --- Master (72bf8db) is red with this patch.

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123026 --- @ReviewBot retry - Joshua Cohen On March 10, 2016, 10:36 p.m.,

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123023 --- Master (72bf8db) is red with this patch.

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review123018 --- Ship it! Ship It! - Bill Farner On March 10, 2016, 10:59

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/ --- (Updated March 10, 2016, 10:36 p.m.) Review request for Aurora and Zameer

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

> On March 10, 2016, 10:27 p.m., Stephan Erb wrote: > > +1 for re-raising. Thanks for confirming. Will update. > On March 10, 2016, 10:27 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 151 > >

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123013 --- Master (72bf8db) is red with this patch.

Re: Review Request 44532: Allow overriding hostname before announcing

> On March 10, 2016, 10:04 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95 > > > > > > Specifying the command here feels kind of weird. All other options we

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123014 --- +1 for re-raising.

Re: Review Request 44532: Allow overriding hostname before announcing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123011 ---

Re: Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/#review123010 --- src/main/python/apache/thermos/core/process.py (line 289)

Review Request 44680: Log exceptions raised when thermos running attempts to execute a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44680/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

> On March 10, 2016, 3:39 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 128 > > > > > > It looks like the existing usages have inexpensive message formatting, > >

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

> On March 10, 2016, 1:40 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 174 > > > > > > no big deal, but it would be nice if the line break style

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/ --- (Updated March 10, 2016, 8:19 p.m.) Review request for Aurora, Steve Niemitz

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

> On March 10, 2016, 8:10 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 286 > > > > > > How about this wording for the first sentence? > > > > | A wildcard (`*`) may be used for the

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/#review122981 --- Ship it! docs/deploying-aurora-scheduler.md (line 286)

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote: > > docs/deploying-aurora-scheduler.md, lines 289-291 > > > > > > I think this "only" is misleading here? If I understand correctly, a > > task,

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

> On March 10, 2016, 6:56 p.m., Joshua Cohen wrote: > > docs/deploying-aurora-scheduler.md, lines 289-291 > > > > > > I think this "only" is misleading here? If I understand correctly, a > > task,

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122968 --- Ship it! Master (31a538f) is green with this patch.

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/#review122963 --- Master (31a538f) is red with this patch.

Re: Review Request 44486: Exposing DSL defined variables to shell health checkers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/ --- (Updated March 10, 2016, 6:59 p.m.) Review request for Aurora, John Sirois,

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/#review122959 --- docs/deploying-aurora-scheduler.md (lines 289 - 291)

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44602/ --- (Updated March 10, 2016, 6:44 p.m.) Review request for Aurora, Steve Niemitz

Re: Review Request 44607: aurora-cli on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44607/#review122935 --- Ship it! Ship It! - Bill Farner On March 9, 2016, 9 p.m.,

Re: Review Request 44602: Adding non-role-exclusive dedicated constraint support

> On March 10, 2016, 12:21 a.m., Stephan Erb wrote: > > docs/deploying-aurora-scheduler.md, line 286 > > > > > > I don't find this sentence very clear. Would probably help to have a > > more explicit example

Re: Review Request 44493: Log and terminate scheduler on updater thread failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44493/#review122846 --- Ship it!