Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 18, 2016, 6:18 p.m.) Review request for Aurora, John Sirois, Ste

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123931 --- Ship it! Master (6537581) is green with this patch. ./build-s

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/ --- (Updated March 16, 2016, 8:51 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 45042: Add ACL support for announcer

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124431 --- Overall looks in decent shape, made some suggestions. Before this

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Bill Farner
> On March 15, 2016, 9:53 p.m., John Sirois wrote: > > .gitignore, line 1 > > > > > > Not related, but noticing this is a lie iiuc. Should be 'Use /dist/ to > > ignore dist in project root.' (reference 'PATTERN FORMA

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124424 --- Ship it! Ship It! - Bill Farner On March 19, 2016, 1 p.m., S

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Bill Farner
> On March 19, 2016, 1:44 p.m., Aurora ReviewBot wrote: > > Master (b24619b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > CAP#1 extends Unit from capture of ? > > /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/par

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124421 --- Master (b24619b) is red with this patch. ./build-support/jenkins

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/ --- (Updated March 17, 2016, 2:21 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124420 --- @ReviewBot retry - Stephan Erb On March 19, 2016, 9 p.m., Steph

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124418 --- Master (b24619b) is red with this patch. ./build-support/jenkins

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/ --- (Updated March 19, 2016, 9 p.m.) Review request for Aurora, Joshua Cohen and Bi

Review Request 45076: Improve presentation and organization of the scheduler landing page

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review123965 --- Fix it, then Ship it! Just one nit from me, otherwise LGTM! s

Re: Review Request 45042: Add ACL support for announcer

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review124334 --- Master (b24619b) is red with this patch. ./build-support/jenkins

Review Request 45042: Add ACL support for announcer

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D

Re: Review Request 44770: Create scheduler-configuration.md

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44770/ --- (Updated March 18, 2016, 10:19 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Bill Farner
> On March 17, 2016, 11:01 a.m., Aurora ReviewBot wrote: > > Master (6537581) is red with this patch. > > ./build-support/jenkins/build.sh > > > >  proxy_driver = ProxyDriver() > >  with temporary_dir() as checkpoint_root: > >

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 17, 2016, 4:32 p.m.) Review request for Aurora, John Sirois, Ste

Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/#review124331 --- Master (b24619b) is green with this patch. ./build-support/jenki

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 16, 2016, 7:43 p.m.) Review request for Aurora, John Sirois, Ste

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/#review124125 --- Ship it! Ship It! - Zameer Manji On March 17, 2016, 2:21 p.m

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 18, 2016, 7:04 p.m.) Review request for Aurora, John Sirois, Ste

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124244 --- docs/configuration-reference.md (line 472)

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/ --- (Updated March 17, 2016, 6:04 p.m.) Review request for Aurora, John Sirois, Ste

Re: Review Request 44532: Allow overriding hostname before announcing

2016-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44532/#review124076 --- Ship it! Master (6537581) is green with this patch. ./build-s

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

2016-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44871/ --- (Updated March 16, 2016, 10:44 p.m.) Review request for Aurora, John Sirois and