Re: Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/#review126276 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/ --- (Updated March 30, 2016, 10:55 p.m.) Review request for Aurora. Bugs: AURORA-

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126270 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated March 31, 2016, 5:06 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126257 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated March 31, 2016, 3:36 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/#review126252 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/ --- (Updated March 30, 2016, 7:58 p.m.) Review request for Aurora. Bugs: AURORA-3

Re: Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/#review126250 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126247 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On March 30, 2016, 11:30 p.m., Ashwin Murthy wrote: > > LeaderHealth Element Missed Instructions Cov.Missed Branches Cov.Missed Cxty Missed Lines Missed Methods Total 0 of 30 100%0 of 4 100%0 4 0 9 0 2 get() 22 100%4

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated March 31, 2016, 2:35 a.m.) Review request for Aurora and Bill Farner.

Review Request 45521: Remove client-side validation of environment names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45521/ --- Review request for Aurora. Bugs: AURORA-319 https://issues.apache.org/jira/

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126226 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 30, 2016, 4:41 p.m.) Review request for Aurora, Dmitriy Shirchen

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126223 --- src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126221 --- Master (193f17e) is red with this patch. ./build-support/jenkins

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126219 --- Master (55a2422) is red with this patch. ./build-support/jenkins

Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/ --- (Updated March 30, 2016, 4 p.m.) Review request for Aurora, Joshua Cohen and Ma

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 30, 2016, 3:07 p.m., John Sirois wrote: > > There is code to do this in apache.thermos.core.process.Process and its > > tested here: > > https://github.com/apache/aurora/blob/master/src/test/python/apache/thermos/core/test_process.py#L103 > > Process (ProcessBase) does look a bit fat

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126207 --- Master (55a2422) is red with this patch. ./build-support/jenkins

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126206 --- There is code to do this in apache.thermos.core.process.Process an

Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- Review request for Aurora, Dmitriy Shirchenko and Zameer Manji. Bugs: AURORA-16

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

> On March 30, 2016, 8:47 p.m., Joshua Cohen wrote: > > Ship It! Can you rebase and fix the conflicts in RELEASE-NOTES.md? Then I'll commit this. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126196 --- Ship it! Ship It! - Joshua Cohen On March 29, 2016, 5:51 p.m

Re: Review Request 45042: Add ACL support for announcer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review126191 --- Ship it! Thanks for sticking it out through the review, nice pa

Re: Review Request 45042: Add ACL support for announcer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/#review126190 --- Ship it! Master (bc4649e) is green with this patch. ./build-s

Re: Review Request 45042: Add ACL support for announcer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45042/ --- (Updated March 30, 2016, 7:50 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 45042: Add ACL support for announcer

> On March 28, 2016, 11:46 p.m., Bill Farner wrote: > > examples/vagrant/announcer-auth.json, line 11 > > > > > > I now have to backpedal on my advice to store the encrypted credentials > > here. Since our hand is f

Re: Review Request 45042: Add ACL support for announcer

> On March 30, 2016, 2:20 a.m., Bill Farner wrote: > > RELEASE-NOTES.md, line 14 > > > > > > s/Support/Added support/ > > s/ZK/ZooKeeper/ Done > On March 30, 2016, 2:20 a.m., Bill Farner wrote: > > docs/operati

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > > defaul

Re: Review Request 45467: [PROTOTYPE] Add support for DB migrations and rollbacks.

> On March 30, 2016, 10:59 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 180 > > > > > > As i read this, i found myself wishing for something tha

Re: Review Request 45467: [PROTOTYPE] Add support for DB migrations and rollbacks.

> On March 30, 2016, 10:59 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 180 > > > > > > As i read this, i found myself wishing for something tha

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > > defaul

Re: Review Request 45467: [PROTOTYPE] Add support for DB migrations and rollbacks.

> On March 30, 2016, 5:59 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java, > > line 180 > > > > > > As i read this, i found myself wishing for something that

Re: Review Request 45456: Use correct query to serve /maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45456/#review126154 --- Ship it! Master (ec29ac1) is green with this patch. ./build-s

Re: Review Request 45467: [PROTOTYPE] Add support for DB migrations and rollbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45467/#review126151 --- src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotSto

Re: Review Request 45456: Use correct query to serve /maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45456/#review126146 --- @ReviewBot retry - Bill Farner On March 29, 2016, 3:46 p.m., Bi

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > > defaul

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126132 --- Code-wise this looks fine to me, however, I have some reservations