Re: Review Request 49595: Fix thrift t_java_generator.ccc patch.

2016-07-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/#review140692 --- Ship it! Ship It! - Maxim Khutornenko On July 4, 2016, 3:45

Re: Review Request 49595: Fix thrift t_java_generator.ccc patch.

2016-07-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/#review140675 --- Ship it! Master (43db929) is green with this patch.

Review Request 49595: Fix thrift t_java_generator.ccc patch.

2016-07-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49595/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1727

Re: Review Request 49528: Patch thrift to compile under modern gcc.

2016-07-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49528/#review140671 ---

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140670 --- Ship it! Master (311b892) is green with this patch.

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140668 --- @ReviewBot retry - John Sirois On July 4, 2016, 8:52 a.m.,

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread John Sirois
> On July 4, 2016, 9:01 a.m., Stephan Erb wrote: > > While I am OK with using a pre-release on master, I'd really like to see us > > migrate to stable 1.1 before doing the next release of Aurora. We have never been on a stable yet, the naming scheme is just changed, ie `1.1.0-pre6` is

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140663 --- Ship it! While I am OK with using a pre-release on master, I'd

Re: Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140660 --- pants.ini (line 21)

Review Request 49593: Upgrade to pants 1.1.0-pre6.

2016-07-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1620

Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

2016-07-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49512/#review140619 --- Have you considered querying Mesos for the disk usage of the

Re: Review Request 49578: Close `PathChildrenCache` before its framework.

2016-07-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49578/#review140618 --- Ship it! Trusting your analysis, the patch looks sane to me.