Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152451 --- Ship it! Master (1b3b7f5) is green with this patch.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/ --- (Updated Oct. 12, 2016, 9:41 p.m.) Review request for Aurora, George Sirois,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-12 Thread Santhosh Kumar Shanmugham
> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java, > > line 40 > > > > > > .setVolumes(volumes) ? > > Zameer Manji

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152429 --- src/main/python/apache/aurora/executor/thermos_task_runner.py

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

2016-10-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/#review152423 --- We reverted the related code so I marked this diff as discarded.

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-12 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52437/ --- (Updated Oct. 12, 2016, 4:17 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 52806: Revert "Add min_consecutive_health_checks in HealthCheckConfig"

2016-10-12 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52806/#review152411 --- Ship it! Ship It! - Kai Huang On Oct. 12, 2016, 9:09 p.m.,

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Joshua Cohen
> On Oct. 12, 2016, 7:48 p.m., David McLaughlin wrote: > > Thanks for doing this! > > > > Could you add a test for this? Looking in test_task_runner.py, it looks > > like unfortunately the provider class lacks any sort of coverage. A minimal > > test here could be to just test the path

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152386 --- Master (03eff28) is green with this patch.

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/#review152385 --- Thanks for doing this! Could you add a test for this? Looking

Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs:

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

2016-10-12 Thread Justin Pinkul
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52804/ --- (Updated Oct. 12, 2016, 12:42 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152371 --- Ship it! Ship It! - Zameer Manji On Oct. 12, 2016, 1:46

Re: Review Request 52790: Upgrade pystachio to 0.8.3

2016-10-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152361 --- Ship it! This is now on master. - Zameer Manji On Oct. 12,

Re: Review Request 52790: Upgrade pystachio to 0.8.3

2016-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152354 --- Ship it! Master (e9abb22) is green with this patch.

Re: Review Request 52790: Upgrade pystachio to 0.8.3

2016-10-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152350 --- Ship it! Ship It! - Joshua Cohen On Oct. 12, 2016, 5:28

Re: Review Request 52790: Upgrade pystachio to 0.8.3

2016-10-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/#review152349 --- Ship it! Ship It! - John Sirois On Oct. 12, 2016, 11:28

Review Request 52790: Upgrade pystachio to 0.8.3

2016-10-12 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52790/ --- Review request for Aurora, George Sirois, Joshua Cohen, and Zameer Manji.

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152338 --- Ship it!

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread George Sirois
> On Oct. 11, 2016, 9:30 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/docker/docker_client.py, line 68 > > > > > > Any reason you went with this capitalization? The canonical > > capitalization

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152313 --- RELEASE-NOTES.md (line 14)

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

2016-10-12 Thread John Sirois
> On Oct. 12, 2016, 4:41 a.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

2016-10-12 Thread Stephan Erb
> On Oct. 12, 2016, 12:41 p.m., John Sirois wrote: > > Your testing done says this is enough on the aurora-packaging side, but on > > the [aurora > > side](https://github.com/apache/aurora/blob/master/build.gradle#L24) the > > installed plugin probably also needs to be changed from from

Re: Review Request 52777: Use Gradle installDist task rather than installApp.

2016-10-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/#review152291 --- Ship it! Your testing done says this is enough on the

Review Request 52777: Use Gradle installDist task rather than installApp.

2016-10-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52777/ --- Review request for Aurora and John Sirois. Repository: aurora-packaging

Re: Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/#review152285 --- Master (e9abb22) is green with this patch.

Review Request 52776: Blank out executor config in startJobUpdate log messages.

2016-10-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52776/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description