Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/#review170529 --- Ship it! Master (3a9aabd) is green with this patch.

Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.

2017-03-29 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/ --- (Updated March 29, 2017, 9:55 p.m.) Review request for Aurora and Zameer

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Santhosh Kumar Shanmugham
> On March 29, 2017, 9:41 p.m., Santhosh Kumar Shanmugham wrote: > > In the commit message - s/after we restroe s/after we restore from a Snapshot/before we restore from a Snapshot/ Slight -1 for forking special-casing the enum table migration, but I can see some benefit. - Santhosh Kumar

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/#review170525 --- Ship it! In the commit message - s/after we restroe -

Re: Review Request 58066: Fix schema to allow multiple task volumes per task.

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58066/#review170522 --- Ship it! Master (3a9aabd) is green with this patch.

Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/#review170519 --- Master (3a9aabd) is red with this patch.

Re: Review Request 58054: Sort the set objects inside TaskConfig during Job diff.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/#review170516 --- Ship it!

Review Request 58054: Sort the set objects inside TaskConfig during Job diff.

2017-03-29 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58054/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1913

Review Request 58066: Fix schema to allow multiple task volumes per task.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58066/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1914

Re: Review Request 58053: Reliably subscribe to Mesos in the HTTP Driver.

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58053/#review170504 --- Ship it! Master (3a9aabd) is green with this patch.

Review Request 58053: Reliably subscribe to Mesos in the HTTP Driver.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58053/ --- Review request for Aurora and Stephan Erb. Bugs: AURORA-1911

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/ --- (Updated March 29, 2017, 4:42 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 58017: Reset `framework_registered` metric on disconnection.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58017/ --- (Updated March 29, 2017, 1:33 p.m.) Review request for Aurora and Santhosh

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57487/#review170475 --- This patch does not apply cleanly against master (c32f14c), do

Re: Review Request 57487: Implementation of Dynamic Reservations Proposal

2017-03-29 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57487/ --- (Updated March 29, 2017, 8:29 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/#review170466 --- Ship it! Master (c32f14c) is green with this patch.

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/#review170462 --- Ship it! Ship It! - Joshua Cohen On March 29, 2017, 7:51

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Zameer Manji
> On March 29, 2017, 12:34 p.m., Joshua Cohen wrote: > > This may be an existing problem with the current impl as well, but what > > happens if we drop an enum value? Are we just assuming some other migration > > will have removed it (since presumably other tables will need to be updated > >

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/ --- (Updated March 29, 2017, 12:51 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Joshua Cohen
> On March 29, 2017, 7:34 p.m., Joshua Cohen wrote: > > This may be an existing problem with the current impl as well, but what > > happens if we drop an enum value? Are we just assuming some other migration > > will have removed it (since presumably other tables will need to be updated > >

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Zameer Manji
> On March 29, 2017, 12:34 p.m., Joshua Cohen wrote: > > This may be an existing problem with the current impl as well, but what > > happens if we drop an enum value? Are we just assuming some other migration > > will have removed it (since presumably other tables will need to be updated > >

Re: Review Request 58036: Ensure enum tables are complete afer a snapshot restore.

2017-03-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58036/#review170456 --- This may be an existing problem with the current impl as well,