Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

> On Oct. 20, 2017, 5:01 a.m., Bill Farner wrote: > > I don't feel strongly, but `DefaultServlet` can also send an etag header by > > instead setting `"etags", "true"`. > > David McLaughlin wrote: > Note that it would also need the change here otherwise the browser > doesn't send the

Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

> On Oct. 20, 2017, 5:01 a.m., Bill Farner wrote: > > I don't feel strongly, but `DefaultServlet` can also send an etag header by > > instead setting `"etags", "true"`. Note that it would also need the change here otherwise the browser doesn't send the "If-None-Match" header either. The

Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63176/#review188809 --- I don't feel strongly, but `DefaultServlet` can also send an etag

Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63176/#review188811 --- Master (a935389) is green with this patch.

Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63176/ --- Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review188808 --- Master (a935389) is green with this patch.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188794 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188790 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:52 p.m.) Review request for Aurora, David

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:51 p.m.) Review request for Aurora, David

Re: Review Request 63062: Expose list of neighbors in the instance page

> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > I'd also try and find a task with a longer job key and see what

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/ --- (Updated Oct. 19, 2017, 3:48 p.m.) Review request for Aurora and Jordan Ly.

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 3:25 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Line 329 (original), 319-324 (patched) > > > > > > Feels like a lot of stuff going on here.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188784 --- Ship it! Master (5397013) is green with this patch.

Re: Review Request 63062: Expose list of neighbors in the instance page

> On Oct. 17, 2017, 7:50 p.m., Santhosh Kumar Shanmugham wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > Wonder if we need to paginate this? Think the most

Re: Review Request 63062: Expose list of neighbors in the instance page

> On Oct. 17, 2017, 7:53 p.m., David McLaughlin wrote: > > File Attachment: Screen Shot 2017-10-16 at 6.27.44 PM.png - Screen Shot > > 2017-10-16 at 6.27.44 PM.png > > > > > > I'd also try and find a task with a longer job key and see what

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/ --- (Updated Oct. 19, 2017, 10:37 p.m.) Review request for Aurora, David

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188776 ---

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 1:50 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 188-190 (original), 186-188 (patched) > > > > > > Actually one issue: we no longer

Re: Review Request 63157: Provide a formal way to disable offer declining

> On Oct. 19, 2017, 1:32 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferDecline.java > > Lines 28 (patched) > > > > > > nit: `OfferDecline` seems a bit ambiguious to me at first

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review188767 --- This patch does not apply cleanly against master (b9ede2f), do

Re: Review Request 63169: Add an example of using the UI plugin mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63169/#review188766 --- Ship it! Master (b9ede2f) is green with this patch.

Re: Review Request 63169: Add an example of using the UI plugin mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63169/ --- (Updated Oct. 19, 2017, 9:23 p.m.) Review request for Aurora, Kai Huang and

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188761 --- Ship it! Master (b9ede2f) is green with this patch.

Re: Review Request 63169: Add an example of using the UI plugin mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63169/#review188760 --- Ship it! Probably rename the `plugin/Home.js` as

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/ --- (Updated Oct. 19, 2017, 9:06 p.m.) Review request for Aurora, Kai Huang and

Review Request 63169: Add an example of using the UI plugin mechanism

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63169/ --- Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188758 --- Master (b9ede2f) is red with this patch.

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188756 --- @ReviewBot retry - David McLaughlin On Oct. 19, 2017, 4 a.m.,

Re: Review Request 63135: Refactor Job Page to make it more pluggable

> On Oct. 19, 2017, 8:24 p.m., Kai Huang wrote: > > Fix the gradle build error: > > ``` > > * Exception is: > > org.gradle.api.tasks.TaskExecutionException: Execution failed for task > > ':ui:test'. > > at > >

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188754 ---

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188753 --- Ship it! Master (a9827fe) is green with this patch.

Re: Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188752 --- Ship it! Overall LGTM; small nit on naming but it is

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188749 --- Fix the gradle build error: ``` * Exception is:

Review Request 63157: Provide a formal way to disable offer declining

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/ --- Review request for Aurora and Jordan Ly. Repository: aurora Description

Re: Review Request 63165: Add banner pointing to new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63165/#review188748 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 19,

Review Request 63165: Add banner pointing to new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63165/ --- Review request for Aurora, Santhosh Kumar Shanmugham and Bill Farner.

Re: Review Request 63135: Refactor Job Page to make it more pluggable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188741 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 18,

Re: Review Request 63130: Use LockStore only for backwards compatibility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63130/#review188707 --- Ship it! Ship It! - David McLaughlin On Oct. 18, 2017,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Oct. 18, 2017, 7:38 p.m., Nicolás Donatucci wrote: > > I found an issue a while back after talking to Joshua. > > It is regarding the downgrade script for my db migration. > > It works just fine assuming there is only one entry of ram, cpu and disk > > per taskId on the task_resource

Re: Review Request 63130: Use LockStore only for backwards compatibility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63130/#review188669 --- Ship it! Ship It! - Stephan Erb On Oct. 19, 2017, 1:18

Re: Review Request 63121: Remove static bans for task groups that are no longer pending

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63121/#review188665 --- Ship it! Ship It! - Stephan Erb On Oct. 19, 2017, 2:04