Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189686 --- Ship it! Master (87eb891) is green with this patch.

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

> On Oct. 31, 2017, 2:08 a.m., David McLaughlin wrote: > > ui/src/main/js/components/ErrorBoundary.js > > Lines 28 (patched) > > > > > > Link to the Apache JIRA? And ask them to post the stacktrace below? Could even

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189684 --- +1 to fix the error message in test. Wonder if we could try this?

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189683 --- Ship it! Master (87eb891) is green with this patch.

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/#review189682 --- This looks good. Just to confirm - the behavior we'd see after

Review Request 63436: Enabling ErrorBoundary in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63436/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Kai Huang.

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189675 --- Master (87eb891) is red with this patch.

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189674 --- Ship it! Master (87eb891) is green with this patch.

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63435/#review189669 --- Master (87eb891) is green with this patch.

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63435/#review189665 --- Ship it! Also +1 to shipping as-is, given that inaccurate

Re: Review Request 63435: Remove inaccurate "Initializing sandbox" message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63435/#review189662 --- Ship it! LGTM since the current config lies, but added a wish

Review Request 63435: Remove inaccurate "Initializing sandbox" message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63435/ --- Review request for Aurora, David McLaughlin and Bill Farner. Repository:

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/ --- (Updated Oct. 30, 2017, 10:50 p.m.) Review request for Aurora, David

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

> On Oct. 30, 2017, 7:09 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java > > Lines 45 (patched) > > > > > > Should we just hardcode ALIVE here? Aurora is not

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189648 --- Ship it! LGTM, with the switch to `CacheBuilder` in

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

> On Oct. 27, 2017, 3:03 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java > > Lines 42-43 (patched) > > > > > > How about a `CacheBuilderSpec` to bundle these? > >

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

> On Oct. 30, 2017, 11:09 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/discovery/ServiceInstance.java > > Lines 45 (patched) > > > > > > Should we just hardcode ALIVE here? Aurora is not

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/#review189642 --- Ship it! Master (448e6d4) is green with this patch.

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189627 --- Ship it! Ship It! - Jordan Ly On Oct. 30, 2017, 4:36 p.m.,

Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63406/#review189626 --- The whitespace change looks good to me. I have one general

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

> On Oct. 27, 2017, 10:03 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 321 (patched) > > > > > > `expireAfterWrite` doesn't result in LRU. I think you

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63199/ --- (Updated Oct. 30, 2017, 6:14 p.m.) Review request for Aurora, David

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189621 --- Ship it! LGTM. One minor thing below that confused me when

Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63406/#review189619 --- Ship it! LGTM. It does look a little weird with the space not

Re: Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/#review189610 ---

Review Request 63418: Remove endpoint.thrift, ServiceInstance is never serialized to thrift

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63418/ --- Review request for Aurora, Jordan Ly and Stephan Erb. Repository: aurora

Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63406/#review189601 --- Ship it! Master (3fe5d59) is green with this patch.

Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63406/ --- Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.

Re: Review Request 63401: Add support for generating patch RCs from non-master branches

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63401/#review189585 --- Ship it! Ship It! - Stephan Erb On Oct. 30, 2017, 12:18