Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-09 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62590/#review190663 --- I'm all for the upgrade to Thrift 0.10.0 but we should announce

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread Bill Farner
> On Nov. 9, 2017, 9:23 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 76 (patched) > > > > > > Thinking out loud - the `Optional.of(PARTITIONED)`

Re: Review Request 63436: Enabling ErrorBoundary in Scheduler UI

2017-11-09 Thread Reza Motamedi
I ran `./build-support/jenkins/build.sh` and everything looked fine on my Mac. Can you tell me what the error message was? Regards, ~RM On Tue, Nov 7, 2017 at 4:33 PM, David McLaughlin wrote: > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread David McLaughlin
> On Nov. 9, 2017, 5:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 76 (patched) > > > > > > Thinking out loud - the `Optional.of(PARTITIONED)`

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread Bill Farner
> On Nov. 9, 2017, 9:23 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 76 (patched) > > > > > > Thinking out loud - the `Optional.of(PARTITIONED)`

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review190632 --- Thanks for all the feedback! I'll move forward towards a

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread David McLaughlin
> On Nov. 9, 2017, 5:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java > > Lines 76 (patched) > > > > > > Thinking out loud - the `Optional.of(PARTITIONED)`

Re: Review Request 63685: RFC: Use new scheduler UI as landing page

2017-11-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63685/#review190631 ---

Re: Review Request 63705: Use transition method and fix documentation in Webhooks

2017-11-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63705/#review190629 --- Master (9b9b2ee) is green with this patch.

Re: Review Request 63705: Use transition method and fix documentation in Webhooks

2017-11-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63705/#review190626 --- Ship it! Ship It! - Bill Farner On Nov. 9, 2017, 10:42

Re: Review Request 63705: Use transition method and fix documentation in Webhooks

2017-11-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63705/#review190625 --- Ship it! Ship It! - David McLaughlin On Nov. 9, 2017, 6:42

Review Request 63705: Use transition method and fix documentation in Webhooks

2017-11-09 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63705/ --- Review request for Aurora, David McLaughlin and Bill Farner. Repository:

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread Jordan Ly
> On Nov. 9, 2017, 1:10 a.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Lines 402 (patched) > > > > > > I wondering if having repeated `PARTITIONED` events would

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63536/#review190607 --- Overall approach appears sound. LGTM to proceed to tests.

Re: Review Request 63670: Add a test for storage durability

2017-11-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63670/#review190608 --- Ship it! Master (773d2d6) is green with this patch.

Re: Review Request 63670: Add a test for storage durability

2017-11-09 Thread Bill Farner
> On Nov. 8, 2017, 9:56 a.m., Jordan Ly wrote: > > src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java > > Lines 59 (patched) > > > > > > I might name this NonVolatileStorageTest for

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-11-09 Thread Bill Farner
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > > Stephan Erb wrote: > Bison on MacOs is 10 years

Re: Review Request 63531: Update to Mesos 1.4

2017-11-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63531/#review190599 --- Ship it! Apologies for losing track of this! Now that 0.19.0

Re: Review Request 63536: Give jobs the ability to determine how to handle partitions by integrating with new Mesos Partition-Aware APIs

2017-11-09 Thread Bill Farner
> On Nov. 8, 2017, 5:10 p.m., Jordan Ly wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > > Lines 402 (patched) > > > > > > I wondering if having repeated `PARTITIONED` events would