Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193344 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: >

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193343 --- - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: >

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193342 --- Master (47c6899) is red with this patch.

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193341 --- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m.,

Re: Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193339 --- Ship it! Ship It! - Bill Farner On Dec. 9, 2017, 4:08 p.m.,

Re: Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193338 --- Ship it! Master (47c6899) is green with this patch.

Re: Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193337 --- @ReviewBot retry - Stephan Erb On Dec. 9, 2017, 11:13 p.m.,

Re: Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193336 --- Ship it! Master (47c6899) is green with this patch.

Re: Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/#review193335 --- Master (47c6899) is red with this patch.

Review Request 64482: Fix flaky WebhookTest

2017-12-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64482/ --- Review request for Aurora. Repository: aurora Description --- I opted

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193334 --- - Stephan Erb On Dec. 9, 2017, 5:32 p.m., John Sirois wrote: >

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193332 --- Master (47c6899) is red with this patch.

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
> On Dec. 9, 2017, 6:08 a.m., Stephan Erb wrote: > > Looks good, thanks! > > > > This patch will not apply cleanly after the merge of > > https://reviews.apache.org/r/64382/. The merge conflict is trivial to > > resolve though. I have re-run the end-to-end tests with both patches > > applied

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/ --- (Updated Dec. 9, 2017, 9:32 a.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193330 --- - John Sirois On Dec. 8, 2017, 10:16 p.m., John Sirois wrote: >

Re: Review Request 63750: pants for high-sierra

2017-12-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63750/#review193329 --- Thanks again for the patch! The pants update turned out to be a

Re: Review Request 64290: Update to Thrift 0.10.0

2017-12-09 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193328 --- Ship it! Looks good, thanks! This patch will not apply