Re: Review Request 63157: Provide a formal way to disable offer declining

his into `HostOffers`, eliminating the check-then-act. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188754 -----

Re: Review Request 63157: Provide a formal way to disable offer declining

/63157/diff/2-3/ Testing --- Thanks, Bill Farner

Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration

header by instead setting `"etags", "true"`. - Bill Farner On Oct. 19, 2017, 9:46 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event

the secondary benefit of simplifying testing with mocks by removing the call to `listen()`. - Bill Farner On Oct. 25, 2017, 8:14 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 63157: Provide a formal way to disable offer declining

ated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188776 ------- On Oct. 19, 2017, 1:23 p.m., Bill Farner wrote: > > --- > This is a

Re: Review Request 63121: Remove static bans for task groups that are no longer pending

an LRU cache for static bans instead, which would allow us to mitigate the memory leak while still avoiding redundant work. I suggest we hold on this patch until Jordan's analysis yields results. - Bill Farner On Oct. 18, 2017, 5:04 p.m., Bill Farner wrote

Review Request 63217: Update to shiro 1.2.5

e2e tests now. Thanks, Bill Farner

Re: Review Request 63217: Update to shiro 1.2.5

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63217/#review188950 --- @ReviewBot retry - Bill Farner On Oct. 23, 2017, 7:36 a.m

Review Request 63383: Suppress multiline logging from mesos callbacks

n/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9 src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 51d0371007564bc0af32e256dbae8b57113536c2 Diff: https://reviews.apache.org/r/63383/diff/1/ Testing --- Thanks, Bill Farner

Re: Review Request 63383: Suppress multiline logging from mesos callbacks

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63383/#review189497 ------- On Oct. 27, 2017, 4:46 p.m., Bill Farner wrote: > >

Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189482 --- Ship it! Ship It! - Bill Farner On Oct. 27, 2017, 2:13 p.m

Re: Review Request 63199: Refactor staticallyBannedOffers into a LRU cache

reads as "test that clearing a cache clears the cache". I suggest removing the test case. - Bill Farner On Oct. 20, 2017, 10:53 p.m., Jordan Ly wrote: > > --- > This is an automatically generat

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

> On Jan. 4, 2018, 11:42 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TierManager.java > > Line 105 (original), 106 (patched) > > <https://reviews.apache.org/r/64954/diff/1/?file=1930809#file1930809line106> > > > > This was

Review Request 64954: Refactor scheduling code to split matching and assigning phases

src/test/java/org/apache/aurora/scheduler/updater/UpdateAgentReserverImplTest.java 7f17be0427e3baf12aaa1d176414f7009baeea94 Diff: https://reviews.apache.org/r/64954/diff/1/ Testing --- Thanks, Bill Farner

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

ginal) <https://reviews.apache.org/r/64954/#comment273770> Simplify with mock -> fake. I can't think of a good reason to mock `TierManager`, as it's just a map with a default. - Bill Farner On Jan. 4, 2018, 11:08 a.m., Bill Farner wrote: > >

Re: Review Request 64934: Custom converter to allow the -thermos_executor_resources flag to take an empty string and parse it to an empty list

lly generated e-mail. To reply, visit: > https://reviews.apache.org/r/64934/ > --- > > (Updated Jan. 3, 2018, 3:29 p.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora

Re: Review Request 64934: Custom converter to allow the -thermos_executor_resources flag to take an empty string and parse it to an empty list

a/org/apache/aurora/scheduler/config/CommandLineTest.java ``` - Bill Farner On Jan. 3, 2018, 3:29 p.m., Renan DelValle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 64934: Custom converter to allow the -thermos_executor_resources flag to take an empty string and parse it to an empty list

> On Jan. 4, 2018, 7 p.m., Bill Farner wrote: > > Thanks for the patch! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64934/#rev

Re: Review Request 64825: Update packaging to latest Thrift, Mesos, and virtualenv

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64825/#review194825 --- Ship it! Ship It! - Bill Farner On Dec. 23, 2017, 6:48 a.m

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

ps://reviews.apache.org/r/64954/#review194810 ------- On Jan. 4, 2018, 11:08 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

/s ``` - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64954/#review194810 --- On Jan. 4, 2018, 11:08 a.m., Bi

Re: Review Request 64934: Custom converter to allow the -thermos_executor_resources flag to take an empty string and parse it to an empty list

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64934/#review195048 --- Ship it! Thanks for the patch! - Bill Farner On Jan. 8

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

/diff/2/ Changes: https://reviews.apache.org/r/64954/diff/1-2/ Testing --- Thanks, Bill Farner

Re: Review Request 64954: Refactor scheduling code to split matching and assigning phases

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64954/#review195054 --- On Jan. 9, 2018, 10:32 a.m., Bill Farner wrote: > > --- > This is

Re: Review Request 65076: Added ExclusionStrategy to Gson

JSON form? That will be good insurance against breaking your usage in the future. `MnameTest.java` can serve as a guide for testing an HTTP endpoint. - Bill Farner On Jan. 10, 2018, 10:36 a.m., Juan Manuel Fresia wrote

Re: Review Request 65222: GitHub Pull Request template to discourage folks from making PRs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65222/#review195737 --- Ship it! Great idea, thank you! - Bill Farner On Jan. 18

Re: Review Request 65076: Added ExclusionStrategy to Gson

ta fields such as "__isset_bitfield" and the "optionals" enum. Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting. Reviewed at https://reviews.apache.org/r/65076/ ``` -

Re: Review Request 65303: Improve performance of MemTaskStore queries

n:·gc.time 10 8602.000ms ``` Thanks, Bill Farner

Re: Review Request 65488: Adding gpg key for re...@apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65488/#review196785 --- Ship it! Ship It! - Bill Farner On Feb. 2, 2018, 12:31 p.m

Re: Review Request 64824: Packaging workaround for empty strings parsed as non-empty lists

=CustomSplitter.class)` for `List` parameters. In this case, `CustomSplitter.class` can cargo cult `CommaParameterSplitter.java` from my jcommander PR. - Bill Farner On Dec. 23, 2017, 6:45 a.m., Stephan Erb wrote

Review Request 65303: Improve performance of MemTaskStore queries

000 thrpt NaN --- ``` Thanks, Bill Farner

Re: Review Request 65281: Support PARTITIONED state in SLA calculations

> On Jan. 23, 2018, 10:11 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > > Lines 319 (patched) > > > > > > Shouldn't `RUNNING` -> `PARTITIONED` be

Review Request 65234: Print command line parameters when the scheduler starts

[main, CommandLine] -zk_in_proc: false I0119 03:48:21.867 [main, CommandLine] -zk_session_timeout: (15, secs) I0119 03:48:21.867 [main, CommandLine] --- ``` Thanks, Bill Farner

Re: Review Request 65233: Allow for injection of custom OfferSets, removed OfferOrder and OfferSelector

(patched) <https://reviews.apache.org/r/65233/#comment275206> Odd to see `OfferSetImpl` here. Should be a module, right? - Bill Farner On Jan. 19, 2018, 5:31 p.m., Jordan Ly wrote: > > --- > This is an automatically g

Re: Review Request 65303: Improve performance of MemTaskStore queries

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65303/#review196107 ------- On Jan. 23, 2018, 4:32 p.m., Bill Farner wrote: > >

<    6   7   8   9   10   11