Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

> On April 11, 2016, 6:39 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java, line > > 31 > > <https://reviews.apache.org/r/46064/diff/1/?file=1340123#file1340123line31> > > > > It's probably time for so

Re: Review Request 46064: Removing ResourceVector enum in favor of ResourceType

/ResourceType.java (line 31) <https://reviews.apache.org/r/46064/#comment191744> It's probably time for some constants to justify these constants (or at least admit that they are lies!). - Bill Farner On April 11, 2016, 5:03 p.m., Maxim Khutornenko

Re: Review Request 45779: Small Documentation fixes and nitpicks.

d April 6, 2016, 8:14 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > --- > > Small Documentation fixes and nitpicks. > > > Diffs > - > > docs/additional-reso

Re: Review Request 45935: Remove support for canonical command line arg names.

/OptionInfoTest.java 98d951912627bfbf49e75037bccc914a430a45f4 docs/reference/scheduler-configuration.md f08603ad09f625d2d4b644b3b044c050e964dd66 Diff: https://reviews.apache.org/r/45935/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

. Is that what you want? - Bill Farner On April 7, 2016, 4:07 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45902/ > --

Review Request 45936: Remove support for reading command line argument values from files.

--- Thanks, Bill Farner

Review Request 45935: Remove support for canonical command line arg names.

/scheduler-configuration.md e6c0bb60281d7c39c2aa235445ee4c1ef97464ba src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 80fd223b241b43142fb346d3a0a1314f8a04705e Diff: https://reviews.apache.org/r/45935/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45935: Remove support for canonical command line arg names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45935/#review127839 --- @ReviewBot retry - Bill Farner On April 8, 2016, 11:26 a.m

Re: Review Request 45939: Remove support for positional command line arguments,

/org/apache/aurora/common/args/ArgScannerTest.java 6ac518a5c7b13deb5031bf27897e2b62e4d1fda5 commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562 Diff: https://reviews.apache.org/r/45939/diff/ Testing --- Thanks, Bill Farner

Review Request 45939: Remove support for positional command line arguments,

a4d74ed9d9093939dbaf088ba2a8a632b2a7f1c5 commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java 4ffc7941a856eb63547b9cb4708fb3bfb0eed562 Diff: https://reviews.apache.org/r/45939/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45936: Remove support for reading command line argument values from files.

58890ab1295dca6bb884bd414486a56de0938d6a Diff: https://reviews.apache.org/r/45936/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45992: Make `ServerSet.JSON_CODEC` robust to errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45992/#review128163 --- Ship it! Ship It! - Bill Farner On April 10, 2016, 1:57 p.m

Re: Review Request 45902: Introduce a Curator-based `ServiceGroupMonitor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45902/#review128162 --- Ship it! Ship It! - Bill Farner On April 9, 2016, 7:37 p.m

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

like you would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me. Thanks, Bill Farner

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124421 ------- On March 19, 2016, 1 p.m., Stephan Erb wrote: > > --

Re: Review Request 45076: Improve presentation and organization of the scheduler landing page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45076/#review124424 --- Ship it! Ship It! - Bill Farner On March 19, 2016, 1 p.m

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

899c849be05fe9deb47433 > examples/vagrant/upstart/aurora-scheduler-kerberos.conf > eec5ee3a2f041ae25fa664b80004e27ed8b5e2b0 > examples/vagrant/upstart/aurora-scheduler.conf > 7e10b2c7690087bb150a9033cbd576ab82b1b185 > examples/vagrant/upstart/mesos-master.conf > a2ed953d871a7b28444a188ee0fc152853c5b088 > examples/vagrant/upstart/mesos-slave.conf > d97fa1fcf99580ef3f0997e9c78cb9775b91a818 > > Diff: https://reviews.apache.org/r/44871/diff/ > > > Testing > --- > > I can run `vagrant up`, end-to-end tests pass. > > Reviewers - you can do this as well by applying the patch. You will observe > a long fetch on the first run (much like you would with the current repo if > you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, > `vagrant up` cycles should be relatively fast, about 1m30s for me. > > > Thanks, > > Bill Farner > >

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

would with the current repo if you wiped your local vagrant boxes). However, subsequent `vagrant destroy`, `vagrant up` cycles should be relatively fast, about 1m30s for me. Thanks, Bill Farner

Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.

tps://reviews.apache.org/r/45330/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/#review124582 --- Ship it! Ship It! - Bill Farner On March 21, 2016, 6:21 a.m

Re: Review Request 45042: Add ACL support for announcer

ws.apache.org/r/45042/#comment187655> I assume this string is effectively a blob for this test. If so, can you make it explicit by using a fake value (e.g. `'fake'`)? - Bill Farner On March 22, 2016, 11:51 a.m., Kunal Thakar wrote:

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review124954 --- Ship it! Ship It! - Bill Farner On March 22, 2016, 7:32 p.m

Re: Review Request 45042: Add ACL support for announcer

> On March 22, 2016, 7:23 p.m., Bill Farner wrote: > > docs/security.md, line 289 > > <https://reviews.apache.org/r/45042/diff/4/?file=1310997#file1310997line289> > > > > I'd like to propose several changes to this section, which i've made

Re: Review Request 45172: Tweak update-sources script to also update mesos config.

. use this to restart components that were reconfigured I think there's not much effort in (2), but it's objectively less work than (1). What do you think? - Bill Farner On March 22, 2016, 11:53 a.m., Joshua Cohen

Re: Review Request 44532: Allow overriding hostname before announcing

single underscore (same for `self.__allow_custom_serverset_path`). - Bill Farner On March 16, 2016, 12:43 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44871: Speed up Vagrant provisioning by using a custom base box.

, Bill Farner

Re: Review Request 45042: Add ACL support for announcer

ould be false in a boolean context - Bill Farner On March 18, 2016, 2:57 p.m., Kunal Thakar wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

https://reviews.apache.org/r/45212/#review125027 --- On March 23, 2016, 7:56 a.m., Pierre Cheynier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45212/ > -------

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45212/#review125442 --- Ship it! Ship It! - Bill Farner On March 23, 2016, 7:56 a.m

Re: Review Request 44471: Implementing dbsnapshotting

e-mail. To reply, visit: > https://reviews.apache.org/r/44471/ > --- > > (Updated March 7, 2016, 3:55 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1627 > https://iss

Re: Review Request 44368: Dropping bulkLoad() from Storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44368/#review121963 --- Ship it! Ship It! - Bill Farner On March 3, 2016, 3:28 p.m

Re: Review Request 44347: Install thrift package from the offical debs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44347/#review121993 --- Ship it! Ship It! - Bill Farner On March 3, 2016, 10:56 a.m

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

ing(TIER_CONFIG_FILE.get()) : Resources.toString( TierModule.class.getClassLoader().getResource(TIER_CONFIG_PATH)); ``` - Bill Farner On March 2, 2016, 10:53 a.m., Amol Deshmukh wrote: > > --- > This is

Re: Review Request 44277: Update Thrift binary to point at new repository location for builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44277/#review121752 --- Ship it! Thanks!! - Bill Farner On March 2, 2016, 10:48 a.m

Re: Review Request 44341: Updating documentation Update configuration-reference.md documentation on supporting private docker registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44341/#review121873 --- Ship it! Ship It! - Bill Farner On March 3, 2016, 8:27 a.m

Re: Review Request 44471: Implementing dbsnapshotting

include some indication of performance gains if only to keep an eye out for regression? - Bill Farner On March 7, 2016, 2:22 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 44471: Implementing dbsnapshotting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44471/#review122444 --- Ship it! Ship It! - Bill Farner On March 7, 2016, 3:55 p.m

Re: Review Request 44486: export environment variables into the shellchecker command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122448 --- Ship it! Ship It! - Bill Farner On March 7, 2016, 4:49 p.m

Re: Review Request 43925: AURORA-1616: [part 2] make tier_config mandatory argument when starting up the scheduler.

. Otherwise I will be able to do it this evening. - Bill Farner On March 3, 2016, 10:14 p.m., Amol Deshmukh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 44527: Fixup rpm builder and tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44527/#review122599 --- Ship it! Ship It! - Bill Farner On March 8, 2016, 1:25 p.m

Re: Review Request 44486: Exposing ports to shell health checkers

atically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > --- > > (Updated March 8, 2016, 10:32 a.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. >

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

pache/aurora/scheduler/http/LeaderHealth.java (line 58) <https://reviews.apache.org/r/45511/#comment189635> To be even more human-friendly the response body can also includes the current status. Not a huge deal, but could save somebody a few seconds of clicking. - Bill Farner On April

Review Request 45372: Remove sleep and address flaky health check test.

/aurora/executor/common/test_health_checker.py 19c4f76347e34374c29974c182d1f4c118bcb18d Diff: https://reviews.apache.org/r/45372/diff/ Testing --- None yet Thanks, Bill Farner

Re: Review Request 45718: Remove lock-related constructs from the API.

ca20ba5722c968583f31384326627936a39a1200 Diff: https://reviews.apache.org/r/45718/diff/ Testing --- end-to-end tests are green Thanks, Bill Farner

Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2 Diff: https://reviews.apache.org/r/45725/diff/ Testing --- end-to-end tests are green Thanks, Bill Farner

Re: Review Request 45723: Extract a SingletonService interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45723/#review127017 --- Ship it! Ship It! - Bill Farner On April 4, 2016, 7:12 p.m

Review Request 45718: Remove lock-related constructs from the API.

fb4afcf7a3a395cc6400191183b54b9a68fa1964 src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ca20ba5722c968583f31384326627936a39a1200 Diff: https://reviews.apache.org/r/45718/diff/ Testing --- end-to-end tests are green Thanks, Bill Farner

Re: Review Request 45444: Various minor documentation fixes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45444/#review125947 --- Ship it! Ship It! - Bill Farner On March 29, 2016, 1:10 p.m

Re: Review Request 45436: Fixes to RELEASE-NOTES for new documentation structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45436/#review125917 --- Ship it! Ship It! - Bill Farner On March 29, 2016, 9:46 a.m

Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

of filtering by an empty iterable). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java c76b365f43eb6a3b9b0b63a879b43eb04dcd8fac Diff: https://reviews.apache.org/r/45457/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45372: Skip flaky test test_health_checker_metrics

to fixing it. Diffs (updated) - src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181 Diff: https://reviews.apache.org/r/45372/diff/ Testing --- None yet Thanks, Bill Farner

Re: Review Request 45372: Remove sleep and address flaky health check test.

atically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review125628 ------- On March 27, 2016, 8:41 p.m., Bill Farner wrote: > > --- > This is an automatically gener

Re: Review Request 45521: Remove client-side validation of environment names

> On March 31, 2016, 10 a.m., Joshua Cohen wrote: > > Just to be sure, I saw in the IRC discussion yesterday that Bill suggested > > adding the ability for scheduler-side configuration to replace this. > > > > I'm a strong -1 to this client change without the accompanying scheduler > >

Re: Review Request 45506: Execute shell-based health checks as the task user.

validation. I'm open to ideas here. Thanks, Bill Farner

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

st. src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java (line 104) <https://reviews.apache.org/r/45511/#comment189376> this should be +4 indent, not +8 - Bill Farner On March 30, 2016, 1

Re: Review Request 45506: Execute shell-based health checks as the task user.

e1c12bbd4382c31e576439f6693d82d5661029b9 Diff: https://reviews.apache.org/r/45506/diff/ Testing (updated) --- Altered an end-to-end test case to verify that shell checks are not run as a privileged user. Thanks, Bill Farner

Re: Review Request 45506: Execute shell-based health checks as the task user.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126378 --- On March 31, 2016, 11:01 a.m., Bill Farner wrote: > >

Re: Review Request 45506: Execute shell-based health checks as the task user.

. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126326 --- On March 30, 2016, 4:41 p.m., Bill Farner wrote: >

Re: Review Request 45506: Execute shell-based health checks as the task user.

validation. I'm open to ideas here. Thanks, Bill Farner

Re: Review Request 45506: Execute shell-based health checks as the task user.

rate try/except with timeout when > > subprocess.Popen already supports it. > > > > you can still do a kill if that's your intention in one swoop. > > Bill Farner wrote: > I'm generally a fan of scoping exceptions to catch only where they are > known to be thrown. I

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On March 31, 2016, 11:26 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java, line 54 > > <https://reviews.apache.org/r/45511/diff/4/?file=1320481#file1320481line54> > > > > Is it useful to send a different s

Re: Review Request 45506: Execute shell-based health checks as the task user.

e1c12bbd4382c31e576439f6693d82d5661029b9 Diff: https://reviews.apache.org/r/45506/diff/ Testing --- Altered an end-to-end test case to verify that shell checks are not run as a privileged user. Thanks, Bill Farner

Re: Review Request 45506: Execute shell-based health checks as the task user.

rate try/except with timeout when > > subprocess.Popen already supports it. > > > > you can still do a kill if that's your intention in one swoop. > > Bill Farner wrote: > I'm generally a fan of scoping exceptions to catch only where they are > known to be thrown. I

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125678 --- Ship it! - Bill Farner On March 28, 2016, 8:33 a.m., John

Re: Review Request 45366: Eliminate I* isSet methods for collection fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45366/#review125590 --- Ship it! Ship It! - Bill Farner On March 27, 2016, 3:39 p.m

Re: Review Request 45661: Upgrade build tools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45661/#review126855 --- Ship it! Ship It! - Bill Farner On April 3, 2016, 4:49 p.m

Re: Review Request 45662: Upgrade build tools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45662/#review126856 --- Ship it! Ship It! - Bill Farner On April 3, 2016, 4:49 p.m

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

t ~immediately after commit. - Bill Farner On April 1, 2016, 10:24 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45675: typo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45675/#review126844 --- Ship it! Ship It! - Bill Farner On April 4, 2016, 4:21 a.m

Review Request 45701: Remove TaskQuery from killTasks RPC.

/thrift/SchedulerThriftInterfaceTest.java 85ca86cb333ec023c0cfd8379ac3308b83b6686f Diff: https://reviews.apache.org/r/45701/diff/ Testing --- Build and end-to-end tests are green. Thanks, Bill Farner

Re: Review Request 45569: add auroraversion to build properties

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45569/#review126887 --- Ship it! Ship It! - Bill Farner On March 31, 2016, 6:11 p.m

Review Request 45694: Remove deprecated executor argument '-announcer-enable'

/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028 Diff: https://reviews.apache.org/r/45694/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'

ly, visit: https://reviews.apache.org/r/45694/#review126894 --- On April 4, 2016, 11:16 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'

://reviews.apache.org/r/45694/diff/ Testing --- Thanks, Bill Farner

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

4bb306fe577864c8611b6a34466b2189d903f103 src/test/python/apache/aurora/client/api/test_scheduler_client.py bed800d838d63ef76ec8f48d7c34cc0b165c26a2 Diff: https://reviews.apache.org/r/45701/diff/ Testing --- Build and end-to-end tests are green. Thanks, Bill Farner

Re: Review Request 45701: Remove TaskQuery from killTasks RPC.

n now. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45701/#review126921 --- On April 4, 2016, 12:40 p.m., Bi

Re: Review Request 45042: Add ACL support for announcer

> On March 28, 2016, 4:46 p.m., Bill Farner wrote: > > examples/vagrant/announcer-auth.json, line 11 > > <https://reviews.apache.org/r/45042/diff/5/?file=1317202#file1317202line11> > > > > I now have to backpedal on my advice to store the encrypted crede

Re: Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

equivalent to `SELECT xyz WHERE 1`. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45457/#review125978 ------- On

Re: Review Request 45456: Use correct query to serve /maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45456/#review126016 --- @ReviewBot retry - Bill Farner On March 29, 2016, 3:46 p.m

Re: Review Request 45456: Use correct query to serve /maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45456/#review126025 --- @ReviewBot retry - Bill Farner On March 29, 2016, 3:46 p.m

Re: Review Request 45456: Use correct query to serve /maintenance.

640 passed, 5 skipped, 1 > > warnings, 8 error in 156.66 seconds  > > > > FAILURE > > > > > > 02:56:57 03:42 [complete] > >FAILURE > > > > > > I will refresh this

Re: Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

et) to skip the calls > > you've added precondition checks to. The IsSet calls are now gone, meaning > > the call sites using those have been semantically adjusted. I think this > > only leaves the callers who pass null of which there should be none due to > > the semantic chang

Re: Review Request 45042: Add ACL support for announcer

y (line 48) <https://reviews.apache.org/r/45042/#comment188927> Is this needed? If so, please include a comment explaining why the timeout needs to be at 30. - Bill Farner On March 29, 2016, 5:17 p.m., Kunal Thakar wrote: > > -

Re: Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

et) to skip the calls > > you've added precondition checks to. The IsSet calls are now gone, meaning > > the call sites using those have been semantically adjusted. I think this > > only leaves the callers who pass null of which there should be none due to > > the semantic chang

Re: Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

et) to skip the calls > > you've added precondition checks to. The IsSet calls are now gone, meaning > > the call sites using those have been semantically adjusted. I think this > > only leaves the callers who pass null of which there should be none due to > > the semantic chang

Re: Review Request 45457: Mitigate error-prone queries by disallowing no-op filters.

et) to skip the calls > > you've added precondition checks to. The IsSet calls are now gone, meaning > > the call sites using those have been semantically adjusted. I think this > > only leaves the callers who pass null of which there should be none due to > > the semantic chang

Re: Review Request 46133: Simplify `Credentials`; kill `ZooKeeperClient` dep.

/zookeeper/ZooKeeperClient.java (line 281) <https://reviews.apache.org/r/46133/#comment192153> s/this.// - Bill Farner On April 12, 2016, 7:18 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46459: Schema changes for resource management refactoring

/schema.sql (line 114) <https://reviews.apache.org/r/46459/#comment194022> Generalizing all resources to varchar type is quite unfortunate. Have you considered using a column per resource type to at least avoid the string conversion? - Bill Farner On April 22, 2016, 5:16 p.m., Maxim Khuto

Re: Review Request 46603: Introduce command line option to control the offer filter duration

ava (line 51) <https://reviews.apache.org/r/46603/#comment194020> Does this default value effect the same behavior as before the patch? - Bill Farner On April 23, 2016, 9:35 a.m., Stephan Erb wrote: > > --- > This is a

Re: Review Request 46459: Schema changes for resource management refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130507 --- Ship it! Ship It! - Bill Farner On April 22, 2016, 5:16 p.m

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

comers, as there has not been much traction on the mesos side to support modifying this field on a live cluster. - Bill Farner On April 27, 2016, 3:44 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

er. When using an Iterable or Array, index will be the number of current iteration and value item will be the element retrieved in this iteration. When using a Map (or Collection of Map.Entry objects), index will be the key object and item will be the value object. - Bill Farner On April

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

tiers at all (basically the same point that Joshua raised > above). > > I'll leave it blank and we can address that if the need arises. > > Joshua Cohen wrote: > I'd be ok with just not shipping this change until TaskConfig.tier is > required and users are actually a

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

> On April 28, 2016, 6:20 p.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 46291: Moving db migration into LogStorage

and Joshua should provide pretty good coverage. - Bill Farner On April 18, 2016, 10:29 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46290: adding do-not-demote-health-check-to-role flag to not demote health check user:group to role

o-not-demote-health-check-to-role=false` Can you invert this to 'point positive' instead? e.g. `--root-health-checks` - Bill Farner On April 15, 2016, 4:59 p.m., Dmitriy Shirchenko wrote: > > --- > This is an auto

Re: Review Request 46290: Adding a flag to control whether the executor runs health checks as the job's role's user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46290/#review129414 --- Ship it! Ship It! - Bill Farner On April 18, 2016, 12:02

Re: Review Request 46286: Plumb Curator discovery as an option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46286/#review129394 --- Ship it! Ship It! - Bill Farner On April 16, 2016, 9:10 a.m

Re: Review Request 46286: Plumb Curator discovery as an option.

> On April 18, 2016, 10:58 a.m., Zameer Manji wrote: > > Can you file a ticket to make this default in 0.15? > > Bill Farner wrote: > Is there a reason to even do a release with both implementations? (i.e. > i propose we kill the commons one in a matter of weeks

Re: Review Request 46361: deleting --setuid-health-checks and switching to --nosetuid-health-checks flag to to control whether the executor runs health checks as the job role's user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46361/#review129562 --- Ship it! Ship It! - Bill Farner On April 18, 2016, 7:31 p.m

<    3   4   5   6   7   8   9   10   11   >