Re: Review Request 33537: Document Aurora security features.

/#comment13 A small nit because I know what you mean, but saying HTTP API has the potential to be a little confusing. At this stage it's just a Thrift API that happens to be served over HTTP, right? - David McLaughlin On April 27, 2015, 11:24 p.m., Kevin Sweeney wrote

Re: Review Request 33728: Fix query for active job updates when serving /updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33728/#review82187 --- Ship it! Ship It! - David McLaughlin On April 30, 2015, 6:59

Re: Review Request 33783: Add stats for update state transitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33783/#review82550 --- Ship it! Ship It! - David McLaughlin On May 2, 2015, 6:41 p.m

Review Request 35839: Add exact times to update UI.

://reviews.apache.org/media/uploaded/files/2015/06/24/9ad2f767-297b-4762-9627-628a56644c5f__Screen_Shot_2015-06-24_at_12.04.00_PM.png Thanks, David McLaughlin

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

! Screenshot also LGTM. - David McLaughlin On Aug. 17, 2015, 9:55 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

) https://reviews.apache.org/r/37365/#comment150249 Why bind to this? - David McLaughlin On Aug. 13, 2015, 6:42 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

On Aug. 14, 2015, 3:54 p.m., David McLaughlin wrote: src/main/resources/scheduler/assets/js/controllers.js, line 606 https://reviews.apache.org/r/37365/diff/7/?file=1040096#file1040096line606 You can just do BaseJobController($scope, ...) now? Here and in other invocations

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

/controllers.js (line 521) https://reviews.apache.org/r/37365/#comment150365 You can just do BaseJobController($scope, ...) now? Here and in other invocations. - David McLaughlin On Aug. 14, 2015, 2:44 p.m., Joshua Cohen wrote

Re: Review Request 39057: "aurora config read" command

> On Oct. 11, 2015, 8:43 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/config.py, line 75 > > > > > > I find it a little bit confusing that this command is called `read`. > > Isn't the `bind`

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

field that provides the new type and deprecate the old field as per the deprecation policy? - David McLaughlin On Oct. 8, 2015, 11:35 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 39143: Adding getJobUpdateDiff thrift API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39143/#review102479 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2015, 10:43

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

> On Oct. 9, 2015, 5:12 p.m., Kevin Sweeney wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 351 > > > > > > Please rename this to deprecatedInstanceIds. -1 to this deprecation technique. -

Re: Review Request 39150: Converting to Range in ConfigGroup thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39150/#review102086 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2015, 1:32 a.m

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

reflect the change made in this instance event? Do we care? - David McLaughlin On Aug. 25, 2015, 3:01 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761

Re: Review Request 38010: Stop in-progress instances from pulsing when update has been aborted.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38010/#review97323 --- Ship it! Ship It! - David McLaughlin On Sept. 1, 2015, 5:29 p.m

Re: Review Request 37956: Only process instances if there's been a change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37956/#review97500 --- Ship it! Ship It! - David McLaughlin On Sept. 1, 2015, 4:03 p.m

Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97678 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2015, 7:14 p.m

Re: Review Request 38169: Refactoring resources table to show dedicated.

g/r/38169/#comment154328> Style nit, but declare the function before you call it. - David McLaughlin On Sept. 8, 2015, 9:10 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? Joshua Cohen wrote: I don't think we care, there's not much we can do in that case

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96479 --- Ship it! Ship It! - David McLaughlin On Aug. 25, 2015, 3:01 p.m

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98517 --- Ship it! Ship It! - David McLaughlin On Sept. 10, 2015, 11:56

Re: Review Request 38169: Refactoring resources table to show dedicated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38169/#review98268 --- Ship it! Ship It! - David McLaughlin On Sept. 9, 2015, 7:10 p.m

Re: Review Request 49218: Add support for Mesos Fetcher

- 267) <https://reviews.apache.org/r/49218/#comment204650> Please rename to something like mesosFetcherUris (or just fetcherUris) to document purpose of these uris in this context. - David McLaughlin On June 24, 2016, 11:01 p.m., Renan DelValle

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

223 - 226) <https://reviews.apache.org/r/47550/#comment198640> Can you add tests to show what happens when the instance ranges will be empty? - David McLaughlin On May 18, 2016, 8:55 p.m., Mehrdad Nurolahzade

Re: Review Request 50432: AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review143475 --- Ship it! Ship It! - David McLaughlin On July 26, 2016, 2:36

Re: Review Request 50168: Add rollback functionality to the scheduler

> On July 28, 2016, 8:44 p.m., David McLaughlin wrote: > > For me ROLLED_BACK has a clear meaning - a job that was rolled back due to > > a failed health check in the update process. Overloading like this is going > > to lead to ambiguity and I wouldn't be

Re: Review Request 50168: Add rollback functionality to the scheduler

built into the scheduler in the way you're doing, but maybe we should introduce a new STATE to reflect that it was user-initiated and add it to ALLOWED_TRANSITIONS? I'm not really familiar with this code, so maybe Bill or Maxim could speak to an approach (or dismiss my concerns ;)). - David

Re: Review Request 50617: AURORA-1741 Added missing test cases

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144202 --- Ship it! Ship It! - David McLaughlin On July 29, 2016, 9:21

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

tps://reviews.apache.org/r/49334/#comment205208> Isn't this a fairly easy class to test? - David McLaughlin On June 28, 2016, 8:42 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

> On June 28, 2016, 8:53 p.m., David McLaughlin wrote: > > config/legacy_untested_classes.txt, line 44 > > <https://reviews.apache.org/r/49334/diff/1/?file=1432053#file1432053line44> > > > > Isn't this a fairly easy class to test? > > Mehrdad

Re: Review Request 49334: AURORA-1725 Expose tier configurations as a debug page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49334/#review139888 --- Ship it! Ship It! - David McLaughlin On June 28, 2016, 10

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144825 --- @ReviewBot retry - David McLaughlin On Aug. 4, 2016, 9:10 p.m

Review Request 50819: Use update_job instead of creating new config object when modifying.

/test/python/apache/aurora/client/test_base.py == 339 passed in 24.32 seconds === 14:07:45 00:26 [complete] SUCCESS Thanks, David McLaughlin

Re: Review Request 50685: Support TBinaryProtocol over HTTP

to maintain backwards compatibility by assuming the existing behavior when no content-type is specified in the request. - David McLaughlin On Aug. 2, 2016, 1:29 a.m., Zameer Manji wrote: > > --- > This is an automatically generat

Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137 Diff: https://reviews.apache.org/r/56131/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56131/#review163693 --- @ReviewBot retry - David McLaughlin On Jan. 31, 2017, 6:41 p.m

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 49877682e501d0af76f6e2583b59e93b1bd90137 Diff: https://reviews.apache.org/r/56131/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162698 --- Ship it! Ship It! - David McLaughlin On Jan. 23, 2017, 8:21

Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163562 --- Ship it! Ship It! - David McLaughlin On Jan. 30, 2017, 12

Re: Review Request 55020: AURORA-1835 Expose finer grained offer veto stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55020/#review162965 --- Ship it! Ship It! - David McLaughlin On Dec. 23, 2016, 10

Re: Review Request 55089: AURORA-1826 Expose Thrift server request workload stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55089/#review162968 --- Ship it! Ship It! - David McLaughlin On Dec. 30, 2016, 5:58

Re: Review Request 54883: Move snapshots into a separate log

scale testing suite at Twitter. When that is in place, we'll try this patch out and see what kind of impact there is. - David McLaughlin On Dec. 22, 2016, 9:26 a.m., David McLaughlin wrote: > > --- > This is an automatically ge

Review Request 56797: Move task conversion during reconciliation into the delayed closure.

ing in prod at Twitter. Our post-snapshot stop the world GC hit is reduced dramatically maybe about 80% of the time with this change. Thanks, David McLaughlin

Re: Review Request 55105: AURORA-1870 Add finer grained timings to the Snapshot process

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55105/#review166465 --- Ship it! Ship It! - David McLaughlin On Jan. 28, 2017, 9:15

Re: Review Request 52669: Move the H2 database off heap.

> On Feb. 9, 2017, 5:11 p.m., David McLaughlin wrote: > > Early scale testing of this has been promising in terms of relieving GC > > pressure (although not a silver bullet by any means), but query latency was > > orders of magnitude slower. At certain task volu

Re: Review Request 56575: AURORA-1837 Improve task history pruning

magine that being more than the saving through the MyBatis -> Immutable Thrift translation. - David McLaughlin On Feb. 13, 2017, 5:30 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 56575: AURORA-1837 Improve task history pruning

> On Feb. 13, 2017, 8:24 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 188 > > <https://reviews.apache.org/r/56575/diff/3/?file=1632276#file1632276line188> > > > > If the goal is t

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

s work correctly. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165425 --- On Feb. 14, 2017, 2:01 a

Review Request 56629: Expose task pruning endpoint in aurora_admin

: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

of task pruning via aurora_admin in Vagrant. Works as expected. Also: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165434 ------- On Feb. 14, 2017, 4:12 a.m., David McLaughlin wrote: > > --

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

combinations of task pruning via aurora_admin in Vagrant. Works as expected. Also: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

combinations of task pruning via aurora_admin in Vagrant. Works as expected. Also: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165456 ------- On Feb. 14, 2017, 5:41 a.m., David McLaughlin wrote: > > --- >

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

. Works as expected. Also: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

> On Feb. 14, 2017, 1:54 a.m., Reza Motamedi wrote: > > LGTM! > > > > But, should we test this in the test cluster? At least to check the effect > > of _limit_? > > David McLaughlin wrote: > I did test this in Vagrant. All the options work correctly

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

/test_scheduler_client.py fab97986dcecf7761e161f4074d5108a8c362e6e Diff: https://reviews.apache.org/r/56629/diff/ Testing --- Ran various combinations of task pruning via aurora_admin in Vagrant. Works as expected. Also: ./pants test src/test/python/apache/aurora/admin:: Thanks, David McLaughlin

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

4d5108a8c362e6e > > Diff: https://reviews.apache.org/r/56629/diff/ > > > Testing > --- > > Ran various combinations of task pruning via aurora_admin in Vagrant. Works > as expected. > > Also: > > ./pants test src/test/python/apache/aurora/admin:: > > > Thanks, > > David McLaughlin > >

Re: Review Request 52669: Move the H2 database off heap.

session timeouts and scheduler failovers. I'd propose updating this patch so off-heap can be turned on and off with a flag, as the hit to read performance may be unacceptable for read heavy workloads with smaller clusters. - David McLaughlin On Oct. 11, 2016, 6:17 p.m., Stephan Erb wrote

Re: Review Request 56723: Add best effort pulse timestamp recovery.

/JobUpdateControllerImpl.java (line 286) <https://reviews.apache.org/r/56723/#comment237650> s/mostly/most/ - David McLaughlin On Feb. 16, 2017, 1:53 a.m., Zameer Manji wrote: > > --- > This is an automatically g

Re: Review Request 56575: AURORA-1837 Improve task history pruning

> On Feb. 15, 2017, 5:40 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > lines 150-151 > > <https://reviews.apache.org/r/56575/diff/5/?file=1634553#file1634553line150> > > > > Can

Re: Review Request 56575: AURORA-1837 Improve task history pruning

/TaskHistoryPruner.java (lines 134 - 135) <https://reviews.apache.org/r/56575/#comment237580> Can you explain the reasoning behind doing this in a loop per job rather than a single loop that queries all tasks? - David McLaughlin On Feb. 15, 2017, 5:07 p.m., Mehrdad Nurolahzade

Re: Review Request 56723: Add best effort pulse timestamp recovery.

ide a healthy "pulsed" time interval. - David McLaughlin On Feb. 15, 2017, 10:09 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 57061: Enable Mesos HTTP API.

implementations around for a while. We could also try and run this patch in our scale test cluster. - David McLaughlin On Feb. 28, 2017, 12:43 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 57061: Enable Mesos HTTP API.

(line 48) <https://reviews.apache.org/r/57061/#comment239112> Missing Javadoc. src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java (lines 114 - 115) <https://reviews.apache.org/r/57061/#comment239111> Can we avoid repeating this in each method? - David

Re: Review Request 57061: Enable Mesos HTTP API.

> On Feb. 28, 2017, 1:44 a.m., David McLaughlin wrote: > > Overall approach LGTM, although I agree with Stephan that I'd like to see a > > bit more separation between the drivers. > > > > A more thorough review to follow, but are you able to run this in > >

Re: Review Request 57061: Enable Mesos HTTP API.

. - David McLaughlin On March 1, 2017, 8:20 a.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57061: Enable Mesos HTTP API.

> On Feb. 28, 2017, 1:44 a.m., David McLaughlin wrote: > > Overall approach LGTM, although I agree with Stephan that I'd like to see a > > bit more separation between the drivers. > > > > A more thorough review to follow, but are you able to run this in > >

Re: Review Request 57061: Enable Mesos HTTP API.

> On Feb. 28, 2017, 5:52 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java, > > lines 114-115 > > <https://reviews.apache.org/r/57061/diff/5/?file=1650845#file1650845line114> > > > >

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 9, 2016, 4:41 p.m., David McLaughlin wrote: > > LGTM overall. > > > > It is a *little* concerning that with this change, since the default value > > for min_consecutive_successes is 1 and we've removed the > > sleep(initial_interval_secs) before

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

gt; I feel like we need more coverage with regards to these input values. At the minimum, we should have coverage for min_consecutive_successes set to 1, since it's the default value that will affect existing users and it will help us track what exactly is changing. - David McLaughlin On Nov. 9,

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

in test_task_runner.py, it looks like unfortunately the provider class lacks any sort of coverage. A minimal test here could be to just test the path through Provider.from_assigned_task that you've altered here? - David McLaughlin On Oct. 12, 2016, 7:42 p.m., Justin Pinkul wrote

Review Request 52884: Document how to create a custom CLI build

079c4712885a615716c3ecbd9a48581fc1bcee14 Diff: https://reviews.apache.org/r/52884/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 53831: Filter out resources that Aurora does not yet support to avoid crashing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53831/#review156168 --- Ship it! Ship It! - David McLaughlin On Nov. 17, 2016, 12

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152156 --- Ship it! Ship It! - David McLaughlin On Oct. 11, 2016, 3:11

Re: Review Request 51893: Allow cookie based authentication

sed by a Shiro plugin which > extracts authentication information and applies authorization rules. The > frontend and the scheduler are on the same machine and only the frontend can > talk to the backend, hence we are guaranteed that the headers cannot be > spoofed. > > Da

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

ub.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/common/health_checker.py#L222 - David McLaughlin On Oct. 12, 2016, 1:18 a.m., Kai Huang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 51893: Allow cookie based authentication

sed by a Shiro plugin which > extracts authentication information and applies authorization rules. The > frontend and the scheduler are on the same machine and only the frontend can > talk to the backend, hence we are guaranteed that the headers cannot be > spoofed. > > Da

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

providers. Makes sense now! - David McLaughlin On Oct. 13, 2016, 10:12 p.m., Justin Pinkul wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52804: Adding an error message when the mesos_containerizer_path is not set correctly.

(lines 103 - 113) <https://reviews.apache.org/r/52804/#comment221661> I may be missing something, but doesn't the test below only test this test implementation (and not the change you made to the DefaultThermosRunnerProvider)? - David McLaughlin On Oct. 13, 2016, 10:12 p.m.,

Re: Review Request 52669: Move the H2 database off heap.

at Twitter and report back findings. - David McLaughlin On Oct. 10, 2016, 3:14 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51893: Allow cookie based authentication

sed by a Shiro plugin which > extracts authentication information and applies authorization rules. The > frontend and the scheduler are on the same machine and only the frontend can > talk to the backend, hence we are guaranteed that the headers cannot be > spoofed. > > Da

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

/MetricCalculator.java (lines 200 - 202) <https://reviews.apache.org/r/54439/#comment229127> Why do we only sample active updates, seems like we could miss data points? Especially for small updates. - David McLaughlin On Dec. 7, 2016, 5:50 p.m., Joshua Cohen

Re: Review Request 54459: Add message parameter to killTasks

/aurora/e2e/test_end_to_end.sh) for this? src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java (line 56) <https://reviews.apache.org/r/54459/#comment229123> Nit: add a period after getRemoteUserName(). - David McLaughlin On Dec. 7, 2016, 2:20 a.m., Cody Gibb

Re: Review Request 54255: Update to Mesos 1.1.0.

on Mesos 1.0.0, even if it's just manual verification? I'm not sure the implication of using those constants - were they also in Mesos 1.0.0? - David McLaughlin On Dec. 7, 2016, 11:04 a.m., Stephan Erb wrote

Re: Review Request 54459: Add message parameter to killTasks

> On Dec. 7, 2016, 6:09 p.m., David McLaughlin wrote: > > LGTM! > > > > Can you add an end to end test > > (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this? > > Cody Gibb wrote: > I noticed several of the existing e2e tests simply r

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

/storage/log/SnapshotStoreImplIT.java cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc Diff: https://reviews.apache.org/r/54774/diff/ Testing --- ./gradlew test I'll apply this to one of our test clusters before merging to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

/SnapshotStoreImplIT.java cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc Diff: https://reviews.apache.org/r/54774/diff/ Testing --- ./gradlew test I'll apply this to one of our test clusters before merging to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

before merging to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

r/54774/#review159292 --- On Dec. 15, 2016, 6:01 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

ddition to snapshots. Prior to that > > we fetched everything from H2 and dumped it to the snapshot as individual > > thrift entries. Good to know, thanks. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54774/#review159305 --

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

and backups and failover. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

clusters before merging to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

/scheduler/storage/log/SnapshotStoreImplIT.java cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc Diff: https://reviews.apache.org/r/54774/diff/ Testing --- ./gradlew test I'll apply this to one of our test clusters before merging to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

` annotation is on the wrong method now. Derp. Fixed. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54774/#review159347 --- On Dec

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

to master too. Thanks, David McLaughlin

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54774/#review159359 --- @ReviewBot retry - David McLaughlin On Dec. 15, 2016, 7:24 p.m

Re: Review Request 54774: Avoid double writing job updates to the Scheduler Snapshot

reply, visit: https://reviews.apache.org/r/54774/#review159433 ------- On Dec. 15, 2016, 8:04 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54774/

  1   2   3   4   5   6   >