On March 27, 2015, 6:09 p.m., Joshua Cohen wrote:
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java,
line 42
https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line42
It feels like most of this stuff can be tested
subsequent
end to end test runs will fail?
Or alternately just set up a separate service for scheduler w/ kerberos and
stop the normal scheduler, start the kerb one, run tests, then stop/start in
reverse?
- Joshua Cohen
On March 27, 2015, 1:23 a.m., Kevin Sweeney wrote
On March 27, 2015, 11:44 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetters.java,
lines 25-26
https://reviews.apache.org/r/32329/diff/4/?file=908521#file908521line25
I don't think I've ever run into the scenario where a method had
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32554/#review77965
---
Ship it!
Ship It!
- Joshua Cohen
On March 26, 2015, 10:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33411/#review81174
---
Ship it!
Ship It!
- Joshua Cohen
On April 21, 2015, 11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33317/#review80803
---
Ship it!
Ship It!
- Joshua Cohen
On April 20, 2015, 7:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33962/#review82947
---
Ship it!
Ship It!
- Joshua Cohen
On May 8, 2015, 12:16 a.m
I'm totally unclear on our guidelines for javadoc. Usually on interface
methods we'd require javadoc, does that not hold here for some reason since
it's a MyBatis mapper?
- Joshua Cohen
On May 5, 2015, 6:21 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33991/#review83038
---
Ship it!
Ship It!
- Joshua Cohen
On May 8, 2015, 6:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33997/#review83118
---
Ship it!
Ship It!
- Joshua Cohen
On May 9, 2015, 12:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34307/#review84212
---
Ship it!
Ship It!
- Joshua Cohen
On May 16, 2015, 1:20 a.m
:
# block begins here
- Joshua Cohen
On April 11, 2015, 9:52 p.m., Stephan Erb wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32889
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34570/#review86879
---
@ReviewBot retry
- Joshua Cohen
On May 21, 2015, 11:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34570/#review86878
---
Ship it!
Presumably you'll need to rebase.
- Joshua Cohen
/apache/aurora/scheduler/http/api/security/ApiSecurityIT.java
https://reviews.apache.org/r/34566/#comment138690
Same here and below.
- Joshua Cohen
On June 3, 2015, 10:08 p.m., Maxim Khutornenko wrote:
---
This is an automatically
On June 4, 2015, 4:36 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java,
lines 78-80
https://reviews.apache.org/r/34566/diff/2/?file=977711#file977711line78
Why don't need this anymore?
Er, ignore this, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35839/#review89236
---
Ship it!
Ship It!
- Joshua Cohen
On June 24, 2015, 7:05 p.m
/UnsecureAuthModule.java (line 34)
https://reviews.apache.org/r/35535/#comment140545
Should this move to UnsecureSessionContext?
- Joshua Cohen
On June 16, 2015, 9:54 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply
/test_thermos_observer_entry_point.py (lines
27 - 30)
https://reviews.apache.org/r/35527/#comment140542
There's a way to set this up so that only these expected properties are
accessed, right? Is it by doing `Mock(spec_set=['root','mesos_root',...])`?
In any event, we should probably do that?
- Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35527/#review88154
---
Ship it!
Ship It!
- Joshua Cohen
On June 16, 2015, 10:18 p.m
https://reviews.apache.org/r/34440/#comment136454
Add @Positive here as well.
- Joshua Cohen
On May 22, 2015, 8:47 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186
https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186
Add @Positive here as well.
Maxim Khutornenko wrote:
Well, this can
and say database admin TCP server
- Joshua Cohen
On May 21, 2015, 9:15 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34566
-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
of this
(just convert your email to dev@ to markdown? ;)).
src/main/python/apache/thermos/bin/BUILD (line 36)
https://reviews.apache.org/r/36972/#comment148126
Should this read from .auroraversion?
- Joshua Cohen
On July 31, 2015, 3:37 a.m., Kevin Sweeney wrote
On July 31, 2015, 10:57 p.m., Joshua Cohen wrote:
I'm -1 to shipping without something under docs/ explaining this
organizational structure.
Bill Farner wrote:
maybe a README.md under `src/main/python/apache` instead?
Kevin Sweeney wrote:
I've added a new file docs/build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972/#review93829
---
Ship it!
Ship It!
- Joshua Cohen
On July 31, 2015, 11:22 p.m
this organizational
structure.
- Joshua Cohen
On July 31, 2015, 10:49 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36972
of the progress indicators in action.
File Attachments
Progress indicators in action
https://reviews.apache.org/media/uploaded/files/2015/08/05/b4e2fab2-9a3e-4910-b02f-e31de2631e87__update-page.mov
Thanks,
Joshua Cohen
-e31de2631e87__update-page.mov
Thanks,
Joshua Cohen
.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37137/#review94293
---
On Aug. 5, 2015, 8:28 p.m., Joshua Cohen wrote
://reviews.apache.org/r/37137/#review94303
---
On Aug. 5, 2015, 8:28 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
think we should remove the -webkit prefix and
just stick to the standard css3 names.
Joshua Cohen wrote:
-moz is not necessary. Firefox has supported prefix-less keyframes since
version 16 (current stable is 39) which was released in 2012. Current Safari
does not work without
8850e9382f4192873fe2d785e75a7d73403696d6
Diff: https://reviews.apache.org/r/37092/diff/
Testing
---
Verified that I'm able to reload the UI in vagrant and have it pick up changes
without restarting/rebuilding the scheduler.
Thanks,
Joshua Cohen
/vagrant/aurorabuild.sh 8850e9382f4192873fe2d785e75a7d73403696d6
Diff: https://reviews.apache.org/r/37092/diff/
Testing
---
Verified that I'm able to reload the UI in vagrant and have it pick up changes
without restarting/rebuilding the scheduler.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37206/#review94557
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 7, 2015, 4:12 a.m
://reviews.apache.org/media/uploaded/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
---
On Aug. 14, 2015, 2:44 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37365
.
Joshua Cohen wrote:
This is pretty standard mechanism for inheritance in JS. We could remove
the .call invocation, but then if something changed in the future that *did*
bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it
as is.
David McLaughlin wrote:
So
/files/2015/08/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
.
Joshua Cohen wrote:
This is pretty standard mechanism for inheritance in JS. We could remove
the .call invocation, but then if something changed in the future that *did*
bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it
as is.
David McLaughlin wrote:
So
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37153/#review95434
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 13, 2015, 9:46 p.m
.
Joshua Cohen wrote:
This is pretty standard mechanism for inheritance in JS. We could remove
the .call invocation, but then if something changed in the future that *did*
bind to `this` in the parent it wouldn't work properly. I'd prefer to keep it
as is.
David McLaughlin wrote:
So
/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
/11/2ab72f9d-9e60-4b86-b971-b6aba5465def__Screen_Shot_2015-08-11_at_4.53.07_PM.png
Thanks,
Joshua Cohen
., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37365/
---
(Updated Aug. 12, 2015, 4:40 p.m.)
Review
'aurora'.
Build requires at least Java 1.8; but 1.7 was found.
Build succeeds w/ JDK8.
Thanks,
Joshua Cohen
. To reply, visit:
https://reviews.apache.org/r/36703/
---
(Updated July 22, 2015, 7:30 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
---
Remove unnecessary use of Guava
.
Thanks,
Joshua Cohen
-25_at_9.59.50_AM.png
Thanks,
Joshua Cohen
> On Oct. 20, 2015, 4:49 p.m., Joshua Cohen wrote:
> > Not a blocker, but do you think the arrows in the output are necessary?
> > They feel like extra noise to me. Maybe replace them with tabs instead?
>
> Maxim Khutornenko wrote:
> Certainly not married to th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review106421
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 13, 2015, 3:32 p.m
's git shows the [same
thing](https://git-wip-us.apache.org/repos/asf?p=aurora.git;a=blob;f=pants.ini;h=22f6c59dd93c1a4a2ca78c216e1fd3f3f6c8b752;hb=HEAD).
- Joshua Cohen
On Nov. 11, 2015, 8:30 p.m., John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106422
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 11, 2015, 8:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40220/#review106419
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 12, 2015, 8:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106448
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 13, 2015, 4:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40334/#review106678
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 15, 2015, 11:36 p.m
ws.apache.org/r/40310/#comment165418>
Why kill this? It seems like the intention was to ensure that set quota is
called with the correct types, but the assert above still passes if we were to
do `assert_called_with(role, 24, 4001.0, 6001.0)`, thus the explicit type
checks were necessary?
- J
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106694
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 16, 2015, 5:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40324/#review106693
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 16, 2015, 5:42 p.m
> On Oct. 30, 2015, 2:31 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, lines 305-306
> > <https://reviews.apache.org/r/39797/diff/1/?file=1112716#file1112716line305>
> >
> > It seems like this friendly err
in the testing done
section, would it be possible to collapse the output into instance ranges? So
instead of [100, 101, 102, ... 119], we just get [100-119]?
- Joshua Cohen
On Oct. 16, 2015, 12:25 a.m., Maxim Khutornenko wrote
---
Add a note about updating the aurora-packagine repo when changing the gradle
version.
Diffs
-
buildSrc/gradle.properties 9e3f26fb466aecbed30d0d000d07c3873d71b117
Diff: https://reviews.apache.org/r/39114/diff/
Testing
---
Thanks,
Joshua Cohen
> On Oct. 8, 2015, 3:56 a.m., Joshua Cohen wrote:
> > Mind adding a note to build.gradle in the aurora repo to update these as
> > well whenever updating the gradle version (maybe point to this review as an
> > example)?
>
> Bill Farner wrote:
> The source
equest` and again right after. I'd remove the log from
`_job_update_request`?
- Joshua Cohen
On Oct. 19, 2015, 5:23 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39095/#review101791
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 7, 2015, 4:50 p.m
15, 11:35 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39150/
> ---
>
> (Updated Oct. 8, 2015, 11:35 p.m.)
>
and this got buried.
Looks fine to me!
- Joshua Cohen
On July 5, 2015, 7:38 p.m., Stephan Erb wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36064
active tasks were paginated but 2 completed
tasks (for the same job) did not.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37847/#review96725
---
Ship it!
Ship It!
- Joshua Cohen
On Aug. 27, 2015, 6:01 p.m
with ~3000 instances, confirmed that
memory usage did not grow beyond ~200MB.
Thanks,
Joshua Cohen
files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
Thanks,
Joshua Cohen
r an aborted update. Also see screenshot for
tooltip changes.
File Attachments
Screen Shot 2015-09-01 at 12.08.51 PM.png
https://reviews.apache.org/media/uploaded/files/2015/09/01/340c71be-564f-4024-8ee3-bab960edfad0__Screen_Shot_2015-09-01_at_12.08.51_PM.png
Thanks,
Joshua Cohen
54bcdedf49ed852ab6eb0475250b81cb1ebc3b28
Diff: https://reviews.apache.org/r/38018/diff/
Testing
---
Verified link goes directly to the update page.
Thanks,
Joshua Cohen
/scheduler/assets/js/app.js
310aa35c2ede799de693b86012e943fadfdf03f5
src/main/resources/scheduler/assets/js/controllers.js
98920196db34f2eb4dcad93429274517e7383efe
Diff: https://reviews.apache.org/r/38106/diff/
Testing
---
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38081/#review97675
---
Ship it!
Ship It!
- Joshua Cohen
On Sept. 3, 2015, 12:46 a.m
/#review96394
---
On Aug. 25, 2015, 3:01 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37761
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote:
What if they click on an old update and the instance page doesn't reflect
the change made in this instance event? Do we care?
Joshua Cohen wrote:
I don't think we care, there's not much we can do in that case
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote:
What if they click on an old update and the instance page doesn't reflect
the change made in this instance event? Do we care?
Joshua Cohen wrote:
I don't think we care, there's not much we can do in that case
he controller instead of the view. Add something like:
$scope.resourcesClass = ...;
Then in the view just do:
I don't *think* you need/want to use ng-class, since the value isn't going
to change after render.
- Joshua Cohen
On Sept. 8, 2015, 3:14 a.m., Ma
/files/2015/09/10/85b7311d-2ad9-4769-8b49-9e1410d817fc__Screen_Shot_2015-09-10_at_6.50.53_PM.png
Thanks,
Joshua Cohen
hrough `bind` and reduce this
boilerplate a bit?
- Joshua Cohen
On Sept. 13, 2015, 6:06 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
-10_at_6.48.08_PM.png
Environment Page
https://reviews.apache.org/media/uploaded/files/2015/09/10/85b7311d-2ad9-4769-8b49-9e1410d817fc__Screen_Shot_2015-09-10_at_6.50.53_PM.png
Thanks,
Joshua Cohen
eople outside of
> > Twitter use the job_viz_url for.
> >
> > Besides that: Awesome improvement!
>
> Joshua Cohen wrote:
> Do you think naming it based on the Scheduler command line arg would be
> better? I.e. just call it "Stats"?
>
/
Testing
---
Thanks,
Joshua Cohen
> On Sept. 11, 2015, 6:59 p.m., Joshua Cohen wrote:
> > File Attachment: resources.png - resources.png
> > <https://reviews.apache.org/r/38313/#fcomment80>
> >
> > Couple of suggestions on this format:
> >
> > 1) what do you think about
erwise looks good to me!
- Joshua Cohen
On Sept. 11, 2015, 6:55 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38313/#review98680
---
Ship it!
Ship It!
- Joshua Cohen
On Sept. 11, 2015, 6:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38270/#review98577
-------
On Sept. 11, 2015, 2:23 a.m., Joshua Cohen wrote:
>
> --
eople outside of
> > Twitter use the job_viz_url for.
> >
> > Besides that: Awesome improvement!
>
> Joshua Cohen wrote:
> Do you think naming it based on the Scheduler command line arg would be
> better? I.e. just call it "Stats"?
>
-4507-a217-6bd20953b1b8__Screen_Shot_2015-09-10_at_6.48.08_PM.png
Environment Page
https://reviews.apache.org/media/uploaded/files/2015/09/10/85b7311d-2ad9-4769-8b49-9e1410d817fc__Screen_Shot_2015-09-10_at_6.50.53_PM.png
Thanks,
Joshua Cohen
is not displayed if `statsUrlPrefix` is not set on
`response.serverInfo`, is displayed if it is.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38277/#review98635
---
Ship it!
Ship It!
- Joshua Cohen
On Sept. 10, 2015, 11:19 p.m
/2015/09/30/71674c02-689b-4818-adaf-7fe005a25c52__Screen_Shot_2015-09-30_at_2.33.27_PM.png
After
https://reviews.apache.org/media/uploaded/files/2015/09/30/552cd5f9-2a8c-4a8c-9fd4-50afcafe187a__Screen_Shot_2015-09-30_at_2.45.28_PM.png
Thanks,
Joshua Cohen
dding a dependency on subprocess32. Can you
clarify why it's needed? subprocess.check_call is already available in
python2.7 stdlib:
https://docs.python.org/2/library/subprocess.html#subprocess.check_call.
- Joshua Cohen
On Dec. 10, 2015, 9:16 p.m., Dmitri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41453/#review110738
---
Ship it!
Ship It!
- Joshua Cohen
On Dec. 16, 2015, 7:53 p.m
> On Dec. 16, 2015, 4:22 p.m., Joshua Cohen wrote:
> > I'd like to propose an alternate configuration schema for consideration. I
> > feel like the version presented in this review is redundant and tries to
> > shoehorn the "endpoint" concept onto a shell healt
e.org/r/41428/#comment170769>
Drop this comment as well.
- Joshua Cohen
On Dec. 16, 2015, 7:08 p.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To
1 - 100 of 591 matches
Mail list logo