Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter

. - Zameer Manji On Jan. 23, 2017, 9 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a Diff: https://reviews.apache.org/r/54288/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162721 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2017, 12:21

Re: Review Request 55902: Capture health check output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review163020 --- Ship it! Ship It! - Zameer Manji On Jan. 25, 2017, 10:47

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163550 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 55982: Move deprecated resource validations so they happen after the thrift backfill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55982/#review163551 --- This is on master now. - Zameer Manji On Jan. 30, 2017, 10:23

Re: Review Request 56062: Fix flapping TestRunnerKillProcessGroup test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56062/#review163564 --- Ship it! Ship It! - Zameer Manji On Jan. 29, 2017, 9:53 a.m

Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.

/mesos/CommandLineDriverSettingsModule.java (line 155) <https://reviews.apache.org/r/56131/#comment235171> Can you link to the commit that did this or something? It would make it much easier to determine later if we can remove it. - Zameer Manji On Jan. 31, 2017, 10:41 a.m.,

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review163922 --- @ReviewBot retry - Zameer Manji On Feb. 1, 2017, 4:57 p.m

Review Request 56265: Move Aurora to v1 Protobufs.

75bac6f238a619c41903007babd4a6e20aaeaa1e src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56265: Move Aurora to v1 Protobufs.

/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56265: Move Aurora to v1 Protobufs.

/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 54459: Add message parameter to killTasks

and I'll land this. - Zameer Manji On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review164384 --- This change is now on master. - Zameer Manji On Feb. 6, 2017

Re: Review Request 56265: Move Aurora to v1 Protobufs.

86861e1bd4ca5b920808abf419bc13f83961b836 Diff: https://reviews.apache.org/r/56265/diff/ Testing --- Thanks, Zameer Manji

Review Request 56361: Add additional tests for the conversion of TaskStatus.

://reviews.apache.org/r/56361/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56361: Add additional tests for the conversion of TaskStatus.

/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40 Diff: https://reviews.apache.org/r/56361/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56404: Update PMD to 5.5.3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56404/#review164568 --- Ship it! Ship It! - Zameer Manji On Feb. 7, 2017, 1:32 p.m

Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields

deprecated fields. - Zameer Manji On Feb. 7, 2017, 9:02 a.m., Nicolás Donatucci wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 52669: Move the H2 database off heap.

generated e-mail. To reply, visit: > https://reviews.apache.org/r/52669/ > --- > > (Updated Oct. 11, 2016, 11:17 a.m.) > > > Review request for Aurora, David McLaughlin, John Sirois, and Zameer Manji. > > > Repositor

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165385 --- Ship it! LGTM, thanks for your contribution. - Zameer Manji

Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56523/#review165387 --- This is now on master. - Zameer Manji On Feb. 13, 2017, 12:09

Re: Review Request 56577: Add basic test scripts for RPM and DEB packages

apparently not. Thanks for doing this. - Zameer Manji On Feb. 12, 2017, 5:12 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154573 --- On Oct. 31, 2016, 6:48 p.m., Zameer Manji wrote: > > -

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

; performed. Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review154365 --- On Oct. 31, 2016, 6:48 p.m., Zameer

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

1fe09090bfa3eeb0f6897e8c895782fb1ff949a1 Diff: https://reviews.apache.org/r/5/diff/ Testing --- sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

tps://reviews.apache.org/r/56629/#comment237421> Could you refer to AURORA-1892? - Zameer Manji On Feb. 13, 2017, 9:41 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 56575: AURORA-1837 Improve task history pruning

> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote: > > Looking at it as is, I'm not sure if there is much value to be gained from > > pushing this down to `TaskStore`. > > Do you see any value in pursuing this idea any further? Or shall I restore > > it to previous state? I think there

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

5> > > > > Can you fix spacing so the columns line up? ;) Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165512 -------

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

ed e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165452 ------- On Feb. 13, 2017, 6:26 p.m., Zameer Manji wrote: > > --- > This is an

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

y generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165597 ------- On Feb. 13, 2017, 6:26 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

://reviews.apache.org/r/5/diff/ Testing --- sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Review Request 56723: Add best effort pulse timestamp recovery.

llerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56723/#review165775 ------- On Feb. 15, 2017, 2:09 p.m., Zameer Manji wrote: > >

Re: Review Request 56723: Add best effort pulse timestamp recovery.

in/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

che/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

che/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 Diff: https://reviews.apache.org/r/56723/diff/ Testing --- Thanks, Zameer Manji

Re: Review Request 56723: Add best effort pulse timestamp recovery.

ps://reviews.apache.org/r/56723/#review165801 ------- On Feb. 15, 2017, 6:24 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 56797: Move task conversion during reconciliation into the delayed closure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56797/#review166007 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2017, 4:13 p.m

Re: Review Request 56935: Fix for unnecessary object serializations

> > (Updated Feb. 22, 2017, 9:23 a.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Repository: aurora > > > Description > --- > > This patch provides a fix for some unnecessary object serilization

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

reach the timeout we can reserve it. src/test/java/org/apache/aurora/scheduler/TierManagerTest.java (line 27) <https://reviews.apache.org/r/56690/#comment238816> Can you revert the import glob here? - Zameer Manji On Feb

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

here. src/main/java/org/apache/aurora/scheduler/offers/OfferReconciler.java (line 86) <https://reviews.apache.org/r/56691/#comment238819> We prefer `ImmutableList.of()` for lists of one item. - Zameer Manji On Feb. 22, 20

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56691/ > --- > > (Updated Feb. 24, 2017, 3:02 p.m.) > >

Review Request 57061: Enable Mesos HTTP API.

57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57074: Fix scheduler_framework_disconnects stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57074/#review166910 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2017, 11:05

Re: Review Request 57074: Fix scheduler_framework_disconnects stats

. - Zameer Manji On Feb. 26, 2017, 11:05 a.m., Ilya Pronin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57074/ > --

Re: Review Request 57061: Enable Mesos HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review166919 --- @ReviewBot retry - Zameer Manji On Feb. 24, 2017, 7:16 p.m

Re: Review Request 57061: Enable Mesos HTTP API.

.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

e.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

implementation so I feel that the logging should be here, but I'm unsure on how to deduplicate it cleanly. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Re: Review Request 57061: Enable Mesos HTTP API.

Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

eply, visit: https://reviews.apache.org/r/57061/#review166983 ------- On Feb. 27, 2017, 4:43 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57061/ > -

Re: Review Request 57061: Enable Mesos HTTP API.

> production and give some feedback on performance? It would be good to know > > if we can get rid of the old native driver or we're going to have to carry > > the different implementations around for a while. We could also try and run > > this patch in our scale test

Re: Review Request 57061: Enable Mesos HTTP API.

to have all of them initialized to 0 instead of having them missing. - Zameer ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review167006 ---

Re: Review Request 57061: Enable Mesos HTTP API.

Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

urora/scheduler/thrift/ThriftIT.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

duler/thrift/ThriftIT.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

urora/scheduler/thrift/ThriftIT.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

> Can we avoid repeating this in each method? > > Zameer Manji wrote: > I tried but not really. This is why: > 1. `ensureRunning` ensures the Guava service is running before we do > anything. It is a good sanity check. > 2. `blockUntilRegistered` forces ca

Re: Review Request 57061: Enable Mesos HTTP API.

hrift/ThriftIT.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/10/ Changes: https://reviews.apache.org/r/57061/diff/9-10/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review167217 --- @ReviewBot retry - Zameer Manji On Feb. 28, 2017, 10:46 p.m

Re: Review Request 57061: Enable Mesos HTTP API.

org/r/57061/diff/11/ Changes: https://reviews.apache.org/r/57061/diff/10-11/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

> production and give some feedback on performance? It would be good to know > > if we can get rid of the old native driver or we're going to have to carry > > the different implementations around for a while. We could also try and run > > this patch in our scale test

Re: Review Request 57061: Enable Mesos HTTP API.

The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

rom Mesos, but I beleive the biggest cause of these are status updates triggered by reconcilation. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review167373 ------

Re: Review Request 57061: Enable Mesos HTTP API.

.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3 Diff: https://reviews.apache.org/r/57061/diff/12/ Changes: https://reviews.apache.org/r/57061/diff/11-12/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

y generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review166430 --- On Feb. 28, 2017, 1:25 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 57061: Enable Mesos HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review167612 --- @ReviewBot retry - Zameer Manji On March 1, 2017, 11:14 a.m

Re: Review Request 57061: Enable Mesos HTTP API.

https://reviews.apache.org/r/57061/diff/13/ Changes: https://reviews.apache.org/r/57061/diff/12-13/ Testing --- The e2e test has been run three times, each time with a different driver option. Thanks, Zameer Manji

Re: Review Request 57061: Enable Mesos HTTP API.

Consider augmenting `checkState()` with an error message. Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57061/#review167579 -

Review Request 57357: Remove SerializableClock interface.

://reviews.apache.org/r/57357/diff/1/ Testing --- Thanks, Zameer Manji

Re: Review Request 57357: Remove SerializableClock interface.

/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2 Diff: https://reviews.apache.org/r/57357/diff/2/ Changes: https://reviews.apache.org/r/57357/diff/1-2/ Testing --- Thanks, Zameer Manji

Re: Review Request 57357: Remove SerializableClock interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57357/#review168090 --- @ReviewBot retry - Zameer Manji On March 6, 2017, 6:42 p.m

Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4 Diff: https://reviews.apache.org/r/57404/diff/1/ Testing --- Thanks, Zameer Manji

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

- src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java 9f39aeb1106d5ec29949280b5cf1fe3413e055d4 Diff: https://reviews.apache.org/r/57404/diff/1/ Testing --- Thanks, Zameer Manji

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

--- Thanks, Zameer Manji

Re: Review Request 57404: Reduce log output in `VersionedSchedulerDriverService`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57404/#review168331 --- @ReviewBot retry - Zameer Manji On March 7, 2017, 6:05 p.m

Re: Review Request 57433: AURORA-1895 Expose stats on ZooKeeperClient connection state

iews.apache.org/r/57433/ > --- > > (Updated March 8, 2017, 1:25 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: AURORA-1895 > https://issues.apache.org/jira/browse/AURORA-1895 > > > Repository: aurora > > > Descriptio

Review Request 57524: Support setting the rootfs on Mesos Containers.

/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9 Diff: https://reviews.apache.org/r/57524/diff/1/ Testing --- Thanks, Zameer

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

ommon/sandbox.py#L284-L290 I see that I have been unclear here. I will take some time to better document the problem to explain why I think this is necesssary. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

iff/1/ Testing --- e2e tests. File Attachments (updated) Screenshot https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png Thanks, Zameer Manji

Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

hanks, Zameer Manji

Review Request 57717: Support Mesos Maintenance

/http_example.aurora de8179228d9359900eadf4084355ea257bea45ba src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 80b4c54774a02fdc2ee0e36d26f81aedd2e0055e Diff: https://reviews.apache.org/r/57717/diff/1/ Testing --- e2e tests Thanks, Zameer Manji

Re: Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.

anges in the psutil changelog, this seems fine to me. Nice find! - Zameer Manji On March 17, 2017, 9:38 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 57717: Support Mesos Maintenance

ched) > > <https://reviews.apache.org/r/57717/diff/1/?file=150#file150line227> > > > > The test using this helper will be waiting for over 2.5min. Would be > > great if you replace the sleeps with proper "wait until loops" in > > `assert_ta

Re: Review Request 57717: Support Mesos Maintenance

://reviews.apache.org/r/57717/diff/1-2/ Testing --- e2e tests Thanks, Zameer Manji

Re: Review Request 57717: Support Mesos Maintenance

: https://reviews.apache.org/r/57717/diff/2-3/ Testing --- e2e tests Thanks, Zameer Manji

Re: Review Request 57717: Support Mesos Maintenance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57717/#review169335 --- @ReviewBot retry - Zameer Manji On March 17, 2017, 3:05 p.m

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

e.org/r/57708/diff/1-2/ Testing --- e2e tests. File Attachments Screenshot https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png Thanks, Zameer Manji

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

tions, as `serverset_endpoint_name` > > indicates I can put everything in there. Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57708/#review169288 -----

Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.

https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png Thanks, Zameer Manji

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57757/#review169497 --- Ship it! Ship It! - Zameer Manji On March 20, 2017, 1:41

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57757/#review169501 --- Ship it! Ship It! - Zameer Manji On March 20, 2017, 1:41

Re: Review Request 57757: Make Thermos observer resource collection intervals configurable

omatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57757/ > --- > > (Updated March 20, 2017, 1:41 p.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji. > > > Bugs: AURORA-1907 > https://issues.apache.org/jira/

Re: Review Request 57717: Support Mesos Maintenance

Controller.java > > Lines 163 (patched) > > <https://reviews.apache.org/r/57717/diff/3/?file=1667446#file1667446line168> > > > > Consider moving this message into `drainTasksOnHost`. Done. - Zameer --

<    1   2   3   4   5   6   7   8   9   10   >