Re: Review Request 68110: Update URLS for git repositories

2018-07-30 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68110/#review206602 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 30

Re: Review Request 68071: Prune updates that have no surviving job keys in the TaskStore

2018-07-26 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68071/#review206521 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 26

Re: Review Request 68047: Add size metric for memory stores, add MemSchedulerStoreTest

2018-07-25 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68047/#review206481 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 25

Re: Review Request 67967: Unhandled exception should not strand runner in STARTING state.

2018-07-18 Thread Santhosh Kumar Shanmugham
LOST here instead? Most users interpret TASK_FAILED > > as their responsibility whereas TASK_LOST is more of a misshap of > > Aurora/Mesos/Thermos. I would think an unknown exception in the runner is > > part of the latter category. > > Santhosh Kumar Shanmugham wrote: >

Re: Review Request 67967: Unhandled exception should not strand runner in STARTING state.

2018-07-18 Thread Santhosh Kumar Shanmugham
-------- On July 18, 2018, 1:27 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67967/ > -

Review Request 67967: Unhandled exception should not strand runner in STARTING state.

2018-07-18 Thread Santhosh Kumar Shanmugham
/python/apache/aurora/executor/test_thermos_executor.py f6ae1be5d56bfd845bd09db67efa92091136 Diff: https://reviews.apache.org/r/67967/diff/1/ Testing --- ./gradlew test ./pants test src/test/python/apache:: Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67696: Enable SLA-aware updates

2018-07-17 Thread Santhosh Kumar Shanmugham
va/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java Lines 1080 (patched) <https://reviews.apache.org/r/67696/#comment289043> s/policy/sla-policy/ - Santhosh Kumar Shanmugham On July 16, 2018, 4 p.m., Jor

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/#review206024 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 12

Re: Review Request 67696: Enable SLA-aware updates

2018-07-12 Thread Santhosh Kumar Shanmugham
> On July 9, 2018, 2:04 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java > > Lines 140 (patched) > > <https://reviews.apache.org/r/67696/diff/5/?file=2054728#file2054728line140> > > > >

Re: Review Request 67696: Enable SLA-aware updates

2018-07-09 Thread Santhosh Kumar Shanmugham
like a valid event that is definied in code. src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java Lines 194 (patched) <https://reviews.apache.org/r/67696/#comment288768> Drop `_` here and everywhere. `SLA_PASSED` sounds like a real event. - Santhosh Kum

Re: Review Request 67757: TaskQuery struct needs to be optional

2018-07-09 Thread Santhosh Kumar Shanmugham
. - Santhosh Kumar Shanmugham On June 29, 2018, 4:07 p.m., Ezequiel Torres wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67757: TaskQuery struct needs to be optional

2018-07-09 Thread Santhosh Kumar Shanmugham
> On June 28, 2018, 11:23 a.m., Santhosh Kumar Shanmugham wrote: > > Can you include the end-to-end test results? This takes about an hour to > > complete and can be invoked like so from the project root, > > > > ``` > > {~/oss/aurora} (master)$ > &

Re: Review Request 67757: TaskQuery struct needs to be optional

2018-06-29 Thread Santhosh Kumar Shanmugham
> On June 28, 2018, 11:23 a.m., Santhosh Kumar Shanmugham wrote: > > Can you include the end-to-end test results? This takes about an hour to > > complete and can be invoked like so from the project root, > > > > ``` > > {~/oss/aurora} (master)$ > &

Re: Review Request 67705: Updated restore instructions to reflect using offline rehydration tool

2018-06-29 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67705/#review205590 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On June 28

Re: Review Request 67757: TaskQuery struct needs to be optional

2018-06-28 Thread Santhosh Kumar Shanmugham
hour to complete and can be invoked like so from the project root, ``` {~/oss/aurora} (master)$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh ``` - Santhosh Kumar Shanmugham On June 27, 2018, 12:04 p.m., Ezequiel Torres wrote

Re: Review Request 67757: TaskQuery struct needs to be optional

2018-06-28 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67757/#review205520 --- @ReviewBot retry - Santhosh Kumar Shanmugham On June 27, 2018

Review Request 67734: Display negation of constraint in TaskConfigSummary.

2018-06-25 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/media/uploaded/files/2018/06/26/792ca9e1-85bc-4223-8153-159bf85f84aa__Screen_Shot_2018-06-25_at_5.18.01_PM.png Thanks, Santhosh Kumar Shanmugham

Review Request 67706: Fix style of TaskConfigSummary.

2018-06-22 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/media/uploaded/files/2018/06/22/7f7b45b4-e5d2-49b6-8248-d91cf2d2c3b7__Screen_Shot_2018-06-22_at_1.14.31_PM.png After https://reviews.apache.org/media/uploaded/files/2018/06/22/144e4760-3b87-4f38-9883-f5453bd420a3__Screen_Shot_2018-06-22_at_1.16.05_PM.png Thanks, Santhosh Kumar

Re: Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-20 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67657/#review205133 --- @ReviewBot retry - Santhosh Kumar Shanmugham On June 20, 2018

Re: Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-20 Thread Santhosh Kumar Shanmugham
sk": { "assignedPorts": {}, "instanceId": 0, "slaveHost": "192.168.33.7", "slaveId": "f0336813-864b-4c8f-914c-80f8cef3b61d-S0", "task": { ... } Responded: True Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-20 Thread Santhosh Kumar Shanmugham
sk": { "assignedPorts": {}, "instanceId": 0, "slaveHost": "192.168.33.7", "slaveId": "f0336813-864b-4c8f-914c-80f8cef3b61d-S0", "task": { ... } Responded: True Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-20 Thread Santhosh Kumar Shanmugham
rate Metadata in the JSON body approach if a need arises. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67657/#review205102 -------

Review Request 67657: Introduce a `countdown-ms` param in Coordinator request.

2018-06-19 Thread Santhosh Kumar Shanmugham
alse Request received for {'countdown-ms': ['34777'], 'task': ['devcluster/vagrant/test/coordinator/1']} Responded: False Thanks, Santhosh Kumar Shanmugham

Review Request 67639: Export count-down to forceful Maintenace as a metric.

2018-06-18 Thread Santhosh Kumar Shanmugham
maintenance_countdown_ms_vagrant/test/coordinator/1 0 Thanks, Santhosh Kumar Shanmugham

Review Request 67638: Export number of tasks lost per dedicated role.

2018-06-18 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/r/67638/diff/1/ Testing --- ./gradlew test **Tested on Vagrant** tasks_lost_dedicatedweb.multi 0 tasks_lost_dedicated_vagrant 2 Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67627: Add observer flag to disable resource metric collection

2018-06-18 Thread Santhosh Kumar Shanmugham
g/r/67627/#comment287753> also disk metrics - Santhosh Kumar Shanmugham On June 18, 2018, 1:57 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
aurora-scheduler[8719]: I0615 20:48:53.475 [CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler. ... Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited. Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
ecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler. ... Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited. Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
/ Testing --- ./gradlew test Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204858 ------- On June 15, 2018, 11:02 a.m., Santhosh Kumar Shanmugham wrote: > > --

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
98bec4857f1b3c247c24059150de3e4aac080a02 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad Diff: https://reviews.apache.org/r/67613/diff/1/ Testing --- ./gradlew test Thanks, Santhosh Kumar Shanmugham

Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
07082a99701ea1e428164e76267b908ae20508ad Diff: https://reviews.apache.org/r/67613/diff/1/ Testing --- ./gradlew test Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.2.0

2018-06-13 Thread Santhosh Kumar Shanmugham
> On June 13, 2018, 12:19 p.m., Santhosh Kumar Shanmugham wrote: > > Ship It! Actullay minor comment - fix the commit message "Virutalenv version is mis-spelled" - Santhosh Kumar --- This is an automatically generat

Re: Review Request 67326: Update Pants to 1.6.0 and Virtualenv to 16.2.0

2018-06-13 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67326/#review204723 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On May 25

Re: Review Request 67479: Remove maintenance request after a host is drained.

2018-06-06 Thread Santhosh Kumar Shanmugham
t: https://reviews.apache.org/r/67479/#review204427 --- On June 6, 2018, 12:44 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e

Review Request 67479: Remove maintenance request after a host is drained.

2018-06-06 Thread Santhosh Kumar Shanmugham
/scheduler/maintenance/MaintenanceControllerImplTest.java 28c62a17db33b16d084b59cf40ca299f322d05e7 Diff: https://reviews.apache.org/r/67479/diff/1/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-05 Thread Santhosh Kumar Shanmugham
-977c-fdd925a23185__Screen_Shot_2018-06-04_at_8.14.28_PM.png Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-04 Thread Santhosh Kumar Shanmugham
> On June 1, 2018, 1:44 p.m., David McLaughlin wrote: > > Looks great! > > > > Has this been load-tested? Do we know how many concurrent machines with > > coordinator tasks can be put into maintenance before it starts to affect > > offer processing, etc.? >

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-04 Thread Santhosh Kumar Shanmugham
thosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-04 Thread Santhosh Kumar Shanmugham
generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204272 ------- On June 4, 2018, 8:35 p.m., Santhosh Kumar Shanmugham wrote: > > --- > Thi

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-04 Thread Santhosh Kumar Shanmugham
/test_end_to_end.sh File Attachments (updated) Load test results https://reviews.apache.org/media/uploaded/files/2018/06/05/96d42678-8e61-48c8-977c-fdd925a23185__Screen_Shot_2018-06-04_at_8.14.28_PM.png Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-06-04 Thread Santhosh Kumar Shanmugham
ed e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review204202 --- On May 25, 2018, 6:13 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
--- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203916 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 25, 2018

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
nism as deprecated > > in the RELEASE-NOTES? My thinking was to replace the `host_drain` logic with the one under `sla_host_drain` instead. So we will deprecate `sla_host_drain` in the next release and replace the logic for `host_drain`? Putting `host_drain` under deprecation, neve

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203896 --- On May 25, 2018, 2:14 p.m., Santhosh Kumar Shanmugham wrote: > > -

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-25 Thread Santhosh Kumar Shanmugham
66716/diff/11-12/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66537: Adding enhancements to Docker functionality and client support for FetcherURIs

2018-05-24 Thread Santhosh Kumar Shanmugham
Should this be resolved when interpolating the pystachio schema in the client? What about the other templated namespaces? http://aurora.apache.org/documentation/latest/reference/configuration/#template-namespaces - Santhosh Kumar Shanmugham On May 2, 2018, 6

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-24 Thread Santhosh Kumar Shanmugham
/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-24 Thread Santhosh Kumar Shanmugham
://reviews.apache.org/r/66716/diff/10/ Testing (updated) --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-23 Thread Santhosh Kumar Shanmugham
ry.js 64880f4bd5c5358287ef481df455f6355fedd7d6 Diff: https://reviews.apache.org/r/66716/diff/10/ Changes: https://reviews.apache.org/r/66716/diff/9-10/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-23 Thread Santhosh Kumar Shanmugham
ent in > > `SlaManager` Addressed above comment. - Santhosh Kumar ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203701

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-22 Thread Santhosh Kumar Shanmugham
part of this patch, the diffs look werid. Please see diff against master. - Santhosh Kumar Shanmugham On May 22, 2018, 5:21 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-22 Thread Santhosh Kumar Shanmugham
64880f4bd5c5358287ef481df455f6355fedd7d6 Diff: https://reviews.apache.org/r/66716/diff/9/ Changes: https://reviews.apache.org/r/66716/diff/8-9/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67219: Fix flaky Webhook test by ensuring proper error condition

2018-05-21 Thread Santhosh Kumar Shanmugham
/events/WebhookTest.java Line 244 (original), 241 (patched) <https://reviews.apache.org/r/67219/#comment285801> Update comment. - Santhosh Kumar Shanmugham On May 21, 2018, 11 a.m., Jordan Ly wrote: > > --- > This is a

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-17 Thread Santhosh Kumar Shanmugham
s/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob > 88e1c36a1aa2d192b95963f7aa36e243a447e4af > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate > 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks > 4323031ec6bd128576c2a43ebc11f04a9f046e2f > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/16-saveHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/17-removeHostMaintenanceRequest > PRE-CREATION > src/test/sh/org/apache/aurora/e2e/sla_policy.aurora PRE-CREATION > ui/src/main/js/components/TaskConfigSummary.js > 64880f4bd5c5358287ef481df455f6355fedd7d6 > > > Diff: https://reviews.apache.org/r/66716/diff/8/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-17 Thread Santhosh Kumar Shanmugham
Diff: https://reviews.apache.org/r/66716/diff/8/ Changes: https://reviews.apache.org/r/66716/diff/7-8/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-16 Thread Santhosh Kumar Shanmugham
: https://reviews.apache.org/r/67141/diff/3/ Changes: https://reviews.apache.org/r/67141/diff/2-3/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-16 Thread Santhosh Kumar Shanmugham
-compatible/17-removeHostMaintenanceRequest PRE-CREATION Diff: https://reviews.apache.org/r/67141/diff/2/ Changes: https://reviews.apache.org/r/67141/diff/1-2/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-16 Thread Santhosh Kumar Shanmugham
is present. > > Stephan Erb wrote: > Ah good catch! I will add the RELEASE-NOTES entry in the next patch and include similar instructions for rollback. - Santhosh Kumar --- This is an automatically generated e-mail. To repl

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-16 Thread Santhosh Kumar Shanmugham
23580#file2023580line266> > > > > Same as above. Same as above. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203243 -------

Review Request 67142: Add SlaManager to encapsulate SLA operations.

2018-05-15 Thread Santhosh Kumar Shanmugham
--- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-15 Thread Santhosh Kumar Shanmugham
-removeHostMaintenanceRequest PRE-CREATION Diff: https://reviews.apache.org/r/67141/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Review Request 67141: Introduce structs to enable specifying custom SLA.

2018-05-15 Thread Santhosh Kumar Shanmugham
/durability/goldens/read-compatible/17-removeHostMaintenanceRequest PRE-CREATION Diff: https://reviews.apache.org/r/67141/diff/1/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203150 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 15, 2018

Re: Review Request 66716: Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-15 Thread Santhosh Kumar Shanmugham
64880f4bd5c5358287ef481df455f6355fedd7d6 Diff: https://reviews.apache.org/r/66716/diff/7/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-15 Thread Santhosh Kumar Shanmugham
64880f4bd5c5358287ef481df455f6355fedd7d6 Diff: https://reviews.apache.org/r/66716/diff/7/ Changes: https://reviews.apache.org/r/66716/diff/6-7/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66192: [WIP] Variable group size updates

2018-05-15 Thread Santhosh Kumar Shanmugham
> On May 14, 2018, 10:58 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > > Lines 826 (patched) > > <https://reviews.apache.org/r/66192/diff/2/?file=2018260#file2018260line826> > &

Re: Review Request 66192: [WIP] Variable group size updates

2018-05-15 Thread Santhosh Kumar Shanmugham
e/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java:127: > > Line is longer than 100 characters (found 101). [LineLength] > > FAILED > > > > FAILURE: Build failed with an exception. > > &

Re: Review Request 66192: [WIP] Variable group size updates

2018-05-15 Thread Santhosh Kumar Shanmugham
> > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Can you clean up the style issues? Also, will this be configurable via the pystachio config? - Santhosh Kumar ---

Re: Review Request 66192: [WIP] Variable group size updates

2018-05-14 Thread Santhosh Kumar Shanmugham
rward and backward cases? src/main/java/org/apache/aurora/scheduler/updater/strategy/VariableBatchStrategy.java Lines 67 (patched) <https://reviews.apache.org/r/66192/#comment285108> nit - s/where/we are/ - Santhosh Kumar Shanmugham On May 8, 2018, 4:26 p.

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-14 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review203047 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 14, 2018

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-14 Thread Santhosh Kumar Shanmugham
.org/r/66716/diff/6/ Changes: https://reviews.apache.org/r/66716/diff/5-6/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-14 Thread Santhosh Kumar Shanmugham
py > > Line 65 (original), 65 (patched) > > <https://reviews.apache.org/r/66716/diff/5/?file=2018632#file2018632line65> > > > > where does this come from `process.memory_maps` is not supported on OS X and fails the test. https://psutil.readthedocs.io/en/lat

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-14 Thread Santhosh Kumar Shanmugham
/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-09 Thread Santhosh Kumar Shanmugham
le/17-removeHostMaintenanceRequest PRE-CREATION Diff: https://reviews.apache.org/r/66716/diff/5/ Changes: https://reviews.apache.org/r/66716/diff/4-5/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
r exactly the situation you mentioned while rolling out the patch (for debugging). It is safe to ingore drains like this after the scheduler startup, since all drains are driven from clients today. So the clients will retry the drain -> which will create the maintenance request object

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202657 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 8, 2018, 8

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
Diff: https://reviews.apache.org/r/66716/diff/4/ Changes: https://reviews.apache.org/r/66716/diff/3-4/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
> > > If I am going to force the work to be done, do I need to even call this > > method? I want to invoke the required in one-place so it is easier to follow. - Santhosh Kumar --- This is an automatically

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202594 ------- On May 8, 2018, 8:28 a.m., Santhosh Kumar Shanmugham wrote: > >

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
/goldens/current/saveJobUpdate > 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks > 4323031ec6bd128576c2a43ebc11f04a9f046e2f > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/16-saveHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/17-removeHostMaintenanceRequest > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66716/diff/3/ > > > Testing > --- > > ./build-support/jenkins/build.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-08 Thread Santhosh Kumar Shanmugham
/storage/durability/goldens/read-compatible/17-removeHostMaintenanceRequest PRE-CREATION Diff: https://reviews.apache.org/r/66716/diff/3/ Changes: https://reviews.apache.org/r/66716/diff/2-3/ Testing --- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66922/#review202453 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On May 2

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-01 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66716/#review202246 --- @ReviewBot retry - Santhosh Kumar Shanmugham On May 1, 2018, 2

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-01 Thread Santhosh Kumar Shanmugham
ute` > > which would be a consumer that checks the SLA then executes an action > > provided by the caller. I am thinking about this in terms of my proposed > > SLA-aware updates -- I would be able to utilize this interface as well. Discussed offline a lot about the interface to

Re: Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-05-01 Thread Santhosh Kumar Shanmugham
Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66806: Breakdown resource stats by role

2018-04-26 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66806/#review202021 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On April 26

Re: Review Request 66697: Add --pid-file flag to `aurora task ssh` to write the PID of the underlying SSH command to a specified file.

2018-04-19 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66697/#review201559 --- @ReviewBot retry - Santhosh Kumar Shanmugham On April 19, 2018

Re: Review Request 66697: Add --pid-file flag to `aurora task ssh` to write the PID of the underlying SSH command to a specified file.

2018-04-19 Thread Santhosh Kumar Shanmugham
> On April 19, 2018, 1:52 p.m., Santhosh Kumar Shanmugham wrote: > > @ReviewBot retry Actually, looks like some style issues. - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 66697: Add --pid-file flag to `aurora task ssh` to write the PID of the underlying SSH command to a specified file.

2018-04-19 Thread Santhosh Kumar Shanmugham
/test_task.py Lines 175 (patched) <https://reviews.apache.org/r/66697/#comment282732> Pull `12312` into a constant. - Santhosh Kumar Shanmugham On April 18, 2018, 2:54 p.m., Sameer Brenn wrote: > > --- > This is an automatically g

Review Request 66716: [WIP] Enable `Tasks` to specify their own custom maintenance SLA.

2018-04-19 Thread Santhosh Kumar Shanmugham
--- ./build-support/jenkins/build.sh Thanks, Santhosh Kumar Shanmugham

Re: Review Request 66697: Add --pid-file flag to `aurora task ssh` to write the PID of the underlying SSH command to a specified file.

2018-04-18 Thread Santhosh Kumar Shanmugham
/11/24/auto-closing-ssh-tunnels/ - Santhosh Kumar Shanmugham On April 18, 2018, 2:54 p.m., Sameer Brenn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

2018-04-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66186/#review201337 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On April 11

Re: Review Request 66623: Fix the json endpoints in thermos

2018-04-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66623/#review201336 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On April 16

Re: Review Request 66573: Add initial interval before searching for preemption slots

2018-04-11 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200950 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On April 11

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

2018-04-11 Thread Santhosh Kumar Shanmugham
/PendingTaskProcessor.java Lines 194 (patched) <https://reviews.apache.org/r/66536/#comment281815> Include candidates as well. - Santhosh Kumar Shanmugham On April 10, 2018, 3:47 p.m., Jordan Ly wrote: > > ---

Re: Review Request 66269: End to end tests misc. fixes

2018-03-27 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66269/#review200069 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 25

Re: Review Request 66103: Introduce mesos disk collector

2018-03-22 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199838 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 22

  1   2   3   4   5   >