Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review107128 --- This has been idle a good while and it appears wfarner has picked u

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95873 --- Partial review - stopped at the question of how to ensure the precon

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, > > line 57 > > > > > > Please model your configuration as an object, and let Gson do t

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95689 --- Master (22f9cbb) is red with this patch. ./build-support/jenkins/b

Re: Review Request 36289: Custom executor support for Scheduler

> On Aug. 18, 2015, 3:06 a.m., Aurora ReviewBot wrote: > > Master (22f9cbb) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > :api:checkPython > > :api:generateThriftEntitiesJava > > :api:classesThriftEntities > > :api:compileJava UP-TO-DATE > > :api:generateThriftResou

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 6:10 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review95680 --- Master (22f9cbb) is red with this patch. ./build-support/jenkins/b

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 12:33 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated Aug. 18, 2015, 12:28 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, > > line 57 > > > > > > Please model your configuration as an object, and let Gson do t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, > > line 57 > > > > > > Please model your configuration as an object, and let Gson do t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, > > line 57 > > > > > > Please model your configuration as an object, and let Gson do t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 6:08 p.m., Jay Buffington wrote: > > > Support for custom executors in the client must be added in order to > > > fully utilize this feature. > > > > For the first pass I would expose the interface in the server (thrift api) > > and default it to use thermos. You can get t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 6:08 p.m., Jay Buffington wrote: > > > Support for custom executors in the client must be added in order to > > > fully utilize this feature. > > > > For the first pass I would expose the interface in the server (thrift api) > > and default it to use thermos. You can get t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/dist/etc/executors.json, line 1 > > > > > > Please move this file to `examples/vagrant`, as this configuration is > > not suitable for distribution to others.

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, > > line 57 > > > > > > Please model your configuration as an object, and let Gson do t

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 7:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines > > 87-115 > > > > > > In this change, we cannot remove these arguments as it breaks > >

Re: Review Request 36289: Custom executor support for Scheduler

On Wed, Jul 15, 2015 at 12:13 PM, Kevin Sweeney wrote: > > > > On July 15, 2015, 12:08 p.m., Bill Farner wrote: > > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, > lines 87-115 > > > < > https://reviews.apache.org/r/36289/diff/2/?file=1011920#file1011920line87> > > > > > >

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 12:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines > > 87-115 > > > > > > In this change, we cannot remove these arguments as it breaks > >

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review91793 --- Stopped at parsing code, since i belive it can be made quite a bit s

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review91781 --- > Support for custom executors in the client must be added in order

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review91702 --- Ship it! Master (d9dac92) is green with this patch. ./build-suppo

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated July 15, 2015, 1:13 a.m.) Review request for Aurora. Changes ---

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/ --- (Updated July 15, 2015, 1:10 a.m.) Review request for Aurora. Changes ---

Re: Review Request 36289: Custom executor support for Scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36289/#review90853 --- This patch does not apply cleanly on master (62a432a), do you need t