Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review111929 --- Ship it! LGTM! Thanks! Few minor remaining things. * Please stri

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review111926 --- Ship it! Master (1ae77d5) is green with this patch. ./build-supp

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-27 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 27, 2015, 1:44 p.m.) Review request for Aurora. Repository: aur

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review111056 --- Thanks! This patch LGTM overall, but it would be really nice to ex

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110950 --- Master (3e1f823) is green with this patch. ./build-support/jenkin

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-17 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 17, 2015, 12:27 p.m.) Review request for Aurora. Repository: au

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110718 --- Master (fb8155d) is red with this patch. ./build-support/jenkins/

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110693 --- Master (fb8155d) is green with this patch. true However, it appe

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110684 --- Master (fb8155d) is red with this patch. ./build-support/jenkins/

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110682 --- @ReviewBot retry Trying again. - Kasisnu Singh On Dec. 16, 2015

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110677 --- @ReviewBot retry - Kasisnu Singh On Dec. 16, 2015, 4:41 p.m., Ka

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110676 --- @ReviewBot retry kicking the bot since it probably a race when the

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110673 --- This patch does not apply cleanly on master (fb8155d), do you need

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 16, 2015, 4:41 p.m.) Review request for Aurora. Repository: aur

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 16, 2015, 4:38 p.m.) Review request for Aurora. Changes ---

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Bill Farner
> On Dec. 10, 2015, 4:38 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 364 > > > > > > Is it really necessary that this is implemented docker specific? I > > believ

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Kasisnu Singh
> On Dec. 10, 2015, 12:38 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 364 > > > > > > Is it really necessary that this is implemented docker specific? I > > belie

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review109749 --- Master (8613f7b) is green with this patch. ./build-support/jenkin

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review109748 --- src/main/python/apache/aurora/executor/thermos_task_runner.py (lin

Review Request 41201: Preserve env variables for tasks in docker

2015-12-10 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- Review request for Aurora. Repository: aurora Description --- Preserve e