---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review153144
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 18, 2016, 11:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review153139
---
Ship it!
Master (ad77de1) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152589
---
Ship it!
Master (8256000) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152588
---
Ship it!
LGTM, but I'm +1 on Zameer's suggestion to check that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152587
---
Ship it!
Nevermind, didn't realize there are multiple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152583
---
src/test/python/apache/aurora/executor/test_thermos_executor.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
---
(Updated Oct. 13, 2016, 10:12 p.m.)
Review request for Aurora, Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152582
---
Master (8256000) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
---
(Updated Oct. 13, 2016, 9:14 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152575
---
This patch does not apply cleanly against master (8256000), do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
---
(Updated Oct. 13, 2016, 8:35 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152429
---
src/main/python/apache/aurora/executor/thermos_task_runner.py
> On Oct. 12, 2016, 7:48 p.m., David McLaughlin wrote:
> > Thanks for doing this!
> >
> > Could you add a test for this? Looking in test_task_runner.py, it looks
> > like unfortunately the provider class lacks any sort of coverage. A minimal
> > test here could be to just test the path
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152386
---
Master (03eff28) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review152385
---
Thanks for doing this!
Could you add a test for this? Looking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
---
Review request for Aurora, Joshua Cohen and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/
---
(Updated Oct. 12, 2016, 12:42 p.m.)
Review request for Aurora, Joshua Cohen
17 matches
Mail list logo
