On May 12, 2014, 10:17 p.m., Kevin Sweeney wrote:
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java, line 241
https://reviews.apache.org/r/21294/diff/1/?file=578006#file578006line241
Runnable?
I explored that, but Runnable has the downside of declaring no checked
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
I think we should show the config bar even when there is one config. It
will also act a visual indication to the user that all his tasks are in a
consistent config.
This is a fair suggestion, and I tried this initially. Having a 100%
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review42833
---
ping? (just trying to get this back into the mail queue.)
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42834
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 13, 2014, 12:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21205/#review42832
---
Suman, ping?
- Mark Chu-Carroll
On May 8, 2014, 10:26 a.m., Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
---
(Updated May 13, 2014, 5:49 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
---
(Updated May 13, 2014, 5:49 p.m.)
Review request for Aurora, Kevin Sweeney,
On May 12, 2014, 8:16 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java,
line 108
https://reviews.apache.org/r/21132/diff/2/?file=577940#file577940line108
this function would help cut down a bunch of redundancy in this class:
On May 12, 2014, 8:16 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java,
line 104
https://reviews.apache.org/r/21132/diff/2/?file=577940#file577940line104
s/final //, applies to ~all test cases
David McLaughlin wrote:
So
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21383/
---
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: aurora-417
On April 24, 2014, 6:19 p.m., Bill Farner wrote:
Dave - can you push this on a branch to github so we can see it rendered
there?
Ping?
- Bill
---
This is an automatically generated e-mail. To reply, visit:
On May 13, 2014, 11:07 a.m., Bill Farner wrote:
build-support/tools/list-missing-shipits, line 94
https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94
At a quick glance, it's not obvious how this relates to plumbing the
'project' argument. Was there another
On May 12, 2014, 8:16 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line
54
https://reviews.apache.org/r/21132/diff/2/?file=577925#file577925line54
Formatting nit:
TODO(davmclau)
as opposed to:
On May 13, 2014, 11:07 a.m., Bill Farner wrote:
build-support/tools/list-missing-shipits, line 94
https://reviews.apache.org/r/21386/diff/1/?file=580750#file580750line94
At a quick glance, it's not obvious how this relates to plumbing the
'project' argument. Was there another
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/
---
(Updated May 13, 2014, 6:27 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42852
---
config/findbugs/excludeFilter.xml
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/
---
(Updated May 13, 2014, 8:04 p.m.)
Review request for Aurora, Jake Farrell and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review42427
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/#review42887
---
src/main/python/apache/aurora/client/config.py
On May 13, 2014, 9:19 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/config.py, line 130
https://reviews.apache.org/r/21297/diff/1/?file=578010#file578010line130
curious if we should be adding a delta here? if we just do watch_secs
= initial_interval_secs, then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/#review42914
---
Ship it!
src/main/python/apache/aurora/client/config.py
On May 14, 2014, 12:42 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java, line 198
https://reviews.apache.org/r/21349/diff/2/?file=580984#file580984line198
This is problematic in two ways - it synthetically slows the build by 5
seconds, and
On May 14, 2014, 12:42 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java, line 198
https://reviews.apache.org/r/21349/diff/2/?file=580984#file580984line198
This is problematic in two ways - it synthetically slows the build by 5
seconds, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 14, 2014, 1:30 a.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21407/
---
Review request for Aurora, Suman Karumuri and Bill Farner.
Bugs: AURORA-228
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/
---
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-381
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/
---
Review request for Aurora, Jake Farrell and Kevin Sweeney.
Bugs: AURORA-149
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review42937
---
This looks really good. Thanks for the changes. The only ship it
28 matches
Mail list logo
