---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21349/
---
(Updated May 15, 2014, 12:26 a.m.)
Review request for Aurora and Bill Farner.
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 385
https://reviews.apache.org/r/21247/diff/1/?file=577123#file577123line385
please only pass the required fields into the fields into the function.
On May 13, 2014, 12:26 a.m., David McLaughlin wrote:
File Attachment: job summary of cron job - Screen Shot 2014-05-11 at
1.37.54 PM.png
https://reviews.apache.org/r/21250/#fcomment18
There is no distinction between label/value nor whitespace or borders
to separate different
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21297/
---
(Updated May 15, 2014, 12:59 a.m.)
Review request for Aurora, Kevin Sweeney
On May 15, 2014, 5:06 p.m., Suman Karumuri wrote:
build.gradle, line 246
https://reviews.apache.org/r/21407/diff/2/?file=581989#file581989line246
Should we be adding generated thrift sources here?
'ACTIVE_STATES' is not defined.
On May 15, 2014, 5:06 p.m., Suman Karumuri wrote:
build.gradle, line 246
https://reviews.apache.org/r/21407/diff/2/?file=581989#file581989line246
Should we be adding generated thrift sources here?
'ACTIVE_STATES' is not defined.
On May 15, 2014, 12:11 a.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/config.py, line 161
https://reviews.apache.org/r/21297/diff/5/?file=582112#file582112line161
Also worth noting is that this warning is meaningless if the user
doesn't have health checking
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21407/#review43182
---
The code is pushed to master. Please close out this review and the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review43117
---
Ship it!
awesome!!!
- Joe Smith
On May 12, 2014, 5:15 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review43160
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/
---
(Updated May 16, 2014, 12:16 a.m.)
Review request for Aurora, David McLaughlin
On May 15, 2014, 12:27 a.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/config.py, line 132
https://reviews.apache.org/r/21297/diff/5/?file=582112#file582112line132
I find health notifications to be delivered to be vague. I prefer the
wording In order for the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21502/#review43183
---
Ship it!
Ship It!
- Maxim Khutornenko
On May 15, 2014, 10:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/
---
(Updated May 15, 2014, 12:02 p.m.)
Review request for Aurora and Joe Smith.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21402/#review43078
---
build-support/python/checkstyle-check
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/
---
(Updated May 15, 2014, 9:47 p.m.)
Review request for Aurora, Suman Karumuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21459/#review43170
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43185
---
On May 15, 2014, 2:01 a.m., Dan Norris wrote:
build-support/python/checkstyle-check, line 23
https://reviews.apache.org/r/21402/diff/2/?file=580886#file580886line23
Could you consolidate checkstyle and checkstyle check by sourcing the
venv and calling deactivate once you're done?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/
---
Review request for Aurora, David McLaughlin and Suman Karumuri.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21247/#review43180
---
This diff is merged. Please close out this review and the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19796/#review43173
---
Ship it!
I'm +1 if this works on master now.
- Kevin Sweeney
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/#review43083
---
kevints: Is there anything still blocking this that you see? It
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18537/
---
(Updated May 15, 2014, 2:47 a.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review43208
---
src/main/python/apache/aurora/client/cli/config.py
On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 17
https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17
Why?
David McLaughlin wrote:
Good question.
JavaScript
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review43164
---
Ship it!
Ship It!
- David McLaughlin
On May 15, 2014, 9:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/#review43218
---
Ship it!
Ship It!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
---
Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/
---
(Updated May 15, 2014, 7:28 p.m.)
Review request for Aurora, David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43155
---
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java
On May 16, 2014, 4 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line
43
https://reviews.apache.org/r/21132/diff/3/?file=580759#file580759line43
Breaking the abstraction by having a JobKeyMapper here is quite
unfortunate.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/#review43156
---
Ship it!
Display and java code LGTM. I'll let David field the JS
On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote:
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js,
line 17
https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17
Why?
Good question.
JavaScript in the browser doesn't have modules or
On May 14, 2014, 10:57 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/updater.py, line 237
https://reviews.apache.org/r/21440/diff/1/?file=581729#file581729line237
it surprises me that this is necessary. will signal.signal() even work
outside of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43234
---
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/
---
(Updated May 15, 2014, 9:07 p.m.)
Review request for Aurora, David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21250/
---
(Updated May 15, 2014, 12:46 a.m.)
Review request for Aurora, David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21294/
---
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim
On April 25, 2014, 4:06 a.m., Bill Farner wrote:
I have some reservations with this, but they're not well-formed. I like
the idea of giving committers a chance to chime in on reviews, and we seem
to be building process around reviewboard for that. We also have plans to
build test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21459/
---
Review request for Aurora, David McLaughlin and Kevin Sweeney.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21426/#review43018
---
Are you using the correct logo (from AURORA-229)? It's hard to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21455/#review43177
---
build.gradle
https://reviews.apache.org/r/21455/#comment77247
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21273/#review43138
---
Ship it!
src/main/python/apache/aurora/client/cli/config.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/
---
(Updated May 15, 2014, 12:08 p.m.)
Review request for Aurora and Joe Smith.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21502/
---
Review request for Aurora, Maxim Khutornenko and Brian Wickman.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review42417
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/#review43192
---
Ship it!
Ship It!
- David McLaughlin
On May 16, 2014, 12:16
On May 14, 2014, 7:20 p.m., Mark Chu-Carroll wrote:
src/test/python/apache/aurora/client/api/test_updater.py, line 126
https://reviews.apache.org/r/21440/diff/1/?file=581731#file581731line126
Doesn't this mean that the test will be running with just one thread?
That will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21386/#review43080
---
please create a jira issue for this and then +1
- Jake Farrell
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21497/
---
(Updated May 16, 2014, 12:16 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21523/
---
(Updated May 16, 2014, 1:30 a.m.)
Review request for Aurora, Suman Karumuri
52 matches
Mail list logo
