Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43972 --- Ship it! Ship It! - Mark Chu-Carroll On May 23, 2014, 3:30

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review43976 --- Ship it! Ship It! - Maxim Khutornenko On May 23, 2014, 8:26

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43977 --- src/main/java/org/apache/aurora/scheduler/thrift/Util.java

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43979 --- Ping Brian, Mark. - Maxim Khutornenko On May 23, 2014, 1:19

Re: Review Request 21741: Adding grouping for the sla commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/#review43980 --- Ping Mark, Joe. - Maxim Khutornenko On May 23, 2014, 1:12 a.m.,

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43982 --- Ship it! Ship It! - Mark Chu-Carroll On May 22, 2014, 9:19

Re: Review Request 21741: Adding grouping for the sla commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/#review43983 --- Ship it! Ship It! - Mark Chu-Carroll On May 22, 2014, 9:12

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 27, 2014, 5:39 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review44003 --- Ship it! - David McLaughlin On May 23, 2014, 8:26 p.m., Bill

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 27, 2014, 6:08 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

On May 23, 2014, 6:53 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 45 https://reviews.apache.org/r/21849/diff/1/?file=589370#file589370line45 Mixed final and non-final classes in this file - converge on one? Bill Farner wrote:

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 49 https://reviews.apache.org/r/21830/diff/2/?file=590896#file590896line49 We don't inline @Inject with methods, why here? Bill Farner wrote:

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 27, 2014, 6:24 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21741: Adding grouping for the sla commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/#review44015 --- Ship it! thanks! src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review44016 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review44032 --- David, would you mind rebasing this patch? error: patch failed:

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

On May 27, 2014, 4:36 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471 Would it make sense to change it to list instead? I can imagine how the order may be helpful

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review44057 --- The rebased patch does not pass checkstyle: ./gradlew -Pq clean

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:37 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:45 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:45 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 21945: Add big job to local test fixture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-481

Re: Review Request 21945: Add big job to local test fixture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/#review44066 --- Ship it! Note: you may want to start iterating in vagrant more,

Re: Review Request 21440: Implementing parallel updater

On May 27, 2014, 6:38 p.m., Brian Wickman wrote: src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19 https://reviews.apache.org/r/21440/diff/4/?file=588632#file588632line19 I don't think we can rely upon patching or subclassing _Event (an internal

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 28, 2014, 12:20 a.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21945: Add big job to local test fixture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- (Updated May 28, 2014, 12:22 a.m.) Review request for Aurora, Maxim

Re: Review Request 21741: Adding grouping for the sla commands.

On May 27, 2014, 6:32 p.m., Joe Smith wrote: src/main/python/apache/aurora/client/api/sla.py, line 203 https://reviews.apache.org/r/21741/diff/3/?file=588596#file588596line203 In practice, we operate on only a single grouping, and it'd be kind of nice to specify this only once as

Re: Review Request 21741: Adding grouping for the sla commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/ --- (Updated May 28, 2014, 12:54 a.m.) Review request for Aurora, Joe Smith, Mark

Review Request 21951: Enable more PMD rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository:

Re: Review Request 21945: Add big job to local test fixture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/#review44085 --- Ship it! Ship It! - Maxim Khutornenko On May 28, 2014, 12:22

Review Request 21952: Dropping restart_threshold watch_secs check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21952/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-479

Re: Review Request 21945: Add big job to local test fixture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/#review44086 --- This is on master now. - Maxim Khutornenko On May 28, 2014,

Review Request 21943: Accept a job key for config loading.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21943/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Repository: