Re: Review Request 23105: Database-backed implementation of AttributeStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23105/ --- (Updated July 2, 2014, 2:05 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23105: Database-backed implementation of AttributeStore.

> On July 1, 2014, 4:55 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml, > > lines 6-14 > > > > > > Do you really need this block? I thought EnumValueMapp

Re: Review Request 23105: Database-backed implementation of AttributeStore.

> On June 27, 2014, 11:37 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler.java, > > line 31 > > > > > > You could write this without an abstract

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- (Updated July 2, 2014, 1:33 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

> On June 27, 2014, 3:10 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 17-20 > > > > > > Add UNIQUE constraint just to be defensive from the schema s

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

> On June 27, 2014, 11:56 p.m., Kevin Sweeney wrote: > > How would you feel about taking this opportunity to move the framework ID > > to a command-line flag instead. This has always been a scary thing - you > > almost always want a set, immutable framework ID generated when you > > initially

Re: Review Request 23219: Instruct quartz to use all daemon threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/#review47161 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 5:47 p.m., Bi

Review Request 23219: Instruct quartz to use all daemon threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-56

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47159 --- src/main/python/apache/thermos/observer/task_observer.py

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47152 --- Ship it! Ship It! - Kevin Burg On July 1, 2014, 9:23 p.m., Kevin

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review47149 --- Ship it! Ship It! - Brian Wickman On July 1, 2014, 9:08 p.m., Ma

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 2:23 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47146 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 2:23 p.m., Ke

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/ --- (Updated July 1, 2014, 5:08 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:07 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 22839: Add configuration plugins to default aurora client.

> On July 1, 2014, 4:55 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/cli/standalone_client.py, line 71 > > > > > > i still don't see --logging-level= This is changed in my workspace... not sure w

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- (Updated July 1, 2014, 9:02 p.m.) Review request for Aurora. Changes ---

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review47144 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

> On July 1, 2014, 8:51 p.m., Kevin Sweeney wrote: > > Hi Kevin, > > > > Can you please rebase this patch against master. > > > > Thanks, > > Kevin > > Kevin Sweeney wrote: > (You can preview the diff that will be sent with ./rbt patch or by using > the draft feature.) Sorry about that,

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

> On July 1, 2014, 1:51 p.m., Kevin Sweeney wrote: > > Hi Kevin, > > > > Can you please rebase this patch against master. > > > > Thanks, > > Kevin (You can preview the diff that will be sent with ./rbt patch or by using the draft feature.) - Kevin

Re: Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/#review47141 --- Hi Kevin, Can you please rebase this patch against master. Thanks,

Review Request 23211: Fix TaskObserver for json endpoint usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23211/ --- Review request for Aurora. Repository: aurora Description --- Fix TaskOb

Re: Review Request 23189: Export zero for racks that have no lost tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/ --- (Updated July 1, 2014, 8:39 p.m.) Review request for Aurora, David Robinson and

Re: Review Request 23189: Export zero for racks that have no lost tasks.

> On July 1, 2014, 4:10 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 140 > > > > > > s/stat/stat. Fixed. - Bill -

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated July 1, 2014, 8:33 p.m.) Review request for Aurora and Maxim Khutornen

Re: Review Request 22839: Add configuration plugins to default aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review47138 --- Ping!! Come on guys, this is getting silly! - Mark Chu-Carroll

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47137 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 1:18 p.m., Ma

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/ --- (Updated July 1, 2014, 4:18 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22948: Add a script that allows for easy selective rebuilding of components in the vagrant environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/ --- (Updated July 1, 2014, 7:36 p.m.) Review request for Aurora, Kevin Sweeney, Mar

Re: Review Request 23191: Revert "Returning a message when no tasks to kill."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23191/#review47124 --- Ship it! Ship It! - Bill Farner On July 1, 2014, 4:45 a.m., Maxi

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

> On July 1, 2014, 6:14 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 89 > > > > > > I much prefer the previous signature. Why not push the Set->String > > trans

Re: Review Request 23105: Database-backed implementation of AttributeStore.

> On July 1, 2014, 9:55 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 58-59 > > > > > > Is there a legitimate case when UNIQUE(host, slave_id) would

Re: Review Request 23180: Export a stat to track number of LOST gc_executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/#review47121 --- Build failed with this patch. Please try running ./gradlew build -P

Re: Review Request 22948: Add a script that allows for easy selective rebuilding of components in the vagrant environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/ --- (Updated July 1, 2014, 6:36 p.m.) Review request for Aurora, Kevin Sweeney, Mar

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

> On July 1, 2014, 10:55 a.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 63-64 > > > > > > This doesn't play nicely with the include() directive, which may load > > other confi

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

> On July 1, 2014, 6:14 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 89 > > > > > > I much prefer the previous signature. Why not push the Set->String > > trans

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

> On July 1, 2014, 1:55 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 63-64 > > > > > > This doesn't play nicely with the include() directive, which may load > > other config

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review47111 --- src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47106 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 23189: Export zero for racks that have no lost tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/#review47095 --- Ship it! Ship It! - David Robinson On July 1, 2014, 1:53 a.m., B

Re: Review Request 23105: Database-backed implementation of AttributeStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23105/#review47077 --- src/main/resources/org/apache/aurora/scheduler/storage/db/Attribute

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47073 --- Ship it! Ship It! - Maxim Khutornenko On July 1, 2014, 3:03 p.m.

Re: Review Request 23189: Export zero for racks that have no lost tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/#review47072 --- Ship it! src/main/java/org/apache/aurora/scheduler/TaskVars.java <

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47071 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47070 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/ --- (Updated July 1, 2014, 11:03 a.m.) Review request for Aurora, Kevin Sweeney and

Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur