On July 30, 2014, 9:36 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 692
https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line692
How would you feel about generalizing this to support more use cases,
like getting all in-progress
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24126/
---
(Updated July 31, 2014, 4:38 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49246
---
Ping Mark, Joe.
- Maxim Khutornenko
On July 29, 2014, 1:04 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49254
---
I'd also suggest the following API methods:
* Query updates based
On July 30, 2014, 9:36 p.m., David McLaughlin wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 505
https://reviews.apache.org/r/24116/diff/1/?file=646275#file646275line505
What about the shards option?
Maxim Khutornenko wrote:
I was not sure if we wanted to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49260
---
Ship it!
Ship It!
- Mark Chu-Carroll
On July 28, 2014, 9:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/
---
(Updated July 31, 2014, 6:27 p.m.)
Review request for Aurora, David McLaughlin
On July 31, 2014, 5:57 p.m., David McLaughlin wrote:
I'd also suggest the following API methods:
* Query updates based on state(s). I'm thinking of a show me all updates
in progress type view that we'd want to support.
* Query updates based on last event time. Here it's just a
On July 30, 2014, 9:36 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1262
https://reviews.apache.org/r/24116/diff/1/?file=646274#file646274line1262
Drop a Not implemented message in here and it will nicely propagate
On July 31, 2014, 6:31 p.m., David McLaughlin wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 575
https://reviews.apache.org/r/24116/diff/1-2/?file=646275#file646275line575
Can we make this a list?
Sure, that's reasonable.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/
---
(Updated July 31, 2014, 6:37 p.m.)
Review request for Aurora, David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24078/#review49259
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24160/
---
Review request for Aurora, David McLaughlin and Joe Smith.
Bugs: aurora-131
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49267
---
Ship it!
LGTM as a start - although I'm sure I'll have more
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49271
---
src/main/thrift/org/apache/aurora/gen/api.thrift
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24126/#review49272
---
src/main/python/apache/aurora/client/api/updater.py
On July 31, 2014, 12:04 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/api/updater.py, lines 234-235
https://reviews.apache.org/r/24126/diff/3/?file=646929#file646929line234
I can't find any documentation that this actually works - in theory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24160/#review49282
---
Ship it!
Ship It!
- David McLaughlin
On July 31, 2014, 6:40
On July 31, 2014, 8:06 p.m., Joe Smith wrote:
src/test/python/apache/aurora/admin/test_admin_util.py, line 17
https://reviews.apache.org/r/24019/diff/2/?file=644077#file644077line17
did we change our import order?
wasn't it
stdlib
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49285
---
Ship it!
One last thing (setting the spec) then LGTM.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/
---
(Updated July 31, 2014, 8:24 p.m.)
Review request for Aurora, Joe Smith and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24116/#review49294
---
Was drafting some UI mock ups when I spotted some more issues.
On July 31, 2014, 11:13 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 546
https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line546
I find the latest revision of the structs a bit tough to comprehend.
How about this tweak:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24078/
---
(Updated July 31, 2014, 11:52 p.m.)
Review request for Aurora, David
On July 31, 2014, 6:38 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java,
line 107
https://reviews.apache.org/r/24078/diff/1/?file=645380#file645380line107
It seems weird and error-prone to discard the reference when the
On July 31, 2014, 11:13 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 546
https://reviews.apache.org/r/24116/diff/3/?file=647049#file647049line546
I find the latest revision of the structs a bit tough to comprehend.
How about this tweak:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24169/#review49310
---
Ship it!
Ship It!
- David McLaughlin
On July 31, 2014, 11:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24173/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: aurora-607
28 matches
Mail list logo
