Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25108/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-670

Re: Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25108/#review51709 --- Ship it! Ship It! - Brian Wickman On Aug. 27, 2014, 6:40 p.m.,

Re: Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Brian Wickman
On Aug. 27, 2014, 10:32 p.m., Brian Wickman wrote: Ship It! For future reference, the protocol here now is the person providing final required ship-it (me, since I'm the only reviewer) merges the change to master if the review was published by a non-committer. I'll merge this promptly.

Re: Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Brian Wickman
On Aug. 27, 2014, 10:32 p.m., Brian Wickman wrote: Ship It! Brian Wickman wrote: For future reference, the protocol here now is the person providing final required ship-it (me, since I'm the only reviewer) merges the change to master if the review was published by a non-committer.

Re: Review Request 25108: Fix default logger in command runner.

2014-08-27 Thread Joshua Cohen
On Aug. 27, 2014, 10:32 p.m., Brian Wickman wrote: Ship It! Brian Wickman wrote: For future reference, the protocol here now is the person providing final required ship-it (me, since I'm the only reviewer) merges the change to master if the review was published by a non-committer.

Review Request 25133: Fixing race in task secondary index.

2014-08-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-667

Re: Review Request 25133: Fixing race in task secondary index.

2014-08-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25133/#review51736 ---

Re: Review Request 25133: Fixing race in task secondary index.

2014-08-27 Thread Maxim Khutornenko
On Aug. 28, 2014, 1:26 a.m., Kevin Sweeney wrote: src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java, line 435 https://reviews.apache.org/r/25133/diff/1/?file=670820#file670820line435 This looks like it adds a time dependency to our unit tests, which