Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54071 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

2014-09-19 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54068 --- Ship it! LGTM iff unit tests pass. - Bill Farner On Sept. 20, 20

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54066 --- src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdate

Review Request 25859: Fix some bugs in the Update UI

2014-09-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 19, 2014, 11:10 p.m.) Review request for Aurora and Bill Farner.

Review Request 25857: Disable updater by default in prod.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-732 https://issues.

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
gradle and intellij actually use different classpaths to begin with. The problem was just that some of the js sources were not being included in the test classpath. On Fri, Sep 19, 2014 at 2:29 PM, Zameer Manji wrote: > This happens when gradle and IntelliJ write class files to the same > direct

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 9:39 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Zameer Manji
This happens when gradle and IntelliJ write class files to the same directory. You need to do a git clean and try again. On Fri, Sep 19, 2014 at 2:24 PM, Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54031 --- waaat... ServletFilterTest.testGzipEncoding is failing via command l

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54022 --- Ship it! Ship It! - David McLaughlin On Sept. 19, 2014, 8:45 p.m

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- (Updated Sept. 19, 2014, 8:45 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote: > > Reviewboard keeps crashing when I try to go back. But I was a little > > confused as to why we still need a mapping for some of the static assets? > > > > Also, for the goal of faster development iteration on the UI - it would be > >

Re: Review Request 25812: Implementing quota checking for async job updates.

2014-09-19 Thread Maxim Khutornenko
> On Sept. 19, 2014, 7:38 p.m., Bill Farner wrote: > > Do you think it makes sense to wait for AURORA-718 before we land this? I > > think that will help simplify the algorithm: > > > > - convert each job to a resource aggregate > > - convert each job update to a possibly-negative resource agg

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 7:41 p.m., David McLaughlin wrote: > > Reviewboard keeps crashing when I try to go back. But I was a little > > confused as to why we still need a mapping for some of the static assets? > > > > Also, for the goal of faster development iteration on the UI - it would be > >

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54002 --- Reviewboard keeps crashing when I try to go back. But I was a little

Re: Review Request 25812: Implementing quota checking for async job updates.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54000 --- Do you think it makes sense to wait for AURORA-718 before we land th

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? > > Joshua Cohen wrote: > Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, > so I assumed we were ok on that front. I'll

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? > > Joshua Cohen wrote: > Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, > so I assumed we were ok on that front. I'll

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
> On Sept. 19, 2014, 6:58 p.m., Bill Farner wrote: > > Ran locally, looks like assets are no longer gzip-encoded. Does that repro > > for you? Hmm, I didn't verify that explicitly, but the gzip encoding tests passed, so I assumed we were ok on that front. I'll take a look once my vagrant imag

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review53990 --- Ran locally, looks like assets are no longer gzip-encoded. Does tha

Re: Review Request 25815: Improve performance of fetching host attributes.

2014-09-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53989 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2014, 11:42 a.m.,

Re: Review Request 25815: Improve performance of fetching host attributes.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53988 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 19, 2014, 6:42 p.

Re: Review Request 25815: Improve performance of fetching host attributes.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 6:42 p.m.) Review request for Aurora, Maxim Khutornenk

Review Request 25835: Serve HTTP assets out of a standard classpath root.

2014-09-19 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bu

Re: Review Request 25815: Improve performance of fetching host attributes.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 6:33 p.m.) Review request for Aurora, Maxim Khutornenk

Review Request 25815: Improve performance of fetching host attributes.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-73

Re: Review Request 25839: Fixing python tests.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25839/#review53975 --- Ship it! Ship It! - Bill Farner On Sept. 19, 2014, 5:58 p.m., Ma

Re: Review Request 25840: Perform a deep copy of mutable thrift objects in generated FROM_BUILDER functions.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25840/#review53973 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 19, 2014, 6:03 p.

Re: Review Request 25812: Implementing quota checking for async job updates.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 19, 2014, 6:03 p.m.) Review request for Aurora, David McLaughlin

Review Request 25840: Perform a deep copy of mutable thrift objects in generated FROM_BUILDER functions.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25840/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-729 https://i

Review Request 25839: Fixing python tests.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25839/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 25831: Allow null lock token in saveJobUpdate.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25831/ --- (Updated Sept. 19, 2014, 5:50 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25831: Allow null lock token in saveJobUpdate.

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25831/#review53969 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/JobUpda

Review Request 25831: Allow null lock token in saveJobUpdate.

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25831/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---