Re: Review Request 26232: Implementing update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/#review55186 --- src/main/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPru

Re: Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/ --- (Updated Oct. 2, 2014, 2:29 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 26239: Add usernames to scheduler update operations.

> On Oct. 1, 2014, 10:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 383 > > > > > > I'd actually opt for orNull() here. An empty string might

Re: Review Request 26239: Add usernames to scheduler update operations.

> On Oct. 2, 2014, 1:29 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, > > line 53 > > > > > > s/id/name/g Fixed. - David ---

Re: Review Request 26244: Add a doc about dedicated hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26244/ --- (Updated Oct. 2, 2014, 2:25 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 26244: Add a doc about dedicated hosts.

> On Oct. 2, 2014, 12:48 a.m., Jay Buffington wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > Before the example I think you should have a more formal definition of > > the value for the dedicated

Re: Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/#review55175 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobUpda

Re: Review Request 26232: Implementing update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/ --- (Updated Oct. 2, 2014, 1:23 a.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 140 > > > > > > I'm not sure how i feel about this. On one hand, it's nice tha

Re: Review Request 26244: Add a doc about dedicated hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26244/#review55171 --- docs/deploying-aurora-scheduler.md

Re: Review Request 26244: Add a doc about dedicated hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26244/ --- (Updated Oct. 2, 2014, 12:09 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55161 --- src/main/python/apache/aurora/executor/aurora_executor.py

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

> On Oct. 1, 2014, 11:14 p.m., Brian Wickman wrote: > > btw overall this review looks great and is much cleaner than what i was envisioning. - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55158 --- src/main/python/apache/aurora/executor/common/announcer.py

Re: Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/#review55154 --- Ship it! src/main/java/org/apache/aurora/scheduler/updater/JobUpda

Re: Review Request 26239: Add usernames to scheduler update operations.

> On Oct. 1, 2014, 6:49 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java, > > line 688 > > > > > > line break above, to visually separate the wrapped signatur

Re: Review Request 26098: Fix checkstyle and add checkstyle back to jenkins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26098/#review55150 --- ping mark - Brian Wickman On Sept. 26, 2014, 9:35 p.m., Brian Wic

Review Request 26244: Add a doc about dedicated hosts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26244/ --- Review request for Aurora. Bugs: AURORA-703 https://issues.apache.org/jira/

Re: Review Request 26137: Fix help for new update command.

> On Sept. 30, 2014, 6:32 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/client/cli/update.py, line 45 > > > > > > Could you update a test case to catch accessing these as properties to > > catch accidental r

Re: Review Request 26137: Fix help for new update command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review55125 --- Ship it! Ship It! - David McLaughlin On Sept. 29, 2014, 3:05 p.m

Re: Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/ --- (Updated Oct. 1, 2014, 7:35 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 26239: Add usernames to scheduler update operations.

> On Oct. 1, 2014, 6:49 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml, > > line 33 > > > > > > How does this present when the value is null? Empty stri

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 161 > > > > > > We also need time-based retention. How about 1 month by default? > > Maxim K

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 161 > > > > > > We also need time-based retention. How about 1 month by default? > > Maxim K

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 161 > > > > > > We also need time-based retention. How about 1 month by default? > > Maxim K

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 161 > > > > > > We also need time-based retention. How about 1 month by default? > > Maxim K

Re: Review Request 26004: Add "aurora update list" and "aurora update status" commands.

> On Sept. 24, 2014, 10:28 p.m., David McLaughlin wrote: > > What was the rationale for hiding update IDs from the user and making job > > key the parameter for update status? It's nice you can quickly see if a job > > key has an update in progress.. but what happens if you're wanting to see a

Re: Review Request 26239: Add usernames to scheduler update operations.

> On Oct. 1, 2014, 6:49 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 288 > > > > > > Since you allow an absent value, use Optional > > > >

Re: Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/#review55110 --- src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControll

Re: Review Request 26004: Add "aurora update list" and "aurora update status" commands.

> On Sept. 24, 2014, 6:28 p.m., David McLaughlin wrote: > > What was the rationale for hiding update IDs from the user and making job > > key the parameter for update status? It's nice you can quickly see if a job > > key has an update in progress.. but what happens if you're wanting to see a

Review Request 26239: Add usernames to scheduler update operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26239/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-772

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55107 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 1, 2014, 5:56 p.m.

Re: Review Request 26232: Implementing update history pruner.

> On Oct. 1, 2014, 5:42 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 161 > > > > > > We also need time-based retention. How about 1 month by default? Thought abo

Re: Review Request 26233: Add a monitoring guide.

> On Oct. 1, 2014, 10:41 a.m., Kevin Sweeney wrote: > > docs/monitoring.md, line 184 > > > > > > style point: we've rendered command-line flags with a single dash in > > other documentation. Though both are acceptable

Re: Review Request 26233: Add a monitoring guide.

> On Oct. 1, 2014, 5:41 p.m., Kevin Sweeney wrote: > > docs/monitoring.md, line 184 > > > > > > style point: we've rendered command-line flags with a single dash in > > other documentation. Though both are acceptable

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/ --- (Updated Oct. 1, 2014, 5:56 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 26233: Add a monitoring guide.

> On Oct. 1, 2014, 5:43 p.m., Maxim Khutornenko wrote: > > Would it make sense to wrap alerts into a table? E.g.: > > > > Name | Type | Description | Alerting | Triage > > -|--|-|--| The thought crossed my mind, but i don't really like using tables where the

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55091 --- Ship it! Wow. - Joe Smith On Oct. 1, 2014, 10:27 a.m., Bill Farn

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55090 --- Would it make sense to wrap alerts into a table? E.g.: Name | Type

Re: Review Request 26232: Implementing update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/#review55088 --- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55089 --- Ship it! docs/monitoring.md

Re: Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/ --- (Updated Oct. 1, 2014, 5:27 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 26232: Implementing update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26232/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-743

Review Request 26233: Add a monitoring guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-63