---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67565
---
Master (1f907da) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
(Updated Jan. 10, 2015, 12:44 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
(Updated Jan. 10, 2015, 12:42 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67548
---
Err, no-ship. This breaks aurorabuild in vagrant:
```
$
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29786/#review67549
---
Ship it!
Ship It!
- Bhuvan Arumugam
On Jan. 9, 2015, 11:22
On Jan. 9, 2015, 11:27 p.m., Bill Farner wrote:
Err, no-ship. This breaks aurorabuild in vagrant:
```
$ aurorabuild client
sending incremental file list
skipping non-regular file
src/main/python/apache/aurora/client/cli/.auroraversion
sent 44.29K bytes received 437 bytes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29786/#review67554
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 9, 2015, 3:22 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29786/#review67563
---
Ship it!
Master (1f907da) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
(Updated Jan. 10, 2015, 12:04 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29786/#review67564
---
Ship it!
Ship It!
- Maxim Khutornenko
On Jan. 9, 2015, 11:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29696/
---
(Updated Jan. 9, 2015, 6:45 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-970 and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/#review67471
---
docs/developing-aurora-client.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67480
---
Ship it!
Master (c7afcf0) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67481
---
This patch does not apply cleanly on master (c7afcf0), do you need
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/
---
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository:
On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote:
.gitignore, line 18
https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18
I don't see this in my repo - is there some more context for this
change?
Bill Farner wrote:
Ditto.
I had assumed everyone was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
(Updated Jan. 9, 2015, 7:05 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67483
---
.gitignore
https://reviews.apache.org/r/29772/#comment111527
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67488
---
src/main/python/apache/aurora/client/cli/__init__.py
On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote:
Thanks for the patch, looking good, mostly style nits below. If you haven't
seen them yet check out the
[Java](https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/styleguide.md)
and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/
---
(Updated Jan. 9, 2015, 7:38 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29776/#review67504
---
Ship it!
Master (74e5471) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29777/
---
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29696/
---
(Updated Jan. 9, 2015, 6:31 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29776/
---
Review request for Aurora.
Repository: aurora
Description
---
On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote:
.gitignore, line 18
https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18
I don't see this in my repo - is there some more context for this
change?
Ditto.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/#review67487
---
Ship it!
docs/developing-aurora-client.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 9, 2015, 7:34 p.m.)
Review request for Aurora, Jay Buffington,
On Jan. 9, 2015, 7:23 p.m., Kevin Sweeney wrote:
src/main/python/apache/aurora/client/cli/__init__.py, lines 228-230
https://reviews.apache.org/r/29770/diff/2/?file=814850#file814850line228
Can this be a module-level constant like
```py
__version__ =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29777/#review67508
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 9, 2015, 12:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review67498
---
Ship it!
Master (74e5471) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67500
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 9, 2015, 11:38 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/#review67501
---
Ship it!
Master (74e5471) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29776/#review67505
---
Master (74e5471) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67547
---
Ship it!
Ship It!
- Bill Farner
On Jan. 9, 2015, 7:38 p.m.,
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote:
docs/deploying-aurora-scheduler.md, line 155
https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155
From reading the code, it appears this additional path is needed for
them both to be available in the container.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/
---
(Updated Jan. 9, 2015, 8:50 p.m.)
Review request for Aurora and Kevin Sweeney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/
---
(Updated Jan. 9, 2015, 8:51 p.m.)
Review request for Aurora and Kevin Sweeney.
On Jan. 9, 2015, 7:23 p.m., Joshua Cohen wrote:
docs/developing-aurora-client.md, line 7
https://reviews.apache.org/r/29774/diff/1/?file=814856#file814856line7
webUI here is inconsistent with web-ui on the previous line. Either
one works, but it should be consistent.
Thanks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/#review67514
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 9, 2015, 8:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/#review67518
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 9, 2015, 12:51 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29774/#review67517
---
Ship it!
Master (74e5471) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29777/#review67515
---
Ship it!
Master (74e5471) is green with this patch.
46 matches
Mail list logo