----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review67471 -----------------------------------------------------------
docs/developing-aurora-client.md <https://reviews.apache.org/r/29117/#comment111505> s/thrift/Thrift/ docs/developing-aurora-scheduler.md <https://reviews.apache.org/r/29117/#comment111506> ditto docs/thrift-deprecation.md <https://reviews.apache.org/r/29117/#comment111511> First suggestion should be to go read this page: http://diwakergupta.github.io/thrift-missing-guide/ The page doesn't call out schema evolution, but fills in a bunch of other context. docs/thrift-deprecation.md <https://reviews.apache.org/r/29117/#comment111507> "capable of correctly handling" docs/thrift-deprecation.md <https://reviews.apache.org/r/29117/#comment111516> I have mixed feelings about this. It's fine on the wire _for specific thrift encodings_. This would, for example, break /apibeta. docs/thrift-deprecation.md <https://reviews.apache.org/r/29117/#comment111517> Lost me at "a field double". Rephrase? docs/thrift-deprecation.md <https://reviews.apache.org/r/29117/#comment111518> There should be an item about logging and signaling in API responses when deprecated fields are used. - Bill Farner On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29117/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 11:30 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-973 > https://issues.apache.org/jira/browse/AURORA-973 > > > Repository: aurora > > > Description > ------- > > This is a first stab at documenting thrift deprecation. Any > suggestions/comments are welcome. > > > Diffs > ----- > > docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 > docs/developing-aurora-scheduler.md > 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f > docs/thrift-deprecation.md PRE-CREATION > > Diff: https://reviews.apache.org/r/29117/diff/ > > > Testing > ------- > > https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md > > > Thanks, > > Maxim Khutornenko > >
