Review Request 24358: Build break fix.

src/test/python/apache/aurora/client/api:: Thanks, Maxim Khutornenko

Re: Review Request 24358: Build break fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24358/#review49675 --- On Aug. 6, 2014, 1:02 a.m., Maxim Khutornenko wrote

Review Request 24243: DB schema for the job update store.

5358b45102f53eea97a1ca709ba9375daa91a3ef Diff: https://reviews.apache.org/r/24243/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 24241: Add test coverage for new client API methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24241/#review49475 --- Ship it! Thanks! - Maxim Khutornenko On Aug. 4, 2014, 6:29 p.m

Re: Review Request 24243: DB schema for the job update store.

) - src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 5358b45102f53eea97a1ca709ba9375daa91a3ef Diff: https://reviews.apache.org/r/24243/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49492 --- On Aug. 4, 2014, 8:28 p.m., Maxim Khutornenko wrote

Re: Review Request 24243: DB schema for the job update store.

. Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 5358b45102f53eea97a1ca709ba9375daa91a3ef Diff: https://reviews.apache.org/r/24243/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 24243: DB schema for the job update store.

e1f1a95d1757d584056fe6be9c98049444f6a75b Diff: https://reviews.apache.org/r/24243/diff/ Testing --- Thanks, Maxim Khutornenko

Re: Review Request 24243: DB schema for the job update store.

--- On Aug. 4, 2014, 9:04 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- (Updated

Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

5c51175b5dd46330cfc743d234346ab3e592ec31 src/test/resources/org/apache/aurora/gen/storage.thrift.md5 61f426b2219be068d57afb003a3cff75f72b8a2e Diff: https://reviews.apache.org/r/24281/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

On Aug. 4, 2014, 11:34 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java, line 44 https://reviews.apache.org/r/24281/diff/1/?file=651305#file651305line44 Does this compile? Maxim Khutornenko wrote: Everything build and checks

Re: Review Request 24281: Initial implementation of the UpdateStore (saveUpdate).

., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/ --- (Updated Aug. 4, 2014, 11:30 p.m.) Review

Re: Review Request 24206: Add an UpdateStrategy abstraction, with two implementations.

/aurora/scheduler/updater/strategy/BatchStrategyTest.java https://reviews.apache.org/r/24206/#comment86503 typo - Maxim Khutornenko On Aug. 2, 2014, 5:20 p.m., Bill Farner wrote: --- This is an automatically generated e-mail

Re: Review Request 24116: Defining stubs for the Update APIs.

://reviews.apache.org/r/24116/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 24078: Add an InstanceUpdater to fit into rolling update coordination in the scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24078/#review49389 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 1, 2014, 9:50 p.m

Re: Review Request 24116: Defining stubs for the Update APIs.

://reviews.apache.org/r/24116/#review49387 --- On Aug. 1, 2014, 9:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116

Re: Review Request 24116: Defining stubs for the Update APIs.

://reviews.apache.org/r/24116/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 24116: Defining stubs for the Update APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49407 --- On Aug. 1, 2014, 10:53 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 24116: Defining stubs for the Update APIs.

://reviews.apache.org/r/24116/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 24198: Always log unexpected scheduler lifecycle death.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24198/#review49409 --- Ship it! +1! - Maxim Khutornenko On Aug. 2, 2014, midnight

Re: Review Request 24116: Defining stubs for the Update APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49168 --- On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

/client/api/test_updater.py 7020712c9f0b33ec29646482517768ccb13e881f Diff: https://reviews.apache.org/r/24126/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24019/#review49246 --- Ping Mark, Joe. - Maxim Khutornenko On July 29, 2014, 1:04 a.m

Re: Review Request 24116: Defining stubs for the Update APIs.

: https://reviews.apache.org/r/24116/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 24116: Defining stubs for the Update APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49254 --- On July 31, 2014, 6:27 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 24116: Defining stubs for the Update APIs.

for this: Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status) Maxim Khutornenko wrote: Not sure I like it. What should be the output if all 3 are provided? How about something like UpdateQuery instead (similar to TaskQuery)? Taken the UpdateQuery-based approach

Re: Review Request 24116: Defining stubs for the Update APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49263 --- On July 31, 2014, 6:27 p.m., Maxim Khutornenko wrote

Re: Review Request 24116: Defining stubs for the Update APIs.

/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

--- On July 29, 2014, 1:04 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24019

Re: Review Request 24019: Blocking on post drain script call.

04eecb7246f02191cd9308c747151e58b203b885 src/test/python/apache/aurora/admin/BUILD 20f744b4133ec665e476c00ff46d6b3f8e3add71 src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION Diff: https://reviews.apache.org/r/24019/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim

Review Request 24116: Defining stubs for the Update APIs.

/gen/api.thrift 54b8985971719247a5d42d8676075a51045bbb92 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 Diff: https://reviews.apache.org/r/24116/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

://reviews.apache.org/r/24126/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

== 0 - instances % batch_size != 0 Maxim Khutornenko wrote: Unfortunately, any batch_size greater than 1 would require complete refactoring of the updater unit tests and switching to python mock library. Mox does not handle out of order verification properly. I have originally

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

== 0 - instances % batch_size != 0 Maxim Khutornenko wrote: Unfortunately, any batch_size greater than 1 would require complete refactoring of the updater unit tests and switching to python mock library. Mox does not handle out of order verification properly. I have originally

Re: Review Request 24042: Add test coverage for Mname.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24042/#review48991 --- Ship it! Ship It! - Maxim Khutornenko On July 29, 2014, 5:27

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

https://reviews.apache.org/r/24059/#comment85856 I thought you wanted to drop it? - Maxim Khutornenko On July 29, 2014, 7:06 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 24019: Blocking on post drain script call.

20f744b4133ec665e476c00ff46d6b3f8e3add71 src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION Diff: https://reviews.apache.org/r/24019/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

, Maxim Khutornenko

Re: Review Request 24019: Blocking on post drain script call.

04eecb7246f02191cd9308c747151e58b203b885 src/test/python/apache/aurora/admin/BUILD 20f744b4133ec665e476c00ff46d6b3f8e3add71 src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION Diff: https://reviews.apache.org/r/24019/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim

Re: Review Request 23961: Use the DB test module in DbSchedulerStoreTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23961/#review48800 --- Ship it! Ship It! - Maxim Khutornenko On July 26, 2014, 4:27

Re: Review Request 23835: Refactoring SchedulerCore (forceTaskState)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23835/#review48668 --- Ping, Kevin. - Maxim Khutornenko On July 23, 2014, 2:33 a.m

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

/23834/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko

Re: Review Request 21440: Implementing parallel updater

2af256d65850bd86279dff4b5c53f234cf7a Diff: https://reviews.apache.org/r/21440/diff/ Testing --- ./pants src/test/python:all src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 23872: Fix problem with deschedule command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23872/#review48611 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 11:54

Re: Review Request 23244: Fixing return value in _check_sla.

/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f Diff: https://reviews.apache.org/r/23244/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 23823: Upgrade jersey version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23823/#review48413 --- Ship it! Ship It! - Maxim Khutornenko On July 22, 2014, 7:42

Re: Review Request 23244: Fixing return value in _check_sla.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48415 --- On July 22, 2014, 4:41 p.m., Maxim Khutornenko wrote

Re: Review Request 23244: Fixing return value in _check_sla.

/test_maintenance.py c4677fc2cf4cfa792823cd0660c13371ec28301f Diff: https://reviews.apache.org/r/23244/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko

Review Request 23827: Filtering out unknown hosts when starting maintenance.

/test_host_maintenance.py 34578ae82992d4b4f3c507417dd0258e7b0337bf src/test/python/apache/aurora/client/commands/test_maintenance.py 07dd3332eb5609fda875983653e6bc8e747f4ff2 Diff: https://reviews.apache.org/r/23827/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 23832: Fix constraint violation caused by slave ID change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23832/#review48464 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 1:25

Review Request 23834: Refactoring SchedulerCore (restartShards)

/BaseSchedulerCoreImplTest.java 5ec7cf395080cd593a5d5291eff835f89c65dac2 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d3ac7c7585e8fcac6d26f06f53c9101aa9787808 Diff: https://reviews.apache.org/r/23834/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

/23834/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

/scheduler/http/api/ApiBeta.java https://reviews.apache.org/r/23741/#comment84816 If you decide to keep it move it into constant? - Maxim Khutornenko On July 21, 2014, 4:59 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 23244: Fixing return value in _check_sla.

c4677fc2cf4cfa792823cd0660c13371ec28301f Diff: https://reviews.apache.org/r/23244/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

knows this, and if not, they can turn back around and query for the task IDs. Maxim Khutornenko wrote: TaskQuery allows pulling tasks from multiple jobs. Without specifying some kind of reference towards the parent job, pending reasons would be useless when pulled by anything other than

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48298 --- Ping. - Maxim Khutornenko On July 3, 2014, 1:48 a.m., Maxim

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

it. - Maxim Khutornenko On July 17, 2014, 10:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48302 --- On July 3, 2014, 1:48 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review47192 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 1:33 a.m

Re: Review Request 23105: Database-backed implementation of AttributeStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23105/#review47193 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 2:05 a.m

Re: Review Request 23144: Switching from getTasksStatus to getTasksWithoutConfigs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23144/#review47226 --- Ping Brian, Mark. - Maxim Khutornenko On June 27, 2014, 11:44

Re: Review Request 23238: Move license header to inner node in angular fragments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23238/#review47227 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 6:56 p.m

Review Request 23247: Refactoring out SchedulerCore in favor of SchedulerThriftInterface.

/thrift/ThriftIT.java 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc Diff: https://reviews.apache.org/r/23247/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko

Re: Review Request 23247: Refactoring out SchedulerCore in favor of SchedulerThriftInterface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23247/#review47243 --- On July 2, 2014, 9:46 p.m., Maxim Khutornenko wrote

Re: Review Request 23219: Instruct quartz to use all daemon threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23219/#review47271 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 12:47

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

/StorageBackfillTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2cffa74ba36e2afda3340658d6b1afd6cb50cf2c Diff: https://reviews.apache.org/r/23254/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko

Re: Review Request 23189: Export zero for racks that have no lost tasks.

https://reviews.apache.org/r/23189/#comment82674 s/stat/stat. - Maxim Khutornenko On July 1, 2014, 1:53 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189

Re: Review Request 23199: Log loaded config file at level TRANSCRIPT (aka INFO+1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47073 --- Ship it! Ship It! - Maxim Khutornenko On July 1, 2014, 3:03 p.m

Re: Review Request 23105: Database-backed implementation of AttributeStore.

/r/23105/#comment82678 Is there a legitimate case when UNIQUE(host, slave_id) would not suffice here? - Maxim Khutornenko On June 27, 2014, 3:39 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review47111 --- On July 1, 2014, 12:28 a.m., Maxim Khutornenko wrote

Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

://reviews.apache.org/r/23188/diff/ Testing --- gradle -Pq clean build Thanks, Maxim Khutornenko

Review Request 23191: Revert Returning a message when no tasks to kill.

/23191/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko

Re: Review Request 22457: Improve aurora job diff command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46866 --- Ship it! Ship It! - Maxim Khutornenko On June 27, 2014, 2:41

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review46692 --- On June 24, 2014, 11:28 p.m., Maxim Khutornenko wrote

Re: Review Request 21440: Implementing parallel updater

2af256d65850bd86279dff4b5c53f234cf7a Diff: https://reviews.apache.org/r/21440/diff/ Testing --- ./pants src/test/python:all src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Maxim Khutornenko

Re: Review Request 21440: Implementing parallel updater

= terminating_event or Event() otherwise you have a shared singleton Event object across all InstaceWatchers which is probably not what you want Maxim Khutornenko wrote: I actually always need it as it's now being used to wait on instead of _clock.sleep() (line 128). Brian Wickman

Review Request 23144: Switching from getTasksStatus to getTasksWithoutConfigs.

/apache/aurora/client/commands/test_update.py ea8e092267fd65ccd24ca1be3c04f50ba89f5236 Diff: https://reviews.apache.org/r/23144/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 22457: Improve aurora job diff command.

for testing set ordering. src/test/python/apache/aurora/client/cli/test_diff.py https://reviews.apache.org/r/22457/#comment82313 How about local has less tasks than remote test case for completeness? - Maxim Khutornenko On June 26, 2014, 11:42 a.m., Mark Chu-Carroll wrote

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

/SchedulingFilter.java https://reviews.apache.org/r/22982/#comment82323 This seems like a repeating pattern to avoid naming collision. What do we get with java version that is not provided by guava? - Maxim Khutornenko On June 25, 2014, 7:59 p.m., Bill Farner wrote

Re: Review Request 22998: Generate wrapper classes for all thrift structs in api.thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22998/#review46759 --- Ship it! Awesome! - Maxim Khutornenko On June 26, 2014, 3:44

Re: Review Request 22999: Use immutable types in AttributeStore.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/#review46761 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 4:45

Re: Review Request 23087: Fix build break in code generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23087/#review46795 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 7:59

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim

Re: Review Request 22457: Improve aurora job diff command.

On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181 I don't think it's enough to json-serialize a thrift task. This is bound to set/dict

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

/aurora/client/commands/test_maintenance.py 642c235ac820803ef70de409979552d67f47fd53 src/test/python/apache/aurora/client/commands/util.py b1822f27d2890469efefc5bfa0878f29163c167a Diff: https://reviews.apache.org/r/22842/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim

Re: Review Request 22457: Improve aurora job diff command.

On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 https://reviews.apache.org/r/22457/diff/3/?file=609592#file609592line181 I don't think it's enough to json-serialize a thrift task. This is bound to set/dict

Re: Review Request 22697: Documenting SLA stats.

--- On June 25, 2014, 4:48 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/ --- (Updated June 25

Re: Review Request 21440: Implementing parallel updater

, Maxim Khutornenko

Re: Review Request 22942: Add test coverage for ResourceCounter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22942/#review46599 --- Ship it! Ship It! - Maxim Khutornenko On June 24, 2014, 6:54

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

environment variables for this kind of thing is awful - every time I've done it, I've lived to regret it. Maxim Khutornenko wrote: How about a set of component specific provisioning scripts? That would let us do something like vagrant provision --provision-with client. More here

Re: Review Request 22697: Documenting SLA stats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22697/#review46273 --- Anyone? - Maxim Khutornenko On June 17, 2014, 9:14 p.m., Maxim

Re: Review Request 22701: Adding admin command to get locks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22701/#review46291 --- On June 17, 2014, 11:25 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 22701: Adding admin command to get locks.

/r/22701/diff/ Testing --- ./pants src/test/python/apache/aurora/client/commands:admin Thanks, Maxim Khutornenko

Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22746/#review46290 --- On June 18, 2014, 6:17 p.m., Maxim Khutornenko wrote

Re: Review Request 22849: clientv2 package should point to config-packaged

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22849/#review46348 --- Ship it! Ship It! - Maxim Khutornenko On June 20, 2014, 11:53

Review Request 22788: Dropping the Tasks killed message.

/ Testing --- gradle build Thanks, Maxim Khutornenko

Review Request 22790: Adding a getTasksStatusLight RPC to return null ExecutorConfig.

1f1f05e3110b4ba3d83dc7aebc068f4d739e9958 src/test/resources/org/apache/aurora/gen/api.thrift.md5 255b3d9c881c9291fd3d54792e7bf7385313ed9e Diff: https://reviews.apache.org/r/22790/diff/ Testing --- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko

Re: Review Request 22792: Add test coverage for MesosLog.

/{/{...} src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java https://reviews.apache.org/r/22792/#comment81524 kill \n? - Maxim Khutornenko On June 19, 2014, 9:38 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 22788: Dropping the Tasks killed message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22788/#review46225 --- On June 19, 2014, 8:45 p.m., Maxim Khutornenko wrote

Re: Review Request 22788: Dropping the Tasks killed message.

3616b3e93010c9482dc96d94bdeb42eddae41fb0 Diff: https://reviews.apache.org/r/22788/diff/ Testing --- gradle build Thanks, Maxim Khutornenko

<    4   5   6   7   8   9   10   11   12   13   >