Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Mark Chu-Carroll
At the moment, there's two end-to-end tests: test_end_to_end.sh, and test_end_to_end_v2.sh. Since this is the v1 test, it should use v1. -Mark On Wed, Sep 3, 2014 at 2:05 PM, Joe Smith yasumo...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit:

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52210 --- Ship it! examples/vagrant/upstart/mesos-slave.conf

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 6:13 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 6:33 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 1:47 a.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like to

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
On Sept. 3, 2014, 6:10 p.m., Kevin Sweeney wrote: examples/vagrant/upstart/mesos-slave.conf, line 28 https://reviews.apache.org/r/25206/diff/1/?file=672551#file672551line28 Can you add a comment explaining why this is necessary (preferably with a link to a bug where we will fix

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52235 --- Ship it! Ship It! - David Robinson On Sept. 3, 2014, 6:33 p.m.,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 8:55 p.m.) Review request for Aurora, David Robinson,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52245 --- I ran this before committing and it still fails (aurora run hangs).

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- (Updated Sept. 3, 2014, 10:40 p.m.) Review request for Aurora, David Robinson,

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52065 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 7:17

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52121 --- Ship it! src/test/sh/org/apache/aurora/e2e/test_run.sh

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e tests fixed

Review Request 25206: Fix aurora run in end to end tests.

2014-08-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/ --- Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias