On Oct. 7, 2014, 9:39 p.m., Mark Chu-Carroll wrote:
Looks good.
One note on the change description: I'm willing to bet that there is a way
to get that branch active in a test. Every single time that I've ever said
that something couldn't be tested, or that some branch couldn't be
On Oct. 7, 2014, 9:18 p.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/client/cli/test_api_from_cli.py, line 51
https://reviews.apache.org/r/26308/diff/5/?file=713862#file713862line51
Why do these need to be mocks? This would work identically using the
Thrift structures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55846
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 4, 2014, 10:55 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55858
---
Ship it!
Ship It!
- Joe Smith
On Oct. 4, 2014, 10:55 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 8, 2014, 8:57 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55712
---
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55717
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 4, 2014, 1:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55716
---
Looks good.
One note on the change description: I'm willing to bet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55570
---
Kevin, Mark - ping?
- Bill Farner
On Oct. 4, 2014, 5:55 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55349
---
Ship it!
Great catch! The is_set got lost there via multiple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55404
---
Kevin, Mark - ping?
- Bill Farner
On Oct. 3, 2014, 4:52 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55405
---
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 3, 2014, 11:25 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 3, 2014, 2:38 a.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55319
---
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 3, 2014, 4:52 a.m.)
Review request for Aurora, Kevin Sweeney and
16 matches
Mail list logo