Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57911 --- Ship it! src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-21 Thread Maxim Khutornenko
On Oct. 20, 2014, 7:35 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 1024 https://reviews.apache.org/r/26531/diff/3/?file=723031#file723031line1024 This method name reads strangely to me, since it's using heartbeat as a verb. 'Pulse' has a

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-21 Thread Maxim Khutornenko
On Oct. 20, 2014, 8 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line 109 https://reviews.apache.org/r/26531/diff/3/?file=723030#file723030line109 Other instances of delays stored in ms seem to be INT not BIGINT. Signed BIGINT

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 21, 2014, 5:58 p.m.) Review request for Aurora, David

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57410 --- Paused at the RPC name, since the rest of the change is mechanical,

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57415 --- I know I brought this up in the design discussion, so maybe this is

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-20 Thread Kevin Sweeney
On Mon, Oct 20, 2014 at 1:00 PM, Joshua Cohen jco...@twopensource.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review57415

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 16, 2014, 4:42 p.m.) Review request for Aurora, David

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 16, 2014, 4:44 p.m.) Review request for Aurora, David

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56206 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-10 Thread Bill Farner
On Oct. 10, 2014, 8:19 p.m., Joshua Cohen wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 816 https://reviews.apache.org/r/26531/diff/2/?file=717152#file717152line816 This doesn't match the doc you sent out? Shouldn't this just be one of [OK, STOP, ERRROR]?

Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56080 --- Ship it! src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 9, 2014, 11:23 p.m.) Review request for Aurora, David

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56083 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2014, 11:23

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
On Oct. 9, 2014, 11:20 p.m., David McLaughlin wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 619 https://reviews.apache.org/r/26531/diff/1/?file=717117#file717117line619 I think we decided not to do auto-resume once a job is paused due to lack of heartbeat, but I