Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Kevin Sweeney
> On Oct. 10, 2014, 2:43 p.m., Joshua Cohen wrote: > > This task is getting somewhat complex, do you think it makes sense to > > externalize it[1], rather than having build.gradle take on more and more > > logic? > > > > [1] http://www.gradle.org/docs/current/userguide/custom_tasks.html > > B

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/ --- (Updated Oct. 10, 2014, 9:51 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
> On Oct. 10, 2014, 9:43 p.m., Joshua Cohen wrote: > > This task is getting somewhat complex, do you think it makes sense to > > externalize it[1], rather than having build.gradle take on more and more > > logic? > > > > [1] http://www.gradle.org/docs/current/userguide/custom_tasks.html Thank

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/#review56228 --- Ship it! I'm fine shipping this, we can have a separate discussion

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/#review56227 --- This task is getting somewhat complex, do you think it makes sense t

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/ --- (Updated Oct. 10, 2014, 9:41 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/ --- (Updated Oct. 10, 2014, 9:33 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
> On Oct. 10, 2014, 9:20 p.m., Maxim Khutornenko wrote: > > build.gradle, line 609 > > > > > > I have no idea what is going on here... Any way to make it more > > readable? Maybe a few more dollar and at-signs would

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/#review56225 --- Ship it! build.gradle

Re: Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/ --- (Updated Oct. 10, 2014, 9:13 p.m.) Review request for Aurora, Joshua Cohen and

Review Request 26574: Handle anonymous inner classes better in per-class coverage check.

2014-10-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26574/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-822