Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-19 Thread Bill Farner
On Nov. 17, 2014, 9:48 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 108 https://reviews.apache.org/r/28103/diff/2/?file=765455#file765455line108 I'm a little worried that we have to add yet another class to represent

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61763 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 16, 2014, 10:29

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61816 --- @ReviewBot retry - David McLaughlin On Nov. 16, 2014, 10:29

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61815 --- Ship it! Ship It! - David McLaughlin On Nov. 16, 2014, 10:29

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61818 --- Ship it!

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61821 --- Master (c44aa5c) is red with this patch.

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/ --- (Updated Nov. 16, 2014, 10:29 p.m.) Review request for Aurora, David

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61690 --- Master (8741cdb) is red with this patch.

Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Repository:

Re: Review Request 28103: Simplify Preemptor code, encapsulate parameters used there and in SchedulingFilter.

2014-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28103/#review61678 --- Master (8741cdb) is red with this patch.