Review Request 24317: Initial implementation of the UpdateStore (save events).

2014-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24317/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.

Re: Review Request 24317: Initial implementation of the UpdateStore (save events).

2014-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24317/#review49614 --- Ship it! Ship It! - Bill Farner On Aug. 5, 2014, 4:16 p.m.,

Re: Review Request 24317: Initial implementation of the UpdateStore (save events).

2014-08-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24317/#review49624 --- Ship it! Ship It! - Kevin Sweeney On Aug. 5, 2014, 9:16 a.m.,

Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-612

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/#review49637 --- Ship it! lgtm. - David McLaughlin On Aug. 5, 2014, 7:41 p.m.,

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/#review49651 --- Ship it!

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/ --- (Updated Aug. 5, 2014, 10:25 p.m.) Review request for Aurora, David McLaughlin

Review Request 24357: Refactor InstanceUpdater to remove the callback interface.

2014-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24357/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository:

Review Request 24358: Build break fix.

2014-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24358/ --- Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora

Re: Review Request 24358: Build break fix.

2014-08-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24358/#review49675 --- Ship it! Sorry about that, it was a fat finger when fixing an

Re: Review Request 24358: Build break fix.

2014-08-05 Thread Maxim Khutornenko
On Aug. 6, 2014, 1:10 a.m., Brian Wickman wrote: Sorry about that, it was a fat finger when fixing an isort conflict with rbt patch. Do you have the python pre-commit hooks enabled? No worries. Yes, I do have both style and isort hooks enabled. - Maxim

Re: Review Request 24359: Fix announcer and scheduler_client tests.

2014-08-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24359/ --- (Updated Aug. 6, 2014, 1:14 a.m.) Review request for Aurora and Bill Farner.

Review Request 24360: Use 24-hour time for scheduler timestamps.

2014-08-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24360/ --- Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Bugs:

Re: Review Request 24360: Use 24-hour time for scheduler timestamps.

2014-08-05 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24360/#review49687 --- Ship it! Ship It! - David McLaughlin On Aug. 6, 2014, 1:15

Re: Review Request 24359: Fix announcer and scheduler_client tests.

2014-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24359/#review49688 --- Ship it! Ship It! - Bill Farner On Aug. 6, 2014, 1:14 a.m.,