---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25872/#review54138
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 20, 2014, 3:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24752/#review54144
---
Ship it!
Sorry for taking so long to get to this review. The code
On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 286
https://reviews.apache.org/r/25857/diff/2/?file=698339#file698339line286
I see why you went this route, but it's a precedent i'd rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25872/#review54145
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25897/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24173/
---
(Updated Sept. 22, 2014, 5:46 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/
---
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/#review54152
---
docs/committers.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25859/
---
(Updated Sept. 22, 2014, 6:24 p.m.)
Review request for Aurora, Maxim
On Sept. 20, 2014, 1:02 a.m., Maxim Khutornenko wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml,
line 275
https://reviews.apache.org/r/25859/diff/1/?file=698458#file698458line275
This will fail unit tests as is.
Thanks. Fixed.
-
On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 286
https://reviews.apache.org/r/25857/diff/2/?file=698339#file698339line286
I see why you went this route, but it's a precedent i'd rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25859/#review54159
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2014, 6:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25872/
---
(Updated Sept. 22, 2014, 6:42 p.m.)
Review request for Aurora, Kevin Sweeney
On Sept. 22, 2014, 5:34 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 180
https://reviews.apache.org/r/25872/diff/1/?file=698588#file698588line180
typo in attemptsFired
Thanks, fixed.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
---
(Updated Sept. 22, 2014, 11:52 a.m.)
Review request for Aurora, Maxim
On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java,
line 127
https://reviews.apache.org/r/25870/diff/1/?file=698533#file698533line127
What's the context around replacing MessageDigest with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54171
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2014, 6:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/#review54195
---
Ship it!
Ship It!
docs/committers.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
---
(Updated Sept. 22, 2014, 4:07 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25913/
---
Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25913/
---
(Updated Sept. 22, 2014, 11:23 p.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25914/
---
Review request for Aurora.
Repository: aurora
Description
---
use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25914/
---
(Updated Sept. 22, 2014, 4:35 p.m.)
Review request for Aurora.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25914/#review54206
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 22, 2014, 4:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25913/#review54208
---
Ship it!
Ship It!
- Bill Farner
On Sept. 22, 2014, 11:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25913/#review54209
---
Ship it!
I'm sure it's fine, but in the future it might be helpful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25914/
---
(Updated Sept. 22, 2014, 5:27 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54214
---
Ping wfarner
- Kevin Sweeney
On Sept. 22, 2014, 4:07 p.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25857/#review54216
---
Ship it!
Thanks!
- Bill Farner
On Sept. 22, 2014, 8:41 p.m.,
On Sept. 23, 2014, 12:08 a.m., Joshua Cohen wrote:
I'm sure it's fine, but in the future it might be helpful to include
screenshots comparable to those in the ticket showing the proper alignment?
Ack. Will add before/after screenshots for this type of work in the future.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/
---
(Updated Sept. 23, 2014, 12:59 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25812/#review54168
---
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54224
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25857/
---
(Updated Sept. 23, 2014, 1:12 a.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
---
(Updated Sept. 22, 2014, 6:35 p.m.)
Review request for Aurora, Maxim
On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java,
line 63
https://reviews.apache.org/r/25870/diff/3/?file=700622#file700622line63
While you're here, might as well drop @Timed to start collecting data
on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25918/#review54239
---
Ship it!
Ship It!
- Zameer Manji
On Sept. 22, 2014, 6:53 p.m.,
37 matches
Mail list logo