Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- Ship it! lgtm!

Re: Review Request 31821: Making preemptor asynchronous. Part 1 - extracting slot finder.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31821/ --- (Updated March 10, 2015, 5:26 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 1:58 a.m.) Review request for Aurora, Maxim

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76331 --- Master (ee1a13a) is red with this patch.

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76332 ---

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 13, 2015, 2:12 a.m.) Review request for Aurora, Maxim

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76243 --- Ship it! src/main/python/apache/aurora/client/api/__init__.py

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76257 --- Ship it! Ship It! - Zameer Manji On March 11, 2015, 6:27 p.m.,

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76283 --- src/test/python/apache/aurora/client/test_base.py

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/__init__.py, line 157 https://reviews.apache.org/r/31966/diff/2/?file=891871#file891871line157 Spacing seems off here and below. Fixed. On March 12, 2015, 4:23 p.m., Maxim Khutornenko

Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora

Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora

Re: Review Request 31966: Add client support for including messages when changing update state.

2015-03-12 Thread Bill Farner
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, lines 123-127 https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123 Mind sorting them alphabetically? Bill Farner wrote: Done. Spoke too soon here -

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76318 --- Master (ee1a13a) is red with this patch.

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76319 --- whoops, forgot that I added os.path.exists filtering -- will update

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76298 --- src/test/python/apache/aurora/client/test_base.py

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/ --- (Updated March 12, 2015, 11:13 p.m.) Review request for Aurora and Maxim

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76303 --- Ship it! Master (f62e0f1) is green with this patch.

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76304 --- Ship it! Thanks! - Maxim Khutornenko On March 12, 2015, 11:13

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76307 --- Thanks, it's now on master. - Maxim Khutornenko On March 12,

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76305 --- Ship it! +10 :) - Joe Smith On March 12, 2015, 4:13 p.m., David

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76322 --- @ReviewBot retry - Brian Wickman On March 13, 2015, 12:47 a.m.,

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Bill Farner
On March 13, 2015, 1:10 a.m., Brian Wickman wrote: @ReviewBot retry If you believe you have discovered a flaky test (which i assume you're asking the bot to try again), can you please file a ticket? - Bill --- This is an

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76324 --- Master (ee1a13a) is red with this patch.

Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 32014: Adding more logging into MaintenanceController.

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76327 --- Ship it! Master (ee1a13a) is green with this patch.