date:20140113


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16834/#review31691
---


Thanks. Pushed.

- Maxim Khutornenko


On Jan. 13, 2014, 11:34 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16834/
> ---
> 
> (Updated Jan. 13, 2014, 11:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-36
> https://issues.apache.org/jira/browse/AURORA-36
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping scheduler_list_job_updates from aurora_admin
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 09a646ba0593e37312f6310bc77ccd4fa917cdaa 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 15e25d5b4e8e2bb6046d456c1f2838aca04769ed 
> 
> Diff: https://reviews.apache.org/r/16834/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 16629: Client quota check (server side)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16629/
---

(Updated Jan. 14, 2014, 2:03 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments addressed.


Repository: aurora


Description
---

Part 2: Server side changes for the client quota check. 

Refactored quota manager:
- Merged QuotaFilter with QuotaManager and dropped JobFilter implementation;
- Simplified quota manager logic by splitting data retrieval and quota checking 
steps;
- Moved quota checks into write transaction to ensure consistency.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java 
99d2e4c72621708c971d25ad4e6722e0870093af 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaFilter.java 
6ab79820a0634478c0525d7fdd5a4d002ef8ea08 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
6b0645ba93e50b576f7e572d8dc06231636fade2 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaModule.java 
4a619492f6e9eb41e693353187fc3b1781bffc1f 
  src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 
24f209339f3a6f4659693986e220187bd34d2fb5 
  src/main/java/org/apache/aurora/scheduler/state/JobFilter.java 
0d84c1e2eff781e7d0250967ae6b9f9473fde3dc 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
1d450f2d2d8e747878b67bccbf3fd7d018a52d20 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
79f56052a25ba756208e747dc5d198f30f0c4900 
  
src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 
8fb51d69be6d370f9f010c797b2c1205b38a04f5 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
c1a11bdb91c5e764864324d26248d1783af8048b 
  
src/test/java/org/apache/aurora/scheduler/quota/QuotaComparisonResultTest.java 
23069b8d191f1675636bceb8c297ebcc0d88d8dc 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaFilterTest.java 
b1d878ea91c02ba87059b05877208b702d3fbcae 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
f971aa1882e5e9f4208d177566779f5dd12d70ce 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
720d0c86d8b112bf92196cbb81ece44476534654 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 91c1c24448092e1b3454844ab8074ed030383594 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
cce27a0e37452f370a3729b6b05bf0bea29f85f6 

Diff: https://reviews.apache.org/r/16629/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 16629: Client quota check (server side)



> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java, 
> > line 62
> > 
> >
> > This makes the details field kind of lame.  How about Optional 
> > to make it obvious that it can be empty?

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java, 
> > line 66
> > 
> >
> > checkNotNull, ditto below

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java, 
> > line 75
> > 
> >
> > Convention dictates that accessors start with 'get'.  Please change to 
> > getResult() and getDetails().

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 2
> > 
> >
> > Happy new year!  If you're using a file template in intellij, you can 
> > parameterize the year.

Same to you! :) Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 60
> > 
> >
> > The doc and signature aren't currently enough to explain what this 
> > method does.  i.e. from this context it's not obvious what a "task change" 
> > is.  Looks like the missing details are that the check relates to the owner 
> > prescribed within 'template', and that the check is to validate whether the 
> > role can add 'instanceCount' 'template'-sized tasks.
> > 
> > Also, s/instanceCount/instances/

Thanks, rephrased.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 89
> > 
> >
> > checkNotNull ownerRole

Both args already checked in the SchedulerThriftInterface.setQuota().


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 90
> > 
> >
> > New behavior, but while you're in here you might as well check these 
> > fields more fully (i.e. positive)

I presume we should still allow zeros there to allow partial or total 
"quota-lock" feature (i.e. when one or more specs are set to zero to prevent 
any additions/mutations)? Added ">=0" validation.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/quota/Quotas.java, line 32
> > 
> >
> > It's good to see some of these methods disappear.  It would be great to 
> > see the visibility of more of these methods reduced, or moved if there's 
> > only one caller.  This would further establish that the meaning of quota is 
> > owned by QuotaManager.  Please take a quick pass to see if any of these can 
> > be removed, moved, or reduce visibility.

Reduced and moved :) I am hesitant to completely drop this class as 
Quotas.noQuota() would still read better than QuotaManager.noQuota().


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, 
> > line 131
> > 
> >
> > This comment might lose context quickly after this review is closed.  
> > Consider instead commenting above validateTaskLimits, noting that it's 
> > performed inside the transaction to avoid a data race.

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, 
> > line 144
> > 
> >
> > Can you leave a TODO for me to remove the JobManager abstraction, and 
> > directly invoke addInstances here for non-cron jobs?

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java, 
> > line 167
> > 
> >
> > s/count/instances/ to be consistent with elsewhere?

Done.


> On Jan. 13, 2014, 10:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 623
> > 
> >
> > i find the flow easier to follow if it were right after saveQuota in 
> > the try{}.

Done.


> On Jan. 13, 2014, 10:58 p

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31685
---



src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java


thanks for fixing, this newline should actually be removed as well



src/main/java/org/apache/aurora/scheduler/http/ServletModule.java


This is a hack that i'd love to do without.  The problem is this call:

  registerJerseyEndpoint(
  "/scheduler/",
  SchedulerzRole.class,
  SchedulerzJob.class);

The implementation of registerJerseyEndpoint no longer fits, which causes 
/scheduler/ to be picked up by GuiceContainer.  The simplest path forward is 
probably to install SchedulerzRole and SchedulerzJob in a separate helper 
function that doesn't create this pattern overlap.



- Bill Farner


On Jan. 13, 2014, 11:58 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> ---
> 
> (Updated Jan. 13, 2014, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented new Scheduler home page using AngularJS. The UI queries the 
> backend using the thrift end point. This diff sets the basic foundation for 
> the page. Sending this out to get some early feedback and to keep the future 
> diffs small.
> 
> The URLs in the new UI will redirect to the scheduler role pages. 
> 
> Dropped the option to select number of results to be shown to simplify the 
> interface. Now defaulting to 25 results per page.
> 
> Cleaned up the UI to make it more light weight.
> 
> Added a mock service to render dummy data on the page. Currently, this mock 
> service is manually wired during testing. Will created an isolated scheduler 
> page once we have a single page app.
> 
> Updated build.gradle to generate thrift JS client. 
> 
> Installed Angular and smart-table from bower. Added thrift.js file to make 
> the calls to the backend. Will migrate to angular-thrift for more robust 
> implementation in coming diffs.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.map 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION 
>   3rdparty/javascript/thrift.js PRE-CREATION 
>   build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
> d775edeae93d61850a8619a6675699560e941277 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 
> 263591a1a387731be11936a7ad244cdc81b40a10 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> a3faf6be3635ec4f985867dd4598ad434a985fb7 
>   src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 
> 5e540f303ffa3d057dea564b394a29508b03c03c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16528/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> 
> Tested the UI using the isolated scheduler. 
> 
> 
> File Attachments
> 
> 
> Home p

Re: Review Request 16615: Client command hooks doc



> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.
> 
> Tobias Weingartner wrote:
> I'm ok with that.
> 
> Tom Galloway wrote:
> Yeah, I'm sorry about that. I actually did submit all the docs 
> separately, and for some reason git/apache combined it into one massive lump.
> 
> Bill Farner wrote:
> I'll be okay without 100% consensus, but i would like to clean up some of 
> the formatting issues to avoid proliferation of those.  Specifically, the 
> trailing newlines and trailing whitespace.
> 
> Tom Galloway wrote:
> Bill, I think I fixed those, except where, as replied to your review, 
> it's a Markdown thing (specifically, two spaces at the end of a line is a 
> specific Markdown format thing).

Thanks for setting me straight on that.  Given that we've already crossed the 
threshold of not being HTML-free, i'd prefer  over trailing whitespace.  
Regarding your fixes, can you please send the updated diff so we can see the 
changes?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
---

(Updated Jan. 13, 2014, 11:58 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Added a redirect filter to fix "/scheduler/" 404. Addressed code review nits.


Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33


Repository: aurora


Description
---

Implemented new Scheduler home page using AngularJS. The UI queries the backend 
using the thrift end point. This diff sets the basic foundation for the page. 
Sending this out to get some early feedback and to keep the future diffs small.

The URLs in the new UI will redirect to the scheduler role pages. 

Dropped the option to select number of results to be shown to simplify the 
interface. Now defaulting to 25 results per page.

Cleaned up the UI to make it more light weight.

Added a mock service to render dummy data on the page. Currently, this mock 
service is manually wired during testing. Will created an isolated scheduler 
page once we have a single page app.

Updated build.gradle to generate thrift JS client. 

Installed Angular and smart-table from bower. Added thrift.js file to make the 
calls to the backend. Will migrate to angular-thrift for more robust 
implementation in coming diffs.


Diffs (updated)
-

  3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION 
  3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION 
  3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION 
  3rdparty/javascript/thrift.js PRE-CREATION 
  build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
d775edeae93d61850a8619a6675699560e941277 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 
263591a1a387731be11936a7ad244cdc81b40a10 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
a3faf6be3635ec4f985867dd4598ad434a985fb7 
  src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 
5e540f303ffa3d057dea564b394a29508b03c03c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
PRE-CREATION 

Diff: https://reviews.apache.org/r/16528/diff/


Testing
---

gradle clean build

Tested the UI using the isolated scheduler. 


File Attachments


Home page
  
https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png


Thanks,

Suman Karumuri

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/
---

(Updated Jan. 13, 2014, 11:54 p.m.)


Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim Khutornenko.


Bugs: AURORA-23
https://issues.apache.org/jira/browse/AURORA-23


Repository: aurora


Description
---

When rescheduling a task, send it to the THROTTLED state if it has been 
penalized for flapping.

Changes specific to the issue:
- Introduced TaskThrottler[Test], which initiates THROTTLED->PENDING transitions
- RescheduleCalculator methods return a delay rather than a timestamp, for 
inclusion in transition audit messages
- Removed StorageBackfillTest, which was only testing rewriting the THROTTLED 
state for backwards compatibility

There's also a fair amount of code cleanup going on in this review:

- A unit test for RescheduleCalculator was pulled out of TaskSchedulerTest test 
cases (per TODO)
- Introduced Tasks.getLatestEvent, which was independently implemented in 
several places
- Removed unused TaskRescheduled pubsub event
- Removed REVERSE_CHRON_COMPARATOR from SchedulerzJob, which is === 
Tasks.LATEST_ACTIVITY.reverse()
- Added a batch changeState helper function in BaseSchedulerCoreImplTest for 
more concise calling code


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
6be658d7e90f59c63e6895df3917a7869b4045cc 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
0afbef950151e8cd1e865d93b53ffa4ad92f8eeb 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
0265bf941814ab4b6425ecf4dc9672dfa361e94f 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 
1a008745ac8807edd894269722fa2ae989b70bbd 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
b50c625092812f84b3f0a9e790bbe7011a60c1ce 
  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
569e8c32643acdce35062d283c7411e026b86c8d 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
59e18eaefc024b7493b4b2aa3757b831022236f3 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
07a648fad0ea55bdb126b6d8d2ed15754430f556 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
b6dd5379481423051b9243ad0dbfae7b057173f4 
  src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
d0f88e5b16b8e4af299cd1d19f806b1a6c53eab4 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
69374ca706ff7ab6267c37021612cefb74df0bc0 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
33c70df70713427c186081dd1815dd4e8fe14fa8 
  
src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9698f283c04197039d22cd38220a1dda448bdcf7 
  src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
720d0c86d8b112bf92196cbb81ece44476534654 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
b17b983f66ce0ac1ef90b716a28813a505322b17 
  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
e89e60afc107b299d572a07140d010040b2c7545 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
724188bfa037caccaf91cf57d82de1777ab5de8e 

Diff: https://reviews.apache.org/r/16740/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Jonathan Boulle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31678
---

Ship it!



src/main/python/apache/aurora/client/cli/context.py


[] is superfluous fwiw



src/main/python/apache/aurora/client/cli/jobs.py


s/ommit/omit/



src/test/python/apache/aurora/client/cli/test_status.py


?


- Jonathan Boulle


On Jan. 13, 2014, 10:28 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> ---
> 
> (Updated Jan. 13, 2014, 10:28 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/apache/aurora/client/options.py 
> af56351eed21805f09bfe50cb91745d58b665627 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
> already tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.



> On Jan. 13, 2014, 11:42 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 237
> > 
> >
> > Can just call install(...) iirc.

Hah!  Thanks for catching, looks like this contrived block has gone through a 
few copy-paste iterations :-)  Removed them all.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31419
---


On Jan. 9, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16740/
> ---
> 
> (Updated Jan. 9, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-23
> https://issues.apache.org/jira/browse/AURORA-23
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> When rescheduling a task, send it to the THROTTLED state if it has been 
> penalized for flapping.
> 
> Changes specific to the issue:
> - Introduced TaskThrottler[Test], which initiates THROTTLED->PENDING 
> transitions
> - RescheduleCalculator methods return a delay rather than a timestamp, for 
> inclusion in transition audit messages
> - Removed StorageBackfillTest, which was only testing rewriting the THROTTLED 
> state for backwards compatibility
> 
> There's also a fair amount of code cleanup going on in this review:
> 
> - A unit test for RescheduleCalculator was pulled out of TaskSchedulerTest 
> test cases (per TODO)
> - Introduced Tasks.getLatestEvent, which was independently implemented in 
> several places
> - Removed unused TaskRescheduled pubsub event
> - Removed REVERSE_CHRON_COMPARATOR from SchedulerzJob, which is === 
> Tasks.LATEST_ACTIVITY.reverse()
> - Added a batch changeState helper function in BaseSchedulerCoreImplTest for 
> more concise calling code
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 106fbb3e6e09518df3b2d687a0a85e4ecae0e72f 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 0afbef950151e8cd1e865d93b53ffa4ad92f8eeb 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> 0265bf941814ab4b6425ecf4dc9672dfa361e94f 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 
> 1a008745ac8807edd894269722fa2ae989b70bbd 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> b50c625092812f84b3f0a9e790bbe7011a60c1ce 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 569e8c32643acdce35062d283c7411e026b86c8d 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 59e18eaefc024b7493b4b2aa3757b831022236f3 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
> 07a648fad0ea55bdb126b6d8d2ed15754430f556 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> b6dd5379481423051b9243ad0dbfae7b057173f4 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> d0f88e5b16b8e4af299cd1d19f806b1a6c53eab4 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 69374ca706ff7ab6267c37021612cefb74df0bc0 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 480b8f472bcfbe547a91c41638250350a0110334 
>   
> src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9698f283c04197039d22cd38220a1dda448bdcf7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  720d0c86d8b112bf92196cbb81ece44476534654 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> b17b983f66ce0ac1ef90b716a28813a505322b17 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> e89e60afc107b299d572a07140d010040b2c7545 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 724188bfa037caccaf91cf57d82de1777ab5de8e 
> 
> Diff: https://reviews.apache.org/r/16740/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.

2014-01-13 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31419
---

Ship it!


Shipit was lost in the mail...


src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java


Can just call install(...) iirc.


- Kevin Sweeney


On Jan. 9, 2014, 2:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16740/
> ---
> 
> (Updated Jan. 9, 2014, 2:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-23
> https://issues.apache.org/jira/browse/AURORA-23
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> When rescheduling a task, send it to the THROTTLED state if it has been 
> penalized for flapping.
> 
> Changes specific to the issue:
> - Introduced TaskThrottler[Test], which initiates THROTTLED->PENDING 
> transitions
> - RescheduleCalculator methods return a delay rather than a timestamp, for 
> inclusion in transition audit messages
> - Removed StorageBackfillTest, which was only testing rewriting the THROTTLED 
> state for backwards compatibility
> 
> There's also a fair amount of code cleanup going on in this review:
> 
> - A unit test for RescheduleCalculator was pulled out of TaskSchedulerTest 
> test cases (per TODO)
> - Introduced Tasks.getLatestEvent, which was independently implemented in 
> several places
> - Removed unused TaskRescheduled pubsub event
> - Removed REVERSE_CHRON_COMPARATOR from SchedulerzJob, which is === 
> Tasks.LATEST_ACTIVITY.reverse()
> - Added a batch changeState helper function in BaseSchedulerCoreImplTest for 
> more concise calling code
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 106fbb3e6e09518df3b2d687a0a85e4ecae0e72f 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 0afbef950151e8cd1e865d93b53ffa4ad92f8eeb 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> 0265bf941814ab4b6425ecf4dc9672dfa361e94f 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 
> 1a008745ac8807edd894269722fa2ae989b70bbd 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> b50c625092812f84b3f0a9e790bbe7011a60c1ce 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 569e8c32643acdce35062d283c7411e026b86c8d 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 59e18eaefc024b7493b4b2aa3757b831022236f3 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
> 07a648fad0ea55bdb126b6d8d2ed15754430f556 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> b6dd5379481423051b9243ad0dbfae7b057173f4 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> d0f88e5b16b8e4af299cd1d19f806b1a6c53eab4 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 69374ca706ff7ab6267c37021612cefb74df0bc0 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 480b8f472bcfbe547a91c41638250350a0110334 
>   
> src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9698f283c04197039d22cd38220a1dda448bdcf7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  720d0c86d8b112bf92196cbb81ece44476534654 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> b17b983f66ce0ac1ef90b716a28813a505322b17 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> e89e60afc107b299d572a07140d010040b2c7545 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 724188bfa037caccaf91cf57d82de1777ab5de8e 
> 
> Diff: https://reviews.apache.org/r/16740/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16834/#review31676
---

Ship it!


Woohoo!

- Bill Farner


On Jan. 13, 2014, 11:34 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16834/
> ---
> 
> (Updated Jan. 13, 2014, 11:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-36
> https://issues.apache.org/jira/browse/AURORA-36
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping scheduler_list_job_updates from aurora_admin
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 09a646ba0593e37312f6310bc77ccd4fa917cdaa 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 15e25d5b4e8e2bb6046d456c1f2838aca04769ed 
> 
> Diff: https://reviews.apache.org/r/16834/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin

2014-01-13 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16834/#review31675
---

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 13, 2014, 3:34 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16834/
> ---
> 
> (Updated Jan. 13, 2014, 3:34 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-36
> https://issues.apache.org/jira/browse/AURORA-36
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping scheduler_list_job_updates from aurora_admin
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 09a646ba0593e37312f6310bc77ccd4fa917cdaa 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 15e25d5b4e8e2bb6046d456c1f2838aca04769ed 
> 
> Diff: https://reviews.apache.org/r/16834/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16834/
---

Review request for Aurora.


Bugs: AURORA-36
https://issues.apache.org/jira/browse/AURORA-36


Repository: aurora


Description
---

Dropping scheduler_list_job_updates from aurora_admin


Diffs
-

  src/main/python/apache/aurora/client/api/__init__.py 
09a646ba0593e37312f6310bc77ccd4fa917cdaa 
  src/main/python/apache/aurora/client/commands/admin.py 
15e25d5b4e8e2bb6046d456c1f2838aca04769ed 

Diff: https://reviews.apache.org/r/16834/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 16767: Begin cleanup of StateManager interface by removing state change via Query.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16767/
---

(Updated Jan. 13, 2014, 11:35 p.m.)


Review request for Aurora.


Bugs: AURORA-27
https://issues.apache.org/jira/browse/AURORA-27


Repository: aurora


Description
---

State changes via a broad query is a rarely-used feature, and probably usually 
not a good idea.  The query-based API was useful because it sometimes saves 
code at the call site, but the big downside is that it makes it more difficult 
for StateManager to perform course-correcting operations.  The test case added 
to StateManagerImplTest illustrates a now-fixed regression that could 
contribute to state drift between the scheduler and the outside world.

Additionally, this API change is me working my way towards removing a bunch of 
the (hopefully-unnecessary) complexity that exists in StateManagerImpl and 
TaskStateMachine.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
7e180ac1bb2cf2f7b07f25441614027e15b75c8b 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
96c76ba1b72853ae16399813bfac6c8db5aaf1a9 
  src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 
9f14a995e6e60098659542624b9ee951eea912ed 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
3dd2271004a26a597989574527459e887fba44e4 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
b89d9905398feaaf7f1329409d8c27edc9f0d49a 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
1d450f2d2d8e747878b67bccbf3fd7d018a52d20 
  src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
045165da2fdec7f2d4b24402901752d1c6b3976a 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
b6dd5379481423051b9243ad0dbfae7b057173f4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
c1a11bdb91c5e764864324d26248d1783af8048b 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
bba1b722ae9c308e3767da2c396b86d05531c65a 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9698f283c04197039d22cd38220a1dda448bdcf7 
  src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 
023905b6e6fe0a7ff095a2b37b9f73f9801a8123 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
720d0c86d8b112bf92196cbb81ece44476534654 
  
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
 c0addd6670009b1ed924f891074b4971431a6378 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
b17b983f66ce0ac1ef90b716a28813a505322b17 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 91c1c24448092e1b3454844ab8074ed030383594 

Diff: https://reviews.apache.org/r/16767/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Tom Galloway



> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.
> 
> Tobias Weingartner wrote:
> I'm ok with that.
> 
> Tom Galloway wrote:
> Yeah, I'm sorry about that. I actually did submit all the docs 
> separately, and for some reason git/apache combined it into one massive lump.
> 
> Bill Farner wrote:
> I'll be okay without 100% consensus, but i would like to clean up some of 
> the formatting issues to avoid proliferation of those.  Specifically, the 
> trailing newlines and trailing whitespace.

Bill, I think I fixed those, except where, as replied to your review, it's a 
Markdown thing (specifically, two spaces at the end of a line is a specific 
Markdown format thing).


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16767: Begin cleanup of StateManager interface by removing state change via Query.



> On Jan. 10, 2014, 9:01 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/state/StateManager.java, line 40
> > 
> >
> > A bit of explanation of what "cas" stand for would not hurt here as 
> > it's not obvious from the description or implementation why it's used.

Thanks, done.


> On Jan. 10, 2014, 9:01 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 
> > 80
> > 
> >
> > Unfinished TODO comment?

Heh, yep.  Thanks, fixed.


> On Jan. 10, 2014, 9:01 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, line 
> > 239
> > 
> >
> > Would task ever be null here?

The task is null if it doesn't exist in storage, i.e. if the master tells us 
that 'task-abc' is RUNNING.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16767/#review31538
---


On Jan. 9, 2014, 10:40 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16767/
> ---
> 
> (Updated Jan. 9, 2014, 10:40 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-27
> https://issues.apache.org/jira/browse/AURORA-27
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> State changes via a broad query is a rarely-used feature, and probably 
> usually not a good idea.  The query-based API was useful because it sometimes 
> saves code at the call site, but the big downside is that it makes it more 
> difficult for StateManager to perform course-correcting operations.  The test 
> case added to StateManagerImplTest illustrates a now-fixed regression that 
> could contribute to state drift between the scheduler and the outside world.
> 
> Additionally, this API change is me working my way towards removing a bunch 
> of the (hopefully-unnecessary) complexity that exists in StateManagerImpl and 
> TaskStateMachine.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 7e180ac1bb2cf2f7b07f25441614027e15b75c8b 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 96c76ba1b72853ae16399813bfac6c8db5aaf1a9 
>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 
> 9f14a995e6e60098659542624b9ee951eea912ed 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 3dd2271004a26a597989574527459e887fba44e4 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> b89d9905398feaaf7f1329409d8c27edc9f0d49a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 1d450f2d2d8e747878b67bccbf3fd7d018a52d20 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> 045165da2fdec7f2d4b24402901752d1c6b3976a 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> b6dd5379481423051b9243ad0dbfae7b057173f4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  c1a11bdb91c5e764864324d26248d1783af8048b 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> bba1b722ae9c308e3767da2c396b86d05531c65a 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9698f283c04197039d22cd38220a1dda448bdcf7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 
> 023905b6e6fe0a7ff095a2b37b9f73f9801a8123 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  720d0c86d8b112bf92196cbb81ece44476534654 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  c0addd6670009b1ed924f891074b4971431a6378 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> b17b983f66ce0ac1ef90b716a28813a505322b17 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  91c1c24448092e1b3454844ab8074ed030383594 
> 
> Diff: https://reviews.apache.org/r/16767/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 16740: When rescheduling a task, send it to the THROTTLED state if it has been penalized for flapping.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16740/#review31667
---


Post-weekend ping.  Waiting on Kevin and Suman here.

- Bill Farner


On Jan. 9, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16740/
> ---
> 
> (Updated Jan. 9, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Suman Karumuri, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-23
> https://issues.apache.org/jira/browse/AURORA-23
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> When rescheduling a task, send it to the THROTTLED state if it has been 
> penalized for flapping.
> 
> Changes specific to the issue:
> - Introduced TaskThrottler[Test], which initiates THROTTLED->PENDING 
> transitions
> - RescheduleCalculator methods return a delay rather than a timestamp, for 
> inclusion in transition audit messages
> - Removed StorageBackfillTest, which was only testing rewriting the THROTTLED 
> state for backwards compatibility
> 
> There's also a fair amount of code cleanup going on in this review:
> 
> - A unit test for RescheduleCalculator was pulled out of TaskSchedulerTest 
> test cases (per TODO)
> - Introduced Tasks.getLatestEvent, which was independently implemented in 
> several places
> - Removed unused TaskRescheduled pubsub event
> - Removed REVERSE_CHRON_COMPARATOR from SchedulerzJob, which is === 
> Tasks.LATEST_ACTIVITY.reverse()
> - Added a batch changeState helper function in BaseSchedulerCoreImplTest for 
> more concise calling code
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 106fbb3e6e09518df3b2d687a0a85e4ecae0e72f 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 0afbef950151e8cd1e865d93b53ffa4ad92f8eeb 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> 0265bf941814ab4b6425ecf4dc9672dfa361e94f 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroup.java 
> 1a008745ac8807edd894269722fa2ae989b70bbd 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> b50c625092812f84b3f0a9e790bbe7011a60c1ce 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 569e8c32643acdce35062d283c7411e026b86c8d 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 59e18eaefc024b7493b4b2aa3757b831022236f3 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
> 07a648fad0ea55bdb126b6d8d2ed15754430f556 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> b6dd5379481423051b9243ad0dbfae7b057173f4 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> d0f88e5b16b8e4af299cd1d19f806b1a6c53eab4 
>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
> 69374ca706ff7ab6267c37021612cefb74df0bc0 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 480b8f472bcfbe547a91c41638250350a0110334 
>   
> src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java
>  PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9698f283c04197039d22cd38220a1dda448bdcf7 
>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  720d0c86d8b112bf92196cbb81ece44476534654 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> b17b983f66ce0ac1ef90b716a28813a505322b17 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> e89e60afc107b299d572a07140d010040b2c7545 
>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
> 724188bfa037caccaf91cf57d82de1777ab5de8e 
> 
> Diff: https://reviews.apache.org/r/16740/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 16629: Client quota check (server side)

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16629/#review31664
---

src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java

This makes the details field kind of lame.  How about Optional to 
make it obvious that it can be empty?

src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java

checkNotNull, ditto below

src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java

Convention dictates that accessors start with 'get'.  Please change to 
getResult() and getDetails().

src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java

Happy new year!  If you're using a file template in intellij, you can 
parameterize the year.

src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

The doc and signature aren't currently enough to explain what this method 
does.  i.e. from this context it's not obvious what a "task change" is.  Looks 
like the missing details are that the check relates to the owner prescribed 
within 'template', and that the check is to validate whether the role can add 
'instanceCount' 'template'-sized tasks.

Also, s/instanceCount/instances/

src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

checkNotNull ownerRole

src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java

New behavior, but while you're in here you might as well check these fields 
more fully (i.e. positive)

src/main/java/org/apache/aurora/scheduler/quota/Quotas.java

It's good to see some of these methods disappear.  It would be great to see 
the visibility of more of these methods reduced, or moved if there's only one 
caller.  This would further establish that the meaning of quota is owned by 
QuotaManager.  Please take a quick pass to see if any of these can be removed, 
moved, or reduce visibility.

src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java

This comment might lose context quickly after this review is closed.  
Consider instead commenting above validateTaskLimits, noting that it's 
performed inside the transaction to avoid a data race.

src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java

Can you leave a TODO for me to remove the JobManager abstraction, and 
directly invoke addInstances here for non-cron jobs?

src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java

s/count/instances/ to be consistent with elsewhere?

src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java

i find the flow easier to follow if it were right after saveQuota in the 
try{}.

src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java

Isn't it easier to just construct a fake value here, and avoid the stub?  I 
would find that easier to follow, anyhow, given that the class is purely a 
container.

- Bill Farner

On Jan. 10, 2014, 9:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16629/
> ---
> 
> (Updated Jan. 10, 2014, 9:23 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 2: Server side changes for the client quota check. 
> 
> Refactored quota manager:
> - Merged QuotaFilter with QuotaManager and dropped JobFilter implementation;
> - Simplified quota manager logic by splitting data retrieval and quota 
> checking steps;
> - Moved quota checks into write transaction to ensure consistency.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> cef0ff28bb0c0e08c5efaa1ed326f66bc9ffa5d9 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaComparisonResult.java 
> 99d2e4c72621708c971d25ad4e6722e0870093af 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaFilter.java 
> 6ab79820a0634478c0525d7fdd5a4d002ef8ea08 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java PRE-CREATION 
>   src/main/java/org/a

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
---

(Updated Jan. 13, 2014, 5:28 p.m.)


Review request for Aurora, Jonathan Boulle and Brian Wickman.


Changes
---

Addressed latest round of reviews.


Repository: aurora


Description
---

Implemented client v2 versions of the diff and inspect verbs.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
2c08cf985a3ad9126a544596f895540524af865c 
  src/main/python/apache/aurora/client/cli/context.py 
c50f1a15847f5374a30d6bc93915123d8471e4aa 
  src/main/python/apache/aurora/client/cli/jobs.py 
b789361313e279ac8398a92a46ec724c09fb4513 
  src/main/python/apache/aurora/client/cli/options.py 
80fabb93945f38011b1e9c64ed20f8035ec146fa 
  src/main/python/apache/aurora/client/options.py 
af56351eed21805f09bfe50cb91745d58b665627 
  src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
9528eed70e76431f720c4a26651ae0729903288c 
  src/test/python/apache/aurora/client/cli/test_create.py 
df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
  src/test/python/apache/aurora/client/cli/test_kill.py 
75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
  src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/util.py 
c6d38304fb8ac89b9a175d8c20438a8831f784df 
  src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16423/diff/


Testing
---

Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
already tested.


Thanks,

Mark Chu-Carroll

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31663
---



src/main/python/apache/aurora/client/cli/jobs.py


Could, but then it would get created even when users aren't running diff.


- Mark Chu-Carroll


On Jan. 13, 2014, 10:02 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> ---
> 
> (Updated Jan. 13, 2014, 10:02 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/apache/aurora/client/options.py 
> af56351eed21805f09bfe50cb91745d58b665627 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
> already tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Jonathan Boulle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31650
---



src/main/python/apache/aurora/client/cli/__init__.py


kill



src/main/python/apache/aurora/client/cli/context.py


s/file/file./



src/main/python/apache/aurora/client/cli/context.py


%s/job_key/jobkey/g



src/main/python/apache/aurora/client/cli/context.py


result.extend(...)



src/main/python/apache/aurora/client/cli/context.py


kill



src/main/python/apache/aurora/client/cli/context.py


return resp or []



src/main/python/apache/aurora/client/cli/jobs.py


no help()?



src/main/python/apache/aurora/client/cli/jobs.py


no help()? 



src/main/python/apache/aurora/client/cli/jobs.py


could this just live on the class?



src/main/python/apache/aurora/client/cli/jobs.py


s/specifying/setting/



src/test/python/apache/aurora/client/cli/util.py


hm, remove?



src/test/python/twitter/aurora/client/cli/BUILD


:/



src/test/python/twitter/aurora/client/cli/test_diff.py


nit: could we use a more generic username for all the tests?


- Jonathan Boulle


On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> ---
> 
> (Updated Jan. 13, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/apache/aurora/client/options.py 
> af56351eed21805f09bfe50cb91745d58b665627 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
> already tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16615: Client command hooks doc



> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.
> 
> Tobias Weingartner wrote:
> I'm ok with that.
> 
> Tom Galloway wrote:
> Yeah, I'm sorry about that. I actually did submit all the docs 
> separately, and for some reason git/apache combined it into one massive lump.

I'll be okay without 100% consensus, but i would like to clean up some of the 
formatting issues to avoid proliferation of those.  Specifically, the trailing 
newlines and trailing whitespace.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16306: "job status" command, with wildcard support.

2014-01-13 Thread Jonathan Boulle



> On Jan. 13, 2014, 3:24 p.m., Mark Chu-Carroll wrote:
> > Ping?

er, is this totally subsumed by 
https://reviews.apache.org/r/16423/diff/#index_header , or am I missing 
something?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
---


On Jan. 9, 2014, 10:29 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> ---
> 
> (Updated Jan. 9, 2014, 10:29 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added an implementation of the "status" verb for jobs. This is the first 
> command to use the new job wildcards, so there's a bunch of infrastructure 
> added to the Context to support it.
> 
> This also includes unit tests of the new command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16306/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Tom Galloway



> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.
> 
> Tobias Weingartner wrote:
> I'm ok with that.

Yeah, I'm sorry about that. I actually did submit all the docs separately, and 
for some reason git/apache combined it into one massive lump.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Tobias Weingartner



> On Jan. 13, 2014, 7:27 p.m., Kevin Sweeney wrote:
> > In the interest of avoiding a proliferation of broken documentation 
> > links/links to drafts, would everyone be all right with committing this 
> > as-is and continuing to iterate in later reviews? Normally I prefer to 
> > review small changes in bite-sized chunks but this case is more like an 
> > initial code drop and it fills a very real gap in public Aurora 
> > documentation.

I'm ok with that.


- Tobias


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


On Jan. 3, 2014, 7:19 p.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 7:19 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16615/#review31636
---


In the interest of avoiding a proliferation of broken documentation links/links 
to drafts, would everyone be all right with committing this as-is and 
continuing to iterate in later reviews? Normally I prefer to review small 
changes in bite-sized chunks but this case is more like an initial code drop 
and it fills a very real gap in public Aurora documentation.

- Kevin Sweeney


On Jan. 3, 2014, 11:19 a.m., Tom Galloway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16615/
> ---
> 
> (Updated Jan. 3, 2014, 11:19 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Client command hooks doc
> 
> 
> Resource isolation doc
> 
> 
> Configuration tutorial
> 
> 
> User guide doc
> 
> 
> Configuration file reference
> 
> 
> Tutorial doc
> 
> 
> Client commands doc
> 
> 
> User doc overview
> 
> 
> Doc images
> 
> 
> Adding initial image in images directory
> 
> 
> Diffs
> -
> 
>   docs/README.md PRE-CREATION 
>   docs/clientcommands.md PRE-CREATION 
>   docs/configurationreference.md PRE-CREATION 
>   docs/configurationtutorial.md PRE-CREATION 
>   docs/hooks.md PRE-CREATION 
>   docs/images/CPUavailability.png PRE-CREATION 
>   docs/images/HelloWorldJob.png PRE-CREATION 
>   docs/images/RoleJobs.png PRE-CREATION 
>   docs/images/ScheduledJobs.png PRE-CREATION 
>   docs/images/TaskBreakdown.png PRE-CREATION 
>   docs/images/aurora_hierarchy.png PRE-CREATION 
>   docs/images/killedtask.png PRE-CREATION 
>   docs/images/lifeofatask.png PRE-CREATION 
>   docs/images/runningtask.png PRE-CREATION 
>   docs/images/stderr.png PRE-CREATION 
>   docs/images/stdout.png PRE-CREATION 
>   docs/resourceisolation.md PRE-CREATION 
>   docs/tutorial.md PRE-CREATION 
>   docs/userguide.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16615/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tom Galloway
> 
>

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/
---

(Updated Jan. 13, 2014, 7:32 p.m.)

Review request for Aurora and Bill Farner.

Bugs: AURORA-33
https://issues.apache.org/jira/browse/AURORA-33

Repository: aurora

Description
---

Implemented new Scheduler home page using AngularJS. The UI queries the backend
using the thrift end point. This diff sets the basic foundation for the page.
Sending this out to get some early feedback and to keep the future diffs small.

The URLs in the new UI will redirect to the scheduler role pages.

Dropped the option to select number of results to be shown to simplify the
interface. Now defaulting to 25 results per page.

Cleaned up the UI to make it more light weight.

Added a mock service to render dummy data on the page. Currently, this mock
service is manually wired during testing. Will created an isolated scheduler
page once we have a single page app.

Updated build.gradle to generate thrift JS client.

Installed Angular and smart-table from bower. Added thrift.js file to make the
calls to the backend. Will migrate to angular-thrift for more robust
implementation in coming diffs.

Diffs
-

3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/angular/README.md PRE-CREATION
3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.gzip PRE-CREATION
3rdparty/javascript/bower_components/angular/angular.min.js.map PRE-CREATION
3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js
PRE-CREATION
3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js
PRE-CREATION
3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION
3rdparty/javascript/thrift.js PRE-CREATION
build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042
src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java
d775edeae93d61850a8619a6675699560e941277
src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java
263591a1a387731be11936a7ad244cdc81b40a10
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
a3faf6be3635ec4f985867dd4598ad434a985fb7
src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st
5e540f303ffa3d057dea564b394a29508b03c03c
src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/index.html
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html
PRE-CREATION

Diff: https://reviews.apache.org/r/16528/diff/

Testing
---

gradle clean build

Tested the UI using the isolated scheduler.

File Attachments

Home page

https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png

Thanks,

Suman Karumuri

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client



> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 206
> > 
> >
> > Feel free to omit this comment.  I find the behavior pretty obvious 
> > from the args.

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > build.gradle, line 214
> > 
> >
> > revert

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 198
> > 
> >
> > I'm usually a fan of inlining functions where the body is one line and 
> > there's a single caller — less code overall.
> > 
> > Ditto below.

Done.


> On Jan. 8, 2014, 8:18 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 
> > 26
> > 
> >
> > Looks like leftover testing code.  Please remove.

I left the mocks intentionally so I can use it in the stand alone UI. Removed 
it now.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31390
---


On Jan. 7, 2014, 8:10 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> ---
> 
> (Updated Jan. 7, 2014, 8:10 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented new Scheduler home page using AngularJS. The UI queries the 
> backend using the thrift end point. This diff sets the basic foundation for 
> the page. Sending this out to get some early feedback and to keep the future 
> diffs small.
> 
> The URLs in the new UI will redirect to the scheduler role pages. 
> 
> Dropped the option to select number of results to be shown to simplify the 
> interface. Now defaulting to 25 results per page.
> 
> Cleaned up the UI to make it more light weight.
> 
> Added a mock service to render dummy data on the page. Currently, this mock 
> service is manually wired during testing. Will created an isolated scheduler 
> page once we have a single page app.
> 
> Updated build.gradle to generate thrift JS client. 
> 
> Installed Angular and smart-table from bower. Added thrift.js file to make 
> the calls to the backend. Will migrate to angular-thrift for more robust 
> implementation in coming diffs.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.map 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION 
>   3rdparty/javascript/thrift.js PRE-CREATION 
>   build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
> d775edeae93d61850a8619a6675699560e941277 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 
> 263591a1a387731be11936a7ad244cdc81b40a10 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> a3faf6be3635ec4f985867dd4598ad434a985fb7 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 
> 5e540f303ffa3d057dea564b394a29508b03c03c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
> PRE-CREA

Re: Review Request 16528: Scheduler home page new using AngularJS and UI client



> On Jan. 8, 2014, 8:11 p.m., Bill Farner wrote:
> > Would you mind moving the relevant ticket to apache jira as well?

Moved the jira task to Apache repo.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16528/#review31389
---


On Jan. 13, 2014, 7:32 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16528/
> ---
> 
> (Updated Jan. 13, 2014, 7:32 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-33
> https://issues.apache.org/jira/browse/AURORA-33
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented new Scheduler home page using AngularJS. The UI queries the 
> backend using the thrift end point. This diff sets the basic foundation for 
> the page. Sending this out to get some early feedback and to keep the future 
> diffs small.
> 
> The URLs in the new UI will redirect to the scheduler role pages. 
> 
> Dropped the option to select number of results to be shown to simplify the 
> interface. Now defaulting to 25 results per page.
> 
> Cleaned up the UI to make it more light weight.
> 
> Added a mock service to render dummy data on the page. Currently, this mock 
> service is manually wired during testing. Will created an isolated scheduler 
> page once we have a single page app.
> 
> Updated build.gradle to generate thrift JS client. 
> 
> Installed Angular and smart-table from bower. Added thrift.js file to make 
> the calls to the backend. Will migrate to angular-thrift for more robust 
> implementation in coming diffs.
> 
> 
> Diffs
> -
> 
>   3rdparty/javascript/bower_components/angular/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular-csp.css PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.gzip 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/angular.min.js.map 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/angular/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/smart-table/bower.json PRE-CREATION 
>   3rdparty/javascript/thrift.js PRE-CREATION 
>   build.gradle b4b055c3ae4dd1764d69033d9a666c49c770e042 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
> d775edeae93d61850a8619a6675699560e941277 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzHome.java 
> 263591a1a387731be11936a7ad244cdc81b40a10 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
> a3faf6be3635ec4f985867dd4598ad434a985fb7 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzhome.st 
> 5e540f303ffa3d057dea564b394a29508b03c03c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16528/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> 
> Tested the UI using the isolated scheduler. 
> 
> 
> File Attachments
> 
> 
> Home page
>   
> https://reviews.apache.org/media/uploaded/files/2013/12/31/03920805-bba2-4160-90fb-f137b79cde20__Screen_Shot_2013-12-31_at_2.28.42_AM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31620
---

Ship it!



src/main/python/apache/aurora/client/cli/context.py


this can be 'for component in key' since namedtuples and AuroraJobKeys are 
iterable.


- Brian Wickman


On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16423/
> ---
> 
> (Updated Jan. 13, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implemented client v2 versions of the diff and inspect verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/apache/aurora/client/options.py 
> af56351eed21805f09bfe50cb91745d58b665627 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16423/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
> already tested.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16306: "job status" command, with wildcard support.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
---


Ping?

- Mark Chu-Carroll


On Jan. 9, 2014, 5:29 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> ---
> 
> (Updated Jan. 9, 2014, 5:29 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added an implementation of the "status" verb for jobs. This is the first 
> command to use the new job wildcards, so there's a bunch of infrastructure 
> added to the Context to support it.
> 
> This also includes unit tests of the new command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2c08cf985a3ad9126a544596f895540524af865c 
>   src/main/python/apache/aurora/client/cli/context.py 
> c50f1a15847f5374a30d6bc93915123d8471e4aa 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> b789361313e279ac8398a92a46ec724c09fb4513 
>   src/main/python/apache/aurora/client/cli/options.py 
> 80fabb93945f38011b1e9c64ed20f8035ec146fa 
>   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 9528eed70e76431f720c4a26651ae0729903288c 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
>   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/util.py 
> c6d38304fb8ac89b9a175d8c20438a8831f784df 
>   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16306/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
---

(Updated Jan. 13, 2014, 10:02 a.m.)


Review request for Aurora, Jonathan Boulle and Brian Wickman.


Changes
---

More review fixes: in particular, fix up messed up merge.


Repository: aurora


Description
---

Implemented client v2 versions of the diff and inspect verbs.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
2c08cf985a3ad9126a544596f895540524af865c 
  src/main/python/apache/aurora/client/cli/context.py 
c50f1a15847f5374a30d6bc93915123d8471e4aa 
  src/main/python/apache/aurora/client/cli/jobs.py 
b789361313e279ac8398a92a46ec724c09fb4513 
  src/main/python/apache/aurora/client/cli/options.py 
80fabb93945f38011b1e9c64ed20f8035ec146fa 
  src/main/python/apache/aurora/client/options.py 
af56351eed21805f09bfe50cb91745d58b665627 
  src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
9528eed70e76431f720c4a26651ae0729903288c 
  src/test/python/apache/aurora/client/cli/test_create.py 
df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
  src/test/python/apache/aurora/client/cli/test_kill.py 
75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
  src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/util.py 
c6d38304fb8ac89b9a175d8c20438a8831f784df 
  src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16423/diff/


Testing
---

Added new unit tests for "diff"; inspect doesn't do any API calls that aren't 
already tested.


Thanks,

Mark Chu-Carroll

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.