Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-19

Re: Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/#review33762 --- The new patch does not modify the gradle-license-plugin sourceSet as

Re: Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/ --- (Updated Feb. 5, 2014, 5:55 p.m.) Review request for Aurora, Jake Farrell and M

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33750 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 5, 2014, 5:07 p.m.,

Re: Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/#review33749 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 6, 2014, 1:27 a.m.

Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17771/ --- Review request for Aurora, Jake Farrell and Maxim Khutornenko. Summary (updated

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/#review33748 --- Committed: commit c18a8e53d16a7d6fe5c16ac0a3713d511d1ea863 Author:

Re: Review Request 17768: AURORA-193: License header cleanup

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17768/#review33743 --- Ship it! Ship It! - Kevin Sweeney On Feb. 5, 2014, 4:24 p.m., Ja

Review Request 17768: AURORA-193: License header cleanup

2014-02-05 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17768/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-193

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33742 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 5:59 p.m., Ma

Re: Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750/ --- (Updated Feb. 5, 2014, 3:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/ --- (Updated Feb. 5, 2014, 3:19 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/#review33730 --- Ship it! Ship It! - Brian Wickman On Feb. 5, 2014, 8:42 p.m., Da

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 5, 2014, 10:07 p.m.) Review request for Aurora, Mark Chu-Carroll,

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
> On Feb. 5, 2014, 12:19 p.m., Bill Farner wrote: > > I've come across Abstract[Idle]Service [1] before and didn't look hard > > enough at what it offers — for those equally ignorant, this gives us call > > order enforcement for ~free. Awesome! Let's do more of this! > > > > [1] > > http://

Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-132

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/ --- (Updated Feb. 5, 2014, 8:42 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/#review33724 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 5, 2014, 8:31 p.m.

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33723 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Bill Farner
> On Feb. 5, 2014, 8:19 p.m., Bill Farner wrote: > > I've come across Abstract[Idle]Service [1] before and didn't look hard > > enough at what it offers — for those equally ignorant, this gives us call > > order enforcement for ~free. Awesome! Let's do more of this! > > > > [1] > > http://d

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33721 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 5, 2014, 12:45 p.m.

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/ --- (Updated Feb. 5, 2014, 12:31 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Maxim Khutornenko
> On Feb. 5, 2014, 8:19 p.m., Bill Farner wrote: > > I've come across Abstract[Idle]Service [1] before and didn't look hard > > enough at what it offers — for those equally ignorant, this gives us call > > order enforcement for ~free. Awesome! Let's do more of this! > > > > [1] > > http://d

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Kevin Sweeney
> On Feb. 5, 2014, 9:47 a.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java, > > line 1 > > > > > > same as above > > Jake Farrell wrote: > All existing license

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/#review33719 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-05 Thread Bill Farner
> On Feb. 5, 2014, 1:45 a.m., Bill Farner wrote: > > The approach here differs from (what appears to be) the smart-table > > documentation [1]. Did you find that approach to be unusable? > > > > [1] http://lorenzofox3.github.io/smart-table-website/ > > Suman Karumuri wrote: > Do you mean

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33717 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/#review33715 --- Ship it! I've come across Abstract[Idle]Service [1] before and didn

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33714 --- Ship it! Ship It! - Kevin Sweeney On Feb. 5, 2014, 9:45 a.m., Ja

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 5, 2014, 3:09 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Bill Farner
> On Feb. 5, 2014, 5:47 p.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java, > > line 1 > > > > > > same as above > > Jake Farrell wrote: > All existing license

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review33710 --- src/main/python/apache/aurora/client/cli/task.py

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review33708 --- src/main/python/apache/aurora/client/cli/options.py

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/#review33706 --- thanks so much for doing this! src/main/python/apache/aurora/clien

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 5, 2014, 2:27 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 5, 2014, 2:26 p.m.) Review request for Aurora, Bill Farner and Br

Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-124

Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17749/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-132

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Jake Farrell
> On Feb. 5, 2014, 5:47 p.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java, > > line 1 > > > > > > same as above All existing license headers within the project are

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/#review33697 --- src/main/java/org/apache/aurora/scheduler/events/EventSink.java

Re: Review Request 17717: License header cleanup introduced in a584410c.

2014-02-05 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17717/ --- (Updated Feb. 5, 2014, 5:45 p.m.) Review request for Aurora, Kevin Sweeney, Mar

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/ --- (Updated Feb. 5, 2014, 4:30 p.m.) Review request for Aurora and Brian Wickman.

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 10:08 a.m.) Review request for Aurora, Kevin Sweeney and