Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/ --- (Updated April 23, 2014, 6:55 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41118 --- Ship it! Ship It! - Suman Karumuri On April 23, 2014, 1:39 a.m.,

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 1:39 a.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41107 --- dist/resources/main/org/apache/aurora/scheduler/http/assets/diction

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-22 Thread Brian Wickman
> On April 22, 2014, 11:16 p.m., Kevin Sweeney wrote: > > LGTM. Please run the e2e test before committing. running now. will comment back in the testing result section. > On April 22, 2014, 11:16 p.m., Kevin Sweeney wrote: > > BUILD, line 20 > >

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41083 --- Ship it! LGTM. Please run the e2e test before committing. BUILD <

Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-22 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 20573: BugFix: Incorrect task count count in Role and Role/env page.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/#review41068 --- Also, please augment the summary to something that reads more nicely

Re: Review Request 20573: BugFix: Incorrect task count count in Role and Role/env page.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/#review41066 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:11 p.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:11 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:10 p.m.) Review request for Aurora and Maxim Khutorn

Review Request 20573: BugFix: Incorrect task count count in Role and Role/env page.

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-338 https://issues.

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-22 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review41056 --- Ship it! Ship It! - David Robinson On April 22, 2014, 7:38 p.m.,

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- (Updated April 22, 2014, 8:05 p.m.) Review request for Aurora and Jake Farrell.

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Bill Farner
> On April 22, 2014, 7:58 p.m., Jake Farrell wrote: > > Whats the bug associated with this? other than that +1 Exercised judgement that the ticket felt like busywork. I think we still need to achieve consensus on what role we want tickets to play so that we can share a mental model for when t

Re: Review Request 20490: Add a "get version" API method.

2014-04-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/ --- (Updated April 22, 2014, 3:59 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/#review41054 --- Ship it! Whats the bug associated with this? other than that +1 -

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review41053 --- Ship it! src/main/java/org/apache/aurora/scheduler/sla/MetricCalcu

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- (Updated April 22, 2014, 7:55 p.m.) Review request for Aurora and Jake Farrell.

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- (Updated April 22, 2014, 7:55 p.m.) Review request for Aurora and Jake Farrell.

Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description --

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/ --- (Updated April 22, 2014, 3:38 p.m.) Review request for Aurora, David Robinson a

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-22 Thread Bill Farner
> On April 5, 2014, 11:20 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java, > > line 195 > > > > > > It's worth noting that we can also wind up dogpiling here if th